Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
Date:   Tue, 8 Jun 2021 06:53:17 +0200
From:   Salvatore Bonaccorso <carnil@debian.org>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linma <linma@zju.edu.cn>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Hao Xiong <mart1n@zju.edu.cn>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: fix the erroneous flush_work() order
Message-ID: <YL73vTBtgWkaup+A@eldamar.lan>
References: <20210525123902.189012-1-gregkh@linuxfoundation.org>
 <BF0493D4-AB96-44D3-8229-9EA6D084D260@holtmann.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BF0493D4-AB96-44D3-8229-9EA6D084D260@holtmann.org>
Precedence: bulk

Hi Greg,

On Thu, May 27, 2021 at 10:14:59PM +0200, Marcel Holtmann wrote:
> Hi Greg,
> 
> > In the cleanup routine for failed initialization of HCI device,
> > the flush_work(&hdev->rx_work) need to be finished before the
> > flush_work(&hdev->cmd_work). Otherwise, the hci_rx_work() can
> > possibly invoke new cmd_work and cause a bug, like double free,
> > in late processings.
> > 
> > This was assigned CVE-2021-3564.
> > 
> > This patch reorder the flush_work() to fix this bug.
> > 
> > Cc: Marcel Holtmann <marcel@holtmann.org>
> > Cc: Johan Hedberg <johan.hedberg@gmail.com>
> > Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: linux-bluetooth@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Lin Ma <linma@zju.edu.cn>
> > Signed-off-by: Hao Xiong <mart1n@zju.edu.cn>
> > Cc: stable <stable@vger.kernel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > net/bluetooth/hci_core.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> patch has been applied to bluetooth-stable tree.

Can you queue this one as well for the stable series? It is
6a137caec23aeb9e036cdfd8a46dd8a366460e5d commit upstream and in
5.13-rc5.

Regards,
Salvatore