Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: kXCFAM14ZObdy6haxGSRXc7ExHMjQ2Xcd5+0xxVp8GYKtAOyf5FYFENXRiRLERh9nQZXGwG9nd
 G1ACtx9CAQaw==
IronPort-SDR: LXHAcPV9ZHcM3hYZzEF1KjS1tZwgYawxBnS42K6/E0OFATuHxz04S/a9kmzL4u4wEhDi8ggvhq
 1rL9vNu/kKDw==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>
Subject: RE: [PATCH v8 8/9] Bluetooth: Add support for
 HCI_Enhanced_Setup_Synchronous_Connection command
Thread-Topic: [PATCH v8 8/9] Bluetooth: Add support for
 HCI_Enhanced_Setup_Synchronous_Connection command
Thread-Index: AQHXS9IK3hV1Sk93tk6Tqnl6Ulpd9asCdPWAgAewGGA=
Date:   Tue, 8 Jun 2021 12:06:44 +0000
Message-ID: <DM8PR11MB5573C2583F106F1EFC8EC445F5379@DM8PR11MB5573.namprd11.prod.outlook.com>
References: <20210518104232.5431-1-kiran.k@intel.com>
 <20210518104232.5431-8-kiran.k@intel.com>
 <0141E444-5FE4-416D-BE10-DEE305EA0826@holtmann.org>
In-Reply-To: <0141E444-5FE4-416D-BE10-DEE305EA0826@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZV4Kb434gO4SF1JsXSrLFKe2eheUAcpDy8fek46H+gDVlI+Vo5lxe8KZocOT?=
 =?us-ascii?Q?spiMzfpl1oqFvJ45OZiG0+38vZkig5b3OgkY/jFkIH62fKPQmzVv/kZ+EMEL?=
 =?us-ascii?Q?dGXe5Ppz2LCPEmMqLKwJdCGa3quhy8Qb1C+lQt4gOYl3T5YQxmS13CkRJ5Lo?=
 =?us-ascii?Q?WY77a7MDggBzqP2XicGZwAT3G6FaZEoM5I5XT7qXD5xrnWR4TRNW3MlW+1/A?=
 =?us-ascii?Q?GKk1GcaAslssdaTI1W+ZDNa8GyZEIju5sXNOVOyaaGoiavIAo9DZSFjHev0J?=
 =?us-ascii?Q?Xhh9Txp+5YQu+/hE/z4AiYeiOx17vU/dOtTCyd5z+Y09SMNxVhgrNxDfGHKD?=
 =?us-ascii?Q?XdKZ/SbgCKyf2bOLQOmccckoeKO433Y3vYul2rV/8LZVFKfDBPjSso/UnhG/?=
 =?us-ascii?Q?ocrPLebQH/hr6zKcdO6AocWtc223av/RYNJQlZhlpuvUcSedR1v2o3qHe7J1?=
 =?us-ascii?Q?DsM4n+8/UzHRoqRMcNgenV2fE42+71H2VMPzF5JoY79AUTO5eXzZC8QfI26s?=
 =?us-ascii?Q?g5ZGHV+nd0L4DwfJJ56xmpIPDiHh6ha+KwiStKa+7dexkWXp5KFhpEauT/FY?=
 =?us-ascii?Q?4PdK5mRUQjqJtb6WUz9dNRn8uf88qD1rJdyr7A8Tlf2LXVoG6wcz922ojY1J?=
 =?us-ascii?Q?cbZS8svp2go9WHlRpTVvMtrG5X8qJVG4hpisQntllQl0glU0TDy6W5vfwiLg?=
 =?us-ascii?Q?vz8WaKBNn8iJcMcVjxRGan9TRRGLqbL70TLTUbwd1cPsr/DOqU6vVqY8rCiL?=
 =?us-ascii?Q?JE4uYQLbGv1/4uFyqDBX1qwDHYANSnshcAeHKxlTCgwj1hZs3PnX0W5y7kGe?=
 =?us-ascii?Q?gGn+drGj2iqszvDaL7hrmFeWlgpFMflOYcm0aX03uC+zvYt4HHbMmPVD4lQ+?=
 =?us-ascii?Q?/0TzEd6S7FI3FVYjY5IJgozMv9JPqgbpML9NvDdyBvU65HYtts1BwBLZqDSp?=
 =?us-ascii?Q?ejoRiEkHDlTW8aY0FjX1sUwGrRXu5ScAD/dGgcZhxZSiOASZdzaQ0VYjgKBH?=
 =?us-ascii?Q?DkG/kPyfZfnx8aKmMSUQiaJ+BU/5T6zmVmrVv0z+AK+e6fcRX5B/bMvuMlby?=
 =?us-ascii?Q?sW2kWPNN7XdOjjOa7xd6Ddv1IdT5h8DifDF0FkmxoBaEUepikFmcz/bLC62o?=
 =?us-ascii?Q?wKwnkcOHqt1fYNPm+8ea2F0aUWUk5UyEb2uGmw+NH0kXKgnKo6b0VnTOWQ1R?=
 =?us-ascii?Q?yYc8uMjcJ0zi/WH+JvE7M75cfJrazKksTzhBbYst2B3NtwFrkV0tqadM8gMy?=
 =?us-ascii?Q?q/8V6BiL4XUN0164x6NFygMpiQsZyIXslL39F2kREf27TpKhGn24KAMaK6g7?=
 =?us-ascii?Q?lY4kUUdl6Esp67V7FqLTNtDp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c7ee78f-927d-4a56-7c37-08d92a75e241
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2021 12:06:44.4600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8iMpuTIurFEotd2wcp8hT/rhQpCkEFmJRanX+ieF6FgzgU6JuJt+aFeoN8kRPDN4EgwTt/it2PATRqRWbPSHQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5592
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> > bool hci_setup_sync(struct hci_conn *conn, __u16 handle) {
> > 	struct hci_dev *hdev =3D conn->hdev;
> > @@ -424,8 +514,12 @@ void hci_sco_setup(struct hci_conn *conn, __u8
> status)
> > 	BT_DBG("hcon %p", conn);
> >
> > 	if (!status) {
> > -		if (lmp_esco_capable(conn->hdev))
> > -			hci_setup_sync(sco, conn->handle);
> > +		if (lmp_esco_capable(conn->hdev)) {
> > +			if (use_enhanced_sco_conn(conn->hdev))
> > +				hci_enhanced_setup_sync(sco, conn-
> >handle);
> > +			else
> > +				hci_setup_sync(sco, conn->handle);
> > +		}
> > 		else
> > 			hci_add_sco(sco, conn->handle);
>=20
> you have coding style mistake here.

Ack.

>=20
>=20
> > +static void hci_cs_enhanced_setup_sync_conn(struct hci_dev *hdev,
> > +__u8 status) {
> > +	struct hci_cp_enhanced_setup_sync_conn *cp;
> > +	struct hci_conn *acl, *sco;
> > +	__u16 handle;
> > +
> > +	bt_dev_dbg(hdev, "status 0x%2.2x", status);
> > +
> > +	if (!status)
> > +		return;
> > +
> > +	cp =3D hci_sent_cmd_data(hdev,
> HCI_OP_ENHANCED_SETUP_SYNC_CONN);
> > +	if (!cp)
> > +		return;
> > +
> > +	handle =3D __le16_to_cpu(cp->handle);
> > +
> > +	BT_DBG("%s handle 0x%4.4x", hdev->name, handle);
>=20
> Please start using bt_dev_dbg.

Ack.

Thanks,
Kiran