Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5191205pxj; Wed, 9 Jun 2021 11:15:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJ6/CpFTcRWn5NEcV4BFheNfIYxvmPLXVjZSsS+APyJgcat5MxebnpuhE0ZmkSni1AQnZF X-Received: by 2002:aa7:cb5a:: with SMTP id w26mr710831edt.139.1623262548709; Wed, 09 Jun 2021 11:15:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623262548; cv=none; d=google.com; s=arc-20160816; b=WFFP4Fq3aexPKM3Hm5Liwwkja+A7oOMoSs1bFe3BTdD6Vlwvre4i+D/QDpnIrTxVZ3 jsIUd58hD9cOrl8oSqhcqlfTWxRkxTEPk5LpLxyhK4g8n5hoVBKERQDp4szjv7kPwH+d Ukfo4kitG8DDxnPk/kSJ9PLhWB1Edf8CT6D75nqKg13+ERdZ4FXAH1yyBoOZlKsghK4d Pu2iPPPNtFGho8qV0QX6gDlJ+Q8DyHhAFGg6K7Cc0GQ9fvqEvRbs9XEQQP8zeeu9B5Er k1rjRTJuZO9T1lAFr7FpKRcaOObhSQOyCExk5JLNNgwmDF4hXQD1+BMKhfEN5rJ0Ys3R PCcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=26jC/wgBZ+t1Ap5tkofW0NlWVxgOjqt14XFXYTZhyC4=; b=IGMDKu3ZMICikin0XGmtyaps1FP9147Vpl6MeubnvzeY9nqv+ruSBU40/K7CScfQ3q 79R8YU3y1+2oCR4Y3MXqRrLq/iO8J1qVrBUWxOQ5NdaU4KtlHqkVgESnpznDaNSOZU+I O8FhbONSuwUzTwro8yK8ebJ6FHODnYMQexCGw8xZ3WH5JwLQf8aicx2PEZLVhXgij/St HmWsXJ5x6z/8ioq/2QBlJDjlRj5iw20U656yagpZHk3aXv5POqUu66WKppunoK2AulOF V4hbOCzpKswUkoZtpD9YOO6bZV1kZLkLl46MKB2cSm3vU4wQEqQb0OYJQeXxElWyw50z bGNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kFjRh2cf; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si305077edw.252.2021.06.09.11.14.52; Wed, 09 Jun 2021 11:15:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kFjRh2cf; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbhFIRNv (ORCPT + 99 others); Wed, 9 Jun 2021 13:13:51 -0400 Received: from mail-yb1-f180.google.com ([209.85.219.180]:34786 "EHLO mail-yb1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbhFIRNu (ORCPT ); Wed, 9 Jun 2021 13:13:50 -0400 Received: by mail-yb1-f180.google.com with SMTP id i6so21877237ybm.1 for ; Wed, 09 Jun 2021 10:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=26jC/wgBZ+t1Ap5tkofW0NlWVxgOjqt14XFXYTZhyC4=; b=kFjRh2cfpp7Sb35yP/Rkj5hjgxutlnQ2M22Z6wIOe4LDfoZvDtqrrq8IaGyFB2PoVc nEkymGsVDmZQwEDSDyib8z/OQ0A8mtp5z1AOqZTNMTvYxrXNUU26mmk6fAwnoF9aliay k+FziOh3jBNynVfNc0oi1l1g2YF13GbsMXu3n+4+LV/Q/5Y/o0zshP6kOFcxGjABMElf Y2e/W0rN2ikuJdAfpPWOiKDHBb5s7q37aD/TgJzcNmmFGV7RJQ7SFFbyfLdCs238St/F i6Uo2rMArB/sP74iD8axsDXmOO2ZFvK7WzGIFjeUwGi+75eEGGd+5Vmgs/ps2a5C+BWZ a17w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=26jC/wgBZ+t1Ap5tkofW0NlWVxgOjqt14XFXYTZhyC4=; b=uecexJ2lyFxu29XQfS4nk9+FeuRn4Fl1MD21+hTy+BKXscZhXKTM4gi1rSrIjq8fta mHZGQzN/WygUeez3KdoIhd8jXql4qTYhZXNZlTP2LcwjItbUfW+u+gzaD7c+366b1ccC ffPI5Fds3IS86+xLQMKHcxypCx6onLArZ/ridXQxxdxd/bfUEXGtZTGJ7ZHZc7ay6SLQ O6e4hG4ekzMFUq7jWNSmUCUOf+pYyF+2bQRrmVK915zNUFXHMOh/7Pm7CTbr8e5hSxTT ROszqRn2RxLtnBwD+TUMnkNezlrQmYScLD+zWSIKdhKCq0GFAgbtNhLO/BLzEiWBlmvf olQw== X-Gm-Message-State: AOAM530XvPflqCkxAo2Esjf1TWdGGH7ZjXbVv086U5jrvxeGYOfjrJn3 clgP7Ln5GbOvKsmkSO8pCZDIMLdCf/siHfAQqaXXNA36 X-Received: by 2002:a25:c60a:: with SMTP id k10mr1360290ybf.264.1623258643018; Wed, 09 Jun 2021 10:10:43 -0700 (PDT) MIME-Version: 1.0 References: <20210608184457.3069064-1-luiz.dentz@gmail.com> <6AC22489-B3C4-49B8-AF19-A0AEC8CFD91B@holtmann.org> In-Reply-To: <6AC22489-B3C4-49B8-AF19-A0AEC8CFD91B@holtmann.org> From: Luiz Augusto von Dentz Date: Wed, 9 Jun 2021 10:10:32 -0700 Message-ID: Subject: Re: [PATCH] Bluetooth: HCI: Fix Set Extended (Scan Response) Data To: Marcel Holtmann Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, On Tue, Jun 8, 2021 at 9:52 PM Marcel Holtmann wrote: > > Hi Luiz, > > > These command do have variable length and the length can go up to 251, > > so this changes the struct to not use a fixed size and then when > > creating the PDU only the actual length of the data send to the > > controller. > > > > Signed-off-by: Luiz Augusto von Dentz > > --- > > include/net/bluetooth/hci.h | 6 ++-- > > include/net/bluetooth/hci_core.h | 8 ++--- > > net/bluetooth/hci_request.c | 51 ++++++++++++++++++-------------- > > 3 files changed, 37 insertions(+), 28 deletions(-) > > if possible, please git blame and add Fixes: tag. > > Regards > > Marcel Will do. -- Luiz Augusto von Dentz