Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5235639pxj; Wed, 9 Jun 2021 12:24:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoMSIAxjBDSPbdFf0H2b/tQZvy6hSce2lgYtO3/g1+y+AKH7yFlD+hZyfY+1Cg5oKIkVs8 X-Received: by 2002:a17:907:9813:: with SMTP id ji19mr1324840ejc.318.1623266686829; Wed, 09 Jun 2021 12:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623266686; cv=none; d=google.com; s=arc-20160816; b=tWnzEYZi6Zv7dO0ufhhB/CoYa8Z1+jsfKYmQHVbd6rTRfV8n+2o3ppSWm/B/BUF/iY m0J8AQEz70wPt9/MZhSoEHBqz3N1uWzZv1VoFUjcpoBn+VSYe3+fjg5ic8xDd6gxEY54 xzzHbZP0Rw89aMK+xGkGLVjzgLupGeeBI01grVi2boF7TMWuqvmTur26SY4LKwQtF7Of Od6b7NVDLtFxalYi87iYkFJh5qomP3ZkXEYJwZvtfoxbuWTcQ+gYrI/rbmKb7oAFC5Cm sKEonswuQItxMUke6Cpr7NEeg2wpU3YyEqARxbUPCz0RZcw8tXNRE1A/9qyrkYENH6hz QLpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=bocIbltv1MpMHdfWl1uulnYTAhIzurN6yGoc9KSwFWU=; b=xWWun65f9LkNe9c1hULc3/1qHcPjdKgg9ESdOAtWOiX2E+lag8WePGE+Ahg/VukoW/ 1OnfsdoFcK/RNyoDALE1iIUI2DIj/S8qRXe5F1Vcwa270pNtuRMOQ2YI7tMXI8TMQSG8 LzrhXzdW03hvFUDT19Ra0UDPaId5PYvWCBGSaoFO2xsQrE+DPH7rLFQ48S6f6wXJhTp/ iHrj8/65P4cYGM9kbAlrn21Sxsg1YzV0Mnr4T9AOGdfyMSNSgJBSaa7CbhZu4AvvwSld EmUuUul9QMgrloOBhsbjZ77NGDtzBN6uz8YuxHm6CTQbReYeqpdV+B2/8mtH+OyvsGhy Sd7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si598927ejx.161.2021.06.09.12.24.22; Wed, 09 Jun 2021 12:24:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229499AbhFITZC (ORCPT + 99 others); Wed, 9 Jun 2021 15:25:02 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:60155 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhFITZA (ORCPT ); Wed, 9 Jun 2021 15:25:00 -0400 Received: from smtpclient.apple (p4fefc9d6.dip0.t-ipconnect.de [79.239.201.214]) by mail.holtmann.org (Postfix) with ESMTPSA id 5124BCECD6; Wed, 9 Jun 2021 21:31:03 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH v2] Bluetooth: HCI: Fix Set Extended (Scan Response) Data From: Marcel Holtmann In-Reply-To: <20210609180927.179265-1-luiz.dentz@gmail.com> Date: Wed, 9 Jun 2021 21:23:03 +0200 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <74BFE4B6-E0DD-4836-9AE0-20D9D34F0BC2@holtmann.org> References: <20210609180927.179265-1-luiz.dentz@gmail.com> To: Luiz Augusto von Dentz X-Mailer: Apple Mail (2.3654.100.0.2.22) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, > These command do have variable length and the length can go up to 251, > so this changes the struct to not use a fixed size and then when > creating the PDU only the actual length of the data send to the > controller. > > Fixes: a0fb3726ba551 ("Bluetooth: Use Set ext adv/scan rsp data if > controller supports") > Signed-off-by: Luiz Augusto von Dentz > --- > include/net/bluetooth/hci.h | 6 ++-- > include/net/bluetooth/hci_core.h | 8 ++--- > net/bluetooth/hci_request.c | 51 ++++++++++++++++++-------------- > 3 files changed, 37 insertions(+), 28 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel