Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp31473pxj; Thu, 10 Jun 2021 13:55:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4VMAS7qyGr40Lmlp01S+3kIpyQQb/4rvpHtWagsFmPM5YaDWH20OqAZ5N/j5El6XiRARn X-Received: by 2002:a05:6402:885:: with SMTP id e5mr381165edy.248.1623358531253; Thu, 10 Jun 2021 13:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623358531; cv=none; d=google.com; s=arc-20160816; b=FOZRrKqvnU45PUlQ0jvp2/7VCw8Ut9pCfnR4rt5xQTq6zX9DMafoWKXVMDkVBm/3Ze Jf2hjZhCRfisX78Obi2q18CXGWxXv5I6Rbd1B4xVmKWYQOHvNu1gBOa6zWR1TvkWX5hf k7bQlpRRJr1XW9w9RT6rglCNPx/+o4UMVSuLvLf3bl2ZUyL2kO/rDaQjgiISKw3b7aAM lALJK0U5zwS1d7FYTN/pF98wDX1OevPFqwls/zUalCn39nF9aHuxOvKr/K44ogcyhyJp HVNd5X9Thk6pbo/NjYoEaxiL5vsBjUUVnRfQqtnjc2lQeC70evd1dW5rUQ5N2pPgSBE6 3QgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+1sPzTurp4wqo2OLG72xu3f4JnLHRA4Rv7k/HLdpytc=; b=muVnUQUR5bHzVUEzHPLSvGT931eUyfKmoul4+rLjPKAiXdoskx7uFeMfG4b0hevXLt VqG3EBk5k3Cokjx2YkQCQS+cba8WGCDlsW+5JdXxjJw1bby5D25RhvgVRA/IQ6i/wFEJ pRoqz9fc8cJBkkvt9wAoAAfTErsPhUKA8M1Ngfd98D1fzI74yNJOsxyEXL7zqLJUceTa B0jeX8Bi04msmRIqImQPmJu3bb7/YQJO1yFu8tYZyByLPn+IJEqymIRCh2KT5vvueaAs hYbBaG40L5JVzxFF3as2kdjVaUlssI/ysovVDXW6Yjcks3BaT9bOb8hDqKzWUTrlxJB9 0jLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L2RbdwPd; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si3118102edu.413.2021.06.10.13.54.41; Thu, 10 Jun 2021 13:55:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L2RbdwPd; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbhFJUye (ORCPT + 99 others); Thu, 10 Jun 2021 16:54:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbhFJUyd (ORCPT ); Thu, 10 Jun 2021 16:54:33 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A130C061574 for ; Thu, 10 Jun 2021 13:52:23 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id b13so1227634ybk.4 for ; Thu, 10 Jun 2021 13:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+1sPzTurp4wqo2OLG72xu3f4JnLHRA4Rv7k/HLdpytc=; b=L2RbdwPdgSd/yQLh3knxxSlGUVcm6C4K3KrGmfuP+ppB4S2ZldV6hxAItZyFU94vwr 9Yom5mCte05/PhmWKFeSQqIMo51QtADy2m1qgOq/3Gf+0Qjd49u0dB3RAhP+lcL4EEiI aOajF3XnM5Zo+FJ18z6ldrSA1GT8sc8agHXFq8q+22hKOvl84akyxI6xzXeKT6QnFJiJ /IE5UvVcllLty+qs4GMT4SKCe3aHnXE9kizg8WnW4F+/WWApLgXzNwkQRUrBnZ/7H6Dn TylM41CIGv83WdsE+dScHPgqACH/8BTtjw4tzR14Cll/Hi6nYakwoMSs13ImJu9NKeqA 91Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+1sPzTurp4wqo2OLG72xu3f4JnLHRA4Rv7k/HLdpytc=; b=Hg/7auUNlEJ0JEL03YIJZUsr6MV844lAuADYTc58tWuJbDbIly6wGSuwxvpUU7dXtf AityvtN5daf5UFvZ8ZULznlq/8wpP/lvaEghaBzChcJNAlg6dGofIcfARQ7avK4jzh57 cUzOG3N459eb9WG5VvPFUfVRCoZ3U1OFsSuB6hJn6LHR5xmQxLhZvop6Npiq+ENqxKdv fQBrIlfCoZaBelvH1zKxjomDmFJ4YgSEQ6QjNcQnjDAa62UNi79TKwz/DSRX+JqMIDa9 8Ng9P3poSLzAT9I73p5x0rZdMelK5EyYp2vD1ALdkLDrebtPEWq3HO3rbOnG639cqf8o TNTw== X-Gm-Message-State: AOAM53284zk/QTJNW1nCKPperMSq0ZV1qcA0Pw5gaGWjwGzibMhGCCx7 Fr+SkhCJoU8hTWbmhy6EASsFvVeHIPOsnlpiT0uy1i12 X-Received: by 2002:a25:a2c5:: with SMTP id c5mr961356ybn.432.1623358339524; Thu, 10 Jun 2021 13:52:19 -0700 (PDT) MIME-Version: 1.0 References: <20210609222035.297833-1-luiz.dentz@gmail.com> <20210609222035.297833-2-luiz.dentz@gmail.com> <3E85B755-5B79-4DD3-AD17-F8907B5E854F@holtmann.org> In-Reply-To: <3E85B755-5B79-4DD3-AD17-F8907B5E854F@holtmann.org> From: Luiz Augusto von Dentz Date: Thu, 10 Jun 2021 13:52:08 -0700 Message-ID: Subject: Re: [PATCH v2] Bluetooth: HCI: Fix Set Extended (Scan Response) Data To: Marcel Holtmann Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, On Thu, Jun 10, 2021 at 12:37 AM Marcel Holtmann wrote: > > Hi Luiz, > > > These command do have variable length and the length can go up to 251, > > so this changes the struct to not use a fixed size and then when > > creating the PDU only the actual length of the data send to the > > controller. > > > > Fixes: a0fb3726ba551 ("Bluetooth: Use Set ext adv/scan rsp data if > > controller supports") > > Signed-off-by: Luiz Augusto von Dentz > > --- > > include/net/bluetooth/hci.h | 6 ++-- > > include/net/bluetooth/hci_core.h | 8 ++--- > > net/bluetooth/hci_request.c | 51 ++++++++++++++++++-------------- > > 3 files changed, 37 insertions(+), 28 deletions(-) > > I assume you accidentally send this again. Yep, it was stuck in my outbox for some reason. > > Regards > > Marcel > -- Luiz Augusto von Dentz