Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3058498pxj; Mon, 14 Jun 2021 13:24:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTSBv9DsyJPfhDgcRcaG4Khbk1gOklr4v1dmUHlcpwOdTK87dxq18JlFwpvo2QlPI0v3pI X-Received: by 2002:a17:906:a043:: with SMTP id bg3mr14838062ejb.444.1623702292020; Mon, 14 Jun 2021 13:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623702292; cv=none; d=google.com; s=arc-20160816; b=cdAeiskAmGgezHlBb3uXw4Qb33bx6dFj44W82P/d/76/2hd5bjLz/LWFsJqPAfdiJz yLYJ7ssEQukL1GiSKNE58WaK2ku4ggGDQvn8gtU3Da+iEjYMeYmprljz/Ud3jrDHZt9l Ha4GA5HhCYVMJfI7eUWIWttGSe8KehxcpzHe/bv7BaEXcTK/fA2B0kDMCj1X4lG1FAhM vmZXVl7dwOEiyBJ7odwWBDES9YrBPuPk6euS3j3B3qFIkgBGuMh8Sp2dEAHkMLPlF0FE WBrq2HQzpSUNOsNequZl3DXddoL5PiMnvTVNHGuyh7tKk6yxozBCK54S7f6W+Pn0IrSA KW8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=eaeW67DPzx3/ZqVSv72iKapXNTiHIGQPtF4tlnnB79g=; b=Axuocyihi1BEqPjNhtVn5vRfgel4yozp4XZZCGjvhop524Tqce5TBODMzhzxo1GkjX j7uhGZAnBseWrwDX6RTTfVLubc/wryO1rrTInM40Z0xqxlZVw2B0JXa4NdDZT2KjxEdO Rgn2Mxg/Qjl0TVIQRQYtYCQlzRViGhPTJsO32Z+KmoqmzA5kXbkdw8lp7789FO51Gk/x /OlW1BCXXDnxuXgYDGjKX21J6k+6Rtja7+rQm6jvrYzNxvwBCLFV2NGvPXWtYnzT+xZJ 9zxr1MkAkFuysDwH1nDwHKvM+yaqWEeyHNuKYNfzEISQRrS0CNCYfIaFsHYmeJRCvDs1 aV5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j4si5418721edn.569.2021.06.14.13.24.05; Mon, 14 Jun 2021 13:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233799AbhFNUYq convert rfc822-to-8bit (ORCPT + 99 others); Mon, 14 Jun 2021 16:24:46 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:43777 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234353AbhFNUYj (ORCPT ); Mon, 14 Jun 2021 16:24:39 -0400 Received: from smtpclient.apple (p4fefc9d6.dip0.t-ipconnect.de [79.239.201.214]) by mail.holtmann.org (Postfix) with ESMTPSA id 748C4CECDF; Mon, 14 Jun 2021 22:30:31 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: [PATCH v2] Bluetooth: SMP: Fix crash when receiving new connection when debug is enabled From: Marcel Holtmann In-Reply-To: <20210614174644.1259909-1-luiz.dentz@gmail.com> Date: Mon, 14 Jun 2021 22:22:30 +0200 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <87DEADEE-2B40-4AA2-A071-97BB49DCFEA2@holtmann.org> References: <20210614174644.1259909-1-luiz.dentz@gmail.com> To: Luiz Augusto von Dentz X-Mailer: Apple Mail (2.3654.100.0.2.22) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, > When receiving a new connection pchan->conn won't be initialized so the > code cannot use bt_dev_dbg as the pointer to hci_dev won't be > accessible. > > Fixes: 2e1614f7d61e4 ("Bluetooth: SMP: Convert BT_ERR/BT_DBG to bt_dev_err/bt_dev_dbg") > Signed-off-by: Luiz Augusto von Dentz > --- > net/bluetooth/smp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) patch has been applied to bluetooth-stable tree. Regards Marcel