Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\))
Subject: Re: [Bluez PATCH] monitor: Adding missing device found flag in the
 parser
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20210615200005.946131-1-alainm@chromium.org>
Date:   Tue, 15 Jun 2021 22:05:57 +0200
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>,
        Yu Liu <yudiliu@google.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <DAF1B1B4-9F58-4564-9E74-7D69BF41C53B@holtmann.org>
References: <20210615200005.946131-1-alainm@chromium.org>
To:     Alain Michaud <alainm@chromium.org>
Precedence: bulk

Hi Alain,

> A new flag was added to the kernel implementation of the Device Found
> event, but had not been added to the parser leading to an "Unknown device
> flag" error in btmon.
> 
> Reviewed-by: Yu Liu <yudiliu@google.com>
> ---
> 
> monitor/packet.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 82513a63c..2c3a6cebf 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -12033,6 +12033,7 @@ static const struct bitfield_data mgmt_device_flags_table[] = {
> 	{  0, "Confirm Name"	},
> 	{  1, "Legacy Pairing"	},
> 	{  2, "Not Connectable"	},
> +	{  3, "Connection Locally Initiated"	},
> 	{ }

please fix also the other }, so that they align.

Regards

Marcel