Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qaLzGidOaCrkTCqloJuoG0Jg2jGTB/QpW1Bnv9OYodlQU6aFZmaqh/2gbezhXrqGzumzzohzm2
 HmJ615FObiig==
IronPort-SDR: 6h3J/Z2H768cPhHMlSsle/rr+zS97TXAVvQi1aEz1eE60eJALjJmHnfTBDq9oQzJufkKqg/8sT
 FKwZhsPkqDCw==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH v9 04/10] Bluetooth: btintel: set get_data_path callback
Thread-Topic: [PATCH v9 04/10] Bluetooth: btintel: set get_data_path callback
Thread-Index: AQHXXGDBSyqzet0naUma6YfeaF9t/6sVgPyAgAB9BRA=
Date:   Wed, 16 Jun 2021 03:02:23 +0000
Message-ID: <DM8PR11MB5573E150E4FF4B5F69FAC9CBF50F9@DM8PR11MB5573.namprd11.prod.outlook.com>
References: <20210608122455.19583-1-kiran.k@intel.com>
 <20210608122455.19583-4-kiran.k@intel.com>
 <DDBF23B0-10C2-4B4F-8296-8454CD8F7AA6@holtmann.org>
In-Reply-To: <DDBF23B0-10C2-4B4F-8296-8454CD8F7AA6@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?triKe+rdFleEkLg3CoNXosOoNwuyvUhaZzQvegRHybCtw6ePlWuYnVEJXZWe?=
 =?us-ascii?Q?4n1S8anM9GN5ZQ4a+Z1Oz2KSTMd6savPcRDp6fuT/tzp8k9w0FRdcGFh70gQ?=
 =?us-ascii?Q?+ZGnnk5LiPPdaEIhwsBZjpWrANJO9THqVc1mxicjr57Id4OEpE4f/x2G54Lp?=
 =?us-ascii?Q?z0S/V8apRRcG6xA3+gwgcEmCHZwnMCzdrdNUbXU/SYB808VwKwYJLZ7Qq0I6?=
 =?us-ascii?Q?ohS/o5n/SDJKVtMrdbVwMQ9Kb75aPdG2lf+5rVvPSAD0FD6xx5BomN7pCqqu?=
 =?us-ascii?Q?k3QIlzt6nenmK9FdNgg6pimPaD0rr3bhR/pVlXHYAtS8frRfNo0dtS0o6heS?=
 =?us-ascii?Q?sJqezCTh7kV0v+R5GjDNGHO9/V9Uj4bMo6gRrQhC4hp4vi00JnuBX+9Uzlnu?=
 =?us-ascii?Q?qGpWzwRnGxKv6sVJ8nTtQmS/5m8zX2mLetCVuqeDboxVIcLZ65rpbhYUN8Cf?=
 =?us-ascii?Q?LxiQ4JzywA+uzOBlMhbvLapptS7M3F7Fw+ZlASPxQjAHPhIrGVmk7CevVPOP?=
 =?us-ascii?Q?ADHxKD6ktnNc2iFjKr3qHzhBB92PIG1GjhRrvponfnxzWPYAd2Qn1reoT/Ae?=
 =?us-ascii?Q?fDOpXXFX5D9vAJYUbdolUETr9EVemGKSht1+AGfNrhXsLIZgsz/KwMkI+pT+?=
 =?us-ascii?Q?C7YJTUyhsdH0kSbejN6Yhc/QV2cAdOnOOQuAk+oY1ERKt/MwloLGemYd4sYE?=
 =?us-ascii?Q?k12c1a373u83sWDf+9yLkj1KAQjYb6IlzP6+AoY3QOZl3COgnBm+gn4H+pDE?=
 =?us-ascii?Q?xhJhDDqKBOgMu+kuiUMiOQrkSufiL02JTzEKPsgErOHq0cUaGsbRfPSrF1V2?=
 =?us-ascii?Q?bB3DPbAayRHw2/ixGU+eg2g2tOw9XuYI65C0tHK3InioSqTzTaCzMepPe89R?=
 =?us-ascii?Q?TL2OzEFThQU8dSoOkHCpPFW+b+Bdu1BPKTmlbvkX31aVxTs3ZVTJjEk4lrYQ?=
 =?us-ascii?Q?QzC9hW58KvjSwuK352rTJz4HivZ02lNrdC9EJZoyHT4vSFiXCiBDE6dq3rVT?=
 =?us-ascii?Q?wnZNHDV+/nTyYz+DAv2+m4EJ2GiP3XK7TTjHRPTGX6vzVTBuTKQ1XzB8PYn7?=
 =?us-ascii?Q?EAFvRfLUCrLKYbed3Ryc0EWbsQR9BNXXD2LO3KcC4H/fuu5+nVrxbS7t5Rl6?=
 =?us-ascii?Q?lXyRB25RrMc5dce7vsepqcvn4EbfaJgFepvVq/gsLIWbRHIPFaF04oqOMdVg?=
 =?us-ascii?Q?Kh49HKU4ueCQ20Mr8mGMdq/sDqCiSpcBn6DiNXkc3mle55ypmYq2uCowq4ZI?=
 =?us-ascii?Q?hthPRsu9oKx2fumrbwbRozkChedY/MnZHEyDqsQCjR4jK2qaTvjfgNOyqpBb?=
 =?us-ascii?Q?oYAuGJGRNT4jAATEX62KMSvR?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30131cf2-eae6-4d3d-1035-08d930732a0f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2021 03:02:23.3632
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: smHaZLGq8zma9CeNxIqXh+cfGsto3FFXnHuA91GLM0ZW8e+fwQU4cKqRArmwBXq2UTcdNbpOrRHCU7w0LlkXbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5656
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> Hi Kiran,
>=20
> > Read supported offload usecases and set get_data_path callback if
> > controller suppports offload codecs.
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index a9855a2dd561..1e51beec5776 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -2952,6 +2952,7 @@ static int btusb_setup_intel_newgen(struct
> hci_dev *hdev)
> > 	int err;
> > 	struct intel_debug_features features;
> > 	struct intel_version_tlv version;
> > +	struct intel_offload_usecases usecases;
> >
> > 	bt_dev_dbg(hdev, "");
> >
> > @@ -3008,6 +3009,13 @@ static int btusb_setup_intel_newgen(struct
> hci_dev *hdev)
> > 	/* Set DDC mask for available debug features */
> > 	btintel_set_debug_features(hdev, &features);
> >
> > +	err =3D btintel_read_offload_usecases(hdev, &usecases);
> > +	if (!err) {
> > +		/* set get_data_path callback if offload is supported */
> > +		if (usecases.preset[0] & 0x03)
> > +			hdev->get_data_path =3D btintel_get_data_path;
> > +	}
> > +
>=20
> I really wonder if this exporting everything single detail to be just use=
d by
> btusb is really a good idea. Would it be just enough to have a
> btintel_configure_offload(hdev); helper that does everything and be done
> with it. There is already too much Intel specifics bleeding into btusb.c =
and I
> think we need to correct that going forward.
>=20

Ok. I will refactor this to move Intel specific code to btintel*
> Regards
>=20
> Marcel

Thanks,
Kiran