Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: sIAg4yqjr/pgrzCTqhxsb5kM+006UumZnkGHEuS2ShiZLgBzl0nMwgQre4wi91+Kbh93czLCam
 VzAX7ugzT5YA==
IronPort-SDR: uLaBR5g3mTK9l+kaDJbz8GagPs9ZcCSCrEm8RN0VbiHZzJ3h44HnhT2TPcoyjiPcE7zSxNtvM+
 RVASxJFF6FHw==
From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: RE: [PATCH v9 10/10] Bluetooth: Add support for msbc coding format
Thread-Topic: [PATCH v9 10/10] Bluetooth: Add support for msbc coding format
Thread-Index: AQHXXGDO/3TdA4SJhkiMoaR3Yfh+MasVhL+AgAuANUA=
Date:   Wed, 23 Jun 2021 03:24:01 +0000
Message-ID: <DM8PR11MB5573E6535A15DBE24306AE1FF5089@DM8PR11MB5573.namprd11.prod.outlook.com>
References: <20210608122455.19583-1-kiran.k@intel.com>
 <20210608122455.19583-10-kiran.k@intel.com>
 <AA50351C-7DF2-4732-8493-A57616918B11@holtmann.org>
In-Reply-To: <AA50351C-7DF2-4732-8493-A57616918B11@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jpV4YwYiiX7VnVu9AjY+1b/SaG+96tYWOP0zSCdpOTwti6eFAAAmcFTWixM0?=
 =?us-ascii?Q?YIrsSdyO9eedMVvhFeK7yZS+DfgIw2oQHqnfJsIJ5aKWcgNhj1zGLFE90L07?=
 =?us-ascii?Q?LtCLsh8lihEiHKj//1Aab0GhtlkzPQfEbjjxUbVYNwM+VqBnqUAoaWnr4M9p?=
 =?us-ascii?Q?KV6gC9A4ui56H7DqnUTewwI4Yps9OnBbGq0sYS9WFOKD7c3JWw7lHMWT8toI?=
 =?us-ascii?Q?x+HiHBp0yA7jp051tFclOtc6rlwp5KzI9aouqVubzTkZpyjCDdPR4++ayhgV?=
 =?us-ascii?Q?wpQj3WrJu/5t1yGM0BY8YA3UDgDx7MJ5tzMNMUbPrNL0i0WPyxS/fvB+yt8u?=
 =?us-ascii?Q?dQy3TonN3RZ8W4c5thfuc0lKy5kmvZxYe9krvbz/w84BBTDSE+rfnZyw5PJI?=
 =?us-ascii?Q?eRhJo7rl7yYT8M4gvZQuSCtFcAKf3KIgl+9NQtcpW0HtYqgzADIFeCc3Hc4Y?=
 =?us-ascii?Q?P4Tn+wkxVl8/rBDIKcYs7CfLEOQOcB0lRosw8Hc91XD1tFJdKxEgqS9Q7cPu?=
 =?us-ascii?Q?RjS/cbnjStlSitXZHZOdt4cz6iVpA2Ii2zOZuzla3IiVoqCt7bs3Ca3ww32z?=
 =?us-ascii?Q?FPqU+ZfjOT5H6ChfCBGBQeRq3+hG/6a/TReT1wfz3cAsKFlBCpwtKHgZrQrU?=
 =?us-ascii?Q?4njDVTlqkeIGtTCbww0RWVVBH9ivZRkpMJGoN1iSRsMKBp57WRvcgiSu8Z6R?=
 =?us-ascii?Q?7XLb+ePcgRSziOWqVRgEtkoa2dVjZPYMOrpTD3x8+tQ1gdKo1xPGUuLI5yJg?=
 =?us-ascii?Q?H6Jc0dPVQqZe1Lr7hXy/csIMP/JEE5aVFKk5jCIMDGEmHF/ebYtk63onvzkw?=
 =?us-ascii?Q?HGudqQaUDsTP9Jrgv1J0nxy9bZCKX+XeFX762AkwObFC8esQz5YLSou/HCGJ?=
 =?us-ascii?Q?oKnIl8P5/HZOwrCEdH7mzXWjjHUUPzGy9ONj+cPUajVBdgPUydhUhanTB4BV?=
 =?us-ascii?Q?24/DZ84Hy2H25zorV64qpqVq0ubgVk1tW6Zfx5jRlll0om8KMsvmqm+mRb2J?=
 =?us-ascii?Q?+tg4qbVU2dAxTA5NTE+1lRAY05DgqI/l/smL4mvVOxxz/ETBYqBoMoQQNHdB?=
 =?us-ascii?Q?TDs7u7Q3UD8s0n8IuNByz0wPe29S684vQ+xKhyLOKZwcG7LaLqjY0L4s+HAh?=
 =?us-ascii?Q?wvZBQwFjwuQWNpmN/HdR03UC4CjrOIwOmklq51prOWWm+gxgQ4pLUOg9sKtr?=
 =?us-ascii?Q?PBmR/CKme+MMoZC439X4/zSUYCNndfbAkXnz4rgFlIiHJ+axhidDLEDEWSwp?=
 =?us-ascii?Q?SPnJA9ktsX36cFArSnf9KmQ8kx0G2G8wb+L0iCYW2FY9ycdWjAs3iLC9AGIl?=
 =?us-ascii?Q?D+F/EU474mn3NeeiRZcczQ8u?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f15e8b57-675e-4591-8c36-08d935f658e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2021 03:24:01.8926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8yWTRSI6+ZbKaf+zDVRJ0mNw1mP8GxvoxgFCFlLixtloy3XNtvixV5lWhnu41XHZCJCZ5hC8g8egku6EHwtTgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5669
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> -----Original Message-----
> From: Marcel Holtmann <marcel@holtmann.org>
> Sent: Wednesday, June 16, 2021 1:14 AM
> To: K, Kiran <kiran.k@intel.com>
> Cc: linux-bluetooth@vger.kernel.org
> Subject: Re: [PATCH v9 10/10] Bluetooth: Add support for msbc coding
> format
>=20
> Hi Kiran,
>=20
> > In Enhanced_Setup_Synchronous_Command, add support for msbc coding
> > format
> >
> > Signed-off-by: Kiran K <kiran.k@intel.com>
> > Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> > Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> > ---
> > include/net/bluetooth/bluetooth.h |  1 +
> > net/bluetooth/hci_conn.c          | 27 ++++++++++++++++++++++++++-
> > 2 files changed, 27 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/net/bluetooth/bluetooth.h
> > b/include/net/bluetooth/bluetooth.h
> > index af2809121571..056699224da7 100644
> > --- a/include/net/bluetooth/bluetooth.h
> > +++ b/include/net/bluetooth/bluetooth.h
> > @@ -175,6 +175,7 @@ struct bt_codecs {
> >
> > #define CODING_FORMAT_CVSD		0x02
> > #define CODING_FORMAT_TRANSPARENT	0x03
> > +#define CODING_FORMAT_MSBC		0x05
> >
> > __printf(1, 2)
> > void bt_info(const char *fmt, ...);
> > diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c index
> > 9569b21adb88..73c134459361 100644
> > --- a/net/bluetooth/hci_conn.c
> > +++ b/net/bluetooth/hci_conn.c
> > @@ -328,6 +328,32 @@ bool hci_enhanced_setup_sync(struct hci_conn
> *conn, __u16 handle)
> > 	cp.rx_bandwidth   =3D cpu_to_le32(0x00001f40);
> >
> > 	switch (conn->codec.id) {
> > +	case CODING_FORMAT_MSBC:
> > +		if (!find_next_esco_param(conn, esco_param_msbc,
> > +					  ARRAY_SIZE(esco_param_msbc)))
> > +			return false;
> > +
> > +		param =3D &esco_param_msbc[conn->attempt - 1];
> > +		cp.tx_coding_format.id =3D 0x05;
> > +		cp.rx_coding_format.id =3D 0x05;
> > +		cp.tx_codec_frame_size =3D __cpu_to_le16(60);
> > +		cp.rx_codec_frame_size =3D __cpu_to_le16(60);
> > +		cp.in_bandwidth =3D __cpu_to_le32(32000);
> > +		cp.out_bandwidth =3D __cpu_to_le32(32000);
> > +		cp.in_coding_format.id =3D 0x04;
> > +		cp.out_coding_format.id =3D 0x04;
> > +		cp.in_coded_data_size =3D __cpu_to_le16(16);
> > +		cp.out_coded_data_size =3D __cpu_to_le16(16);
> > +		cp.in_pcm_data_format =3D 2;
> > +		cp.out_pcm_data_format =3D 2;
> > +		cp.in_pcm_sample_payload_msb_pos =3D 0;
> > +		cp.out_pcm_sample_payload_msb_pos =3D 0;
> > +		cp.in_data_path =3D conn->codec.data_path;
> > +		cp.out_data_path =3D conn->codec.data_path;
> > +		cp.in_trasnport_unit_size =3D 1;
> > +		cp.out_trasnport_unit_size =3D 1;
>=20
> so s/trasnport/transport/
>=20
> Please spellcheck your structs.

Ack.

>=20
> > +		break;
> > +
> > 	case CODING_FORMAT_TRANSPARENT:
> > 		if (!find_next_esco_param(conn, esco_param_msbc,
> > 					  ARRAY_SIZE(esco_param_msbc)))
> > @@ -383,7 +409,6 @@ bool hci_enhanced_setup_sync(struct hci_conn
> *conn, __u16 handle)
> > 		cp.in_trasnport_unit_size =3D 16;
> > 		cp.out_trasnport_unit_size =3D 16;
> > 		break;
> > -
>=20
> We can not have these random hunks in patches. You need to review your
> final set before sending it out.

Ack.

>=20
> Regards
>=20
> Marcel

Thanks,
Kiran