Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210617215758.BlueZ.v1.1.Iaf42bf6ccbc1a06a9fb7f8da55bf7f2ef37349f2@changeid>
 <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
In-Reply-To: <CAGPPCLCCvnsbgF9x4dFMDq+ZCr5KZ-+-NuSu++8NpFDCM8iiMA@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 24 Jun 2021 13:12:55 -0700
Message-ID: <CABBYNZ+aN7+M7Tk36MJewcNMwaTdjBMKuz1LX-Q9J-a864XTAQ@mail.gmail.com>
Subject: Re: [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev
 on Monitor match
To:     Manish Mandlik <mmandlik@google.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Miao-chen Chou <mcchou@google.com>,
        Alain Michaud <alainmichaud@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Manish,

On Thu, Jun 24, 2021 at 10:10 AM Manish Mandlik <mmandlik@google.com> wrote:
>
> Friendly reminder to review this patch.
>
> Regards,
> Manish.
>
>
> On Thu, Jun 17, 2021 at 9:58 PM Manish Mandlik <mmandlik@google.com> wrote:
>>
>> Do no skip a non-discoverable device if it matches any Advertisement
>> Monitor.
>>
>> Reviewed-by: mcchou@google.com
>> Reviewed-by: alainmichaud@google.com
>> Signed-off-by: Manish Mandlik <mmandlik@google.com>
>> ---
>>
>>  src/adapter.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 98fc78f1e..2175120f4 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,
>>
>>         dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
>>         if (!dev) {
>> -               if (!discoverable) {
>> +               if (!discoverable && !matched_monitors) {
>>                         eir_data_free(&eir_data);
>>                         return;
>>                 }
>> --
>> 2.32.0.288.g62a8d224e6-goog
>>

Applied, thanks.

-- 
Luiz Augusto von Dentz