Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 12:53:50 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     bjorn.andersson@linaro.org
Cc:     linux-bluetooth@vger.kernel.org
Subject: [bug report] soc: qcom: smd: Transition client drivers from smd to
 rpmsg
Message-ID: <YO1irj8sHBvQ3QqH@mwanda>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mwanda (2a02:6900:8208:1848::16ae) by LO2P265CA0211.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21 via Frontend Transport; Tue, 13 Jul 2021 09:53:58 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 4029639f-6a04-4d54-dadc-08d945e423ab
X-MS-TrafficTypeDiagnostic: MWHPR10MB1293:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MWHPR10MB1293B8954197ED2C874CC53C8E149@MWHPR10MB1293.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3631;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WDhLqKFOv7HOn1sRUuo/gUiTg9G5V/LgX457yvuQkzAhuNCyo82RyKFYtqeUfWO5smgmqSukUt8TcE1201MR00URbkmp+XaLC8QrRXH55PsAn2oYa1USBG5wHdLiKv4VdlJzbp09TXV2fbsyX3rt5xHbj2b7OwWqZmFUvJ2RY/LDXfEEpoDEcamwNEta5chGhuV+Plh0ManCELmNGyPLXE2kirxIWPk9Or/yp1wmixzJKYlnwu1t8/Ce0huN/31+cV3TIVTT0tnnu9zqprIxzRPno0lcsZ3dVt57ZHmV+JvoqHt4BjoMyroxfK4T69dor7HfoyKRKQLw8rCdO1hog9k+K3m4DGfTEbi3JivQVgo/rog+XoC2KAnxxxtTjmNcn2dCLj/1oJ/drNtXT64nQ1TKQJoC33wnLB4BZzwGn66jdwQnBe0kxgY9U+L3plmqKAKti1yRu7t/ppCnaH7++R4ed6BiK0jNzvSbLEuZCBm8KJt9sq9OV6B7BbQ4E/OEo79dX5hqfikrixJJA4a+079MbjoD/AF7I4EW5S2vSYsfsKKfWdXTl2IDgjFU3wXF20A0weY5qfz9WLcallvE49CP9UGTxy7UBpgYT4HYnA4rPPzNRwP3EJrUzQoiwDG63acbD1bSX6KKoIdEM/zKcZEcprEN2wB5E8FbRSipTZBJ9B4QfXsbXjiFj16MuQexRNdfFMEK/SIJY7FeKgn7rQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(39860400002)(376002)(136003)(346002)(52116002)(9686003)(6496006)(6666004)(6916009)(33716001)(38100700002)(8676002)(2906002)(5660300002)(478600001)(8936002)(44832011)(9576002)(86362001)(66476007)(316002)(66556008)(83380400001)(186003)(66946007)(4326008)(55016002)(17423001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LC2RZvcwr43UNzCJCYuICXq+ATJZVByv/uE0A8i8Tg/dl2qwXCL3KRcpSOom?=
 =?us-ascii?Q?a4BBCspB2AVM8wGAr4QPVxRlJ3g9bafI0gV0drBxeKgCqKO+FzCj8aZVNdjf?=
 =?us-ascii?Q?RF082kcVuMShP+h9l1nIIatP40smFbAxRyyb41DiXSo9qer19D8enXEK5LzG?=
 =?us-ascii?Q?5vTNeC7PfADAA3HjuJAPTUO2RPhGYnxb8WXTk0f063IaPxrfLwmQ0D24a8Cm?=
 =?us-ascii?Q?5SehgjVNuFQc2VbDTKPsodtrTPTr4mnlWIZqwr1VGeQSjOg1ybzL3E9sixAk?=
 =?us-ascii?Q?UOHhfXAdbKHFEgulBqPjjuQb9E93NOfJsRD5rwloZqGij+fZdofxCC+r37I1?=
 =?us-ascii?Q?/rcYz/dcIro+bIVNSQSCs8n6SUCCrv+Xtgdnq7v9OHzIm4iVSgdzAKWddyCi?=
 =?us-ascii?Q?GimRaVkUV5tekwtjRXmsAQEdSlnppAYk1+/stRRHD8Zu2vEHC7u+0Ioh2h4p?=
 =?us-ascii?Q?Dqee0gs6Plby/GC3PV+z2ltFCVD9bemrWRxpivQUxC89y2M865s9kpGzd2f/?=
 =?us-ascii?Q?oPEL1siWsVepPfoHVVf0E/KJMoQqIBOdEL0gMxwGgtv1YSueuZQLBWeCaGLh?=
 =?us-ascii?Q?4l+3vaTBH+mosfdOIHMwCsM726jOWsq7AxA1TPVtQRKunzOCIMNu7IdZ//W5?=
 =?us-ascii?Q?SbBJmn+NB8gyw2qltckJloKO3XWxb2s1KstslZtIbjD303nGmephFyYum0oP?=
 =?us-ascii?Q?eZ4DmeCDUtnB1R1TqYfnuVCPpTsAheYoQzfXU1vyU4ybmcZB89KWbxUfIwPP?=
 =?us-ascii?Q?CEGmImcwOsT+cJ9kcl+TeVWajfcpjHneZu6rt/GH6Aa3wxEbuEsQrlgT2hdc?=
 =?us-ascii?Q?mUDMXwhpbtkDW4YCnnhGQ8beW1tlr7woAmfqbNqyp3Sc0BucY4uY2MtWZf2O?=
 =?us-ascii?Q?GSzPBc3bDHcoC5+F/SH2CXHU/k45B3pMXm3g5lrSvhryL/HYG9NQ6m9FtBA2?=
 =?us-ascii?Q?5ZMr0kXHVCRJWNtF9XzGKF56GqrtyLA2Ww9MHdtMjTmVRlMNhsTY0v5ZSwsh?=
 =?us-ascii?Q?9E4t6St5Uiy1iJuwo3ZbMTgoRbiZyuMmWgA801iTZt+4cBTLUdk3LL/yVZhW?=
 =?us-ascii?Q?RmZ8/ENm/rzd3MIsMKb3T0I9uepI0mim/j9aftpHq/YmvWuz7/F5KDQooMhc?=
 =?us-ascii?Q?sUTvxdG4UV8HpR2+zARmchljfJYAreyDahgDBH/SI9buts1LY8BPSlQyvZIt?=
 =?us-ascii?Q?5pMzfnowQ8AoS8g3AvpTejL903Eho5ERWoNW0qPALRm/0ACWB54w0LmJTG7B?=
 =?us-ascii?Q?CJkwAw+7xYtRm1nQkYaWC8qiXOEF4tgN9P9zuS3XqyussnJrki6Xa+nBftsa?=
 =?us-ascii?Q?ivFJuEE6ICCJ0I2+QEMAFD62asgaWIdOkBTaoOtuCZCE8+csJi9op8SjGADX?=
 =?us-ascii?Q?pz/uHu4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4029639f-6a04-4d54-dadc-08d945e423ab
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 09:54:00.4060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ruVJYngTMAJOsfweM90vdgs36lUtYPGzn6vjxKsHie/ISiAOCRukvP1O+cgA1aS4+Vf+nIjpsXVgHBOJ7ylm4jMgGOZGsFIpMvjmskrIwjQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1293
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10043 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=895 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107130062
X-Proofpoint-GUID: yNwh6rz8Hi_Nw37cKT4gK2AOoa8Fw8AZ
X-Proofpoint-ORIG-GUID: yNwh6rz8Hi_Nw37cKT4gK2AOoa8Fw8AZ
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hello Bjorn Andersson,

The patch 5052de8deff5: "soc: qcom: smd: Transition client drivers
from smd to rpmsg" from Mar 27, 2017, leads to the following static
checker warning:

	drivers/bluetooth/btqcomsmd.c:140 btqcomsmd_probe()
	warn: 'btq->acl_channel' is not an error pointer

drivers/bluetooth/btqcomsmd.c
   125  static int btqcomsmd_probe(struct platform_device *pdev)
   126  {
   127          struct btqcomsmd *btq;
   128          struct hci_dev *hdev;
   129          void *wcnss;
   130          int ret;
   131  
   132          btq = devm_kzalloc(&pdev->dev, sizeof(*btq), GFP_KERNEL);
   133          if (!btq)
   134                  return -ENOMEM;
   135  
   136          wcnss = dev_get_drvdata(pdev->dev.parent);
   137  
   138          btq->acl_channel = qcom_wcnss_open_channel(wcnss, "APPS_RIVA_BT_ACL",
   139                                                     btqcomsmd_acl_callback, btq);
   140          if (IS_ERR(btq->acl_channel))

The qcom_wcnss_open_channel() original returned error pointers on error
but now it returns NULL on error and error pointers if it is disabled in
the .config file.

   141                  return PTR_ERR(btq->acl_channel);
   142  
   143          btq->cmd_channel = qcom_wcnss_open_channel(wcnss, "APPS_RIVA_BT_CMD",
   144                                                     btqcomsmd_cmd_callback, btq);
   145          if (IS_ERR(btq->cmd_channel)) {
   146                  ret = PTR_ERR(btq->cmd_channel);
   147                  goto destroy_acl_channel;
   148          }
   149  

regards,
dan carpenter