Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp730598pxv; Wed, 14 Jul 2021 14:13:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBEevHcg5rhPa2xhjrUawXnErhc/kolR9bQTd0Tf3IDrws41UJ7hQmOVoUMqujsPM9N1J1 X-Received: by 2002:a17:906:3555:: with SMTP id s21mr203565eja.394.1626297236366; Wed, 14 Jul 2021 14:13:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626297236; cv=none; d=google.com; s=arc-20160816; b=uLlndQfD7+HpsSsL+wtNKzI0OwKuPOVIMk5S/jbeoxA2oZFiPLqp3SsgJnlD52G1L5 kLV+Uy1aetNM0WQTnVx32HeYZI6dmYyhEv7UXLpzHDfiuYVO7Exnz/9mfSm+AQvPaPbJ rhHTySbsii+U18jMv3QRdxkTn3HD5i0+NuRidTK7kh3aPmedaCvg3wdlI5Ja52weexBA Lruf2u0cCaTgmcaRiOmPxSrDAzUoOW52XUjsQb2Tr/2EBiST5q3tMIfgNtJv5QZyyYzp ed1Jlle5ZJVW5J1SPX7lN+IlGLxh+CuwYaOSVx+VsCLpxxFj/7s6oLu6QXVdEKbUjH7F LEww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=aY/w09O3ZXDgZ8gGGRaznPswGoRIk6ZYGcIarqA1vlU=; b=OO6Wrw4cw4jh6RTdeRGwSPPkPKp5es3CKO7vrWJkp/tC/AMmDrJp+3tfoODs045fHk Z2/l6mSzS/pUvecvISXJGPOKhuTULD37luwXx2qAxGY5odk+uV0G9sW9W7Y93li6WdIl awpLFl+6Y7EmXU0ItHJQitUfE0czrsBv5ZAebC9pURIamjRFRbhJBtS5IhPU1d8FUl8U VXZc317W+z4QBIohD+vpJyZ2ROIsWh7V3f5HRMTLuypJIx9jnz4sZum8AWu7SABvctsY tXhKG9Bd+lnEW6IoMB050RLWSRboXvnbvr40BTDCE/5prgowGP9OIOwl3RdEt81Rr6KO 3r0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=J5YSGplY; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si1818653ejb.594.2021.07.14.14.12.49; Wed, 14 Jul 2021 14:13:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=J5YSGplY; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235139AbhGNVLY (ORCPT + 99 others); Wed, 14 Jul 2021 17:11:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235120AbhGNVLY (ORCPT ); Wed, 14 Jul 2021 17:11:24 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A93C06175F for ; Wed, 14 Jul 2021 14:08:31 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id r16so5452174ljk.9 for ; Wed, 14 Jul 2021 14:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aY/w09O3ZXDgZ8gGGRaznPswGoRIk6ZYGcIarqA1vlU=; b=J5YSGplYspJdPUjnl7FRIFFI0uHF9c92dzSDqPtDj4qaCPLW8XCUkxYKaoVhidrTNI RZ5NM/NWoDTVo8ykMfGLCyRBEuPQWGDHwWFZw98ArwGSlfkWHESGvdzV+YnbHOs4F+HG QfE9+nk+uy9tJVLjbRtfaCmhJZW34AKa17as4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aY/w09O3ZXDgZ8gGGRaznPswGoRIk6ZYGcIarqA1vlU=; b=Z/VQS0J2TXXkXrC03G6EQTDTNWSIb88fWoOJtyOB7W2K9KVLciTiyd1BUeAMzHl+4q JWriKNU1/xKaIreQ3ZfG7IWVGB50GYL9H6tHYVT3PSHkEsm2v+OGrulxc58/5mQtxuH9 4hq+lE5JKHaKgt+Ersu+WCorHgcJnQ4EJrnP5mswkLh7le2RU/dOfQcHCF+DaE7lYf8D XkQ6lZegXxFv1Wf9mgxRQHgBb2blIvWopMP0eoz6vOz/axM2p1pKtDXubTuAYRn4BH5i IdTiDpyAQpq1IX75ey0sLES7X+QQttgyWPTm5Og4gULE8enLdgi2ps7e+6MCsXkeQe4C kbQQ== X-Gm-Message-State: AOAM533zBsieURdRZDPTnxiHZYdfFoaMHH27DO2uxiET9sD2059jXSPS FwFqWDiFPq1viLjpG2VfcOI7Xgb8NOvDGV86mdumew== X-Received: by 2002:a05:651c:160e:: with SMTP id f14mr2921479ljq.194.1626296909205; Wed, 14 Jul 2021 14:08:29 -0700 (PDT) MIME-Version: 1.0 References: <20210626052152.2543526-1-mcchou@chromium.org> <20210625222111.BlueZ.v2.1.If79c3f0720cc893be1770c6853fe2fbe626f2caa@changeid> <086ED9D7-96E6-46AB-88B6-F2E71ACD1B15@holtmann.org> In-Reply-To: <086ED9D7-96E6-46AB-88B6-F2E71ACD1B15@holtmann.org> From: Miao-chen Chou Date: Wed, 14 Jul 2021 14:08:16 -0700 Message-ID: Subject: Re: [BlueZ PATCH v2 1/3] error: BR/EDR and LE connection failure reasons To: Marcel Holtmann Cc: Bluetooth Kernel Mailing List , Luiz Augusto von Dentz , Alain Michaud , Howard Chung Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Fri, Jun 25, 2021 at 10:39 PM Marcel Holtmann wrot= e: > > Hi Miao-chen, > > > The source of Connect() failures can be divided into the following > > three. > > - bluetoothd's device interface state transition and profile state > > transition > > - Kernel's L2CAP layer state transition > > - Potential HCI error codes returned by the remote device > > > > This also added error-code.txt to describe these error codes. > > > > Reviewed-by: Alain Michaud > > Reviewed-by: Howard Chung > > --- > > > > Changes in v2: > > - Add error-code.txt > > - Remove BtdError from return string > > > > doc/error-code.txt | 266 +++++++++++++++++++++++++++++++++++++++++++++ > > src/error.c | 111 +++++++++++++++++++ > > src/error.h | 52 +++++++++ > > 3 files changed, 429 insertions(+) > > create mode 100644 doc/error-code.txt > > please split documentation and code changes into separate patches. > > > > > > diff --git a/doc/error-code.txt b/doc/error-code.txt > > new file mode 100644 > > index 000000000..e91324855 > > --- /dev/null > > +++ b/doc/error-code.txt > > @@ -0,0 +1,266 @@ > > +D-Bus Method Return Error Codes > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + > > +The motivation of having detailed error codes is to provide context-ba= sed > > +failure reasons along with D-Bus method return so that D-Bus clients c= an > > +build metrics and optimize their application based on these failure re= asons. > > +For instance, a client can build retry mechanism for a connection fail= ure or > > +improve the bottleneck of use scenario based on actionable metrics. > > + > > +These error codes are context-based but not necessarily tied to interf= ace or > > +method calls. For instance, if a pairing request failed due to connect= ion > > +failure, connection error would be attached to the method return of Pa= ir(). > > + > > +BR/EDR connection already connected > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0001 > > + errno: EALREADY, EISCONN > > I would rather see connnection-already-connected instead of 0x0001 in the= D-Bus error message. Having a code attached instead of a string description makes it easier for a D-Bus client to interpret and map to corresponding handlers IMO. For instead, a client can simplily use the code in a switch case to perform retry or error reporting. > > > + > > +Either the profile is already connected or ACL connection is in place. > > + > > +BR/EDR connection page timeout > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > + code: 0x0002 > > + errno: EHOSTDOWN > > + > > +Failed due to page timeout. > > + > > +BR/EDR connection profile unavailable > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0003 > > + errno: ENOPROTOOPT > > + > > +Failed to find connectable services or the target service. > > + > > +BR/EDR connection SDP search > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > + code: 0x0004 > > + errno: none > > + > > +Failed to complete the SDP search. > > + > > +BR/EDR connection create socket > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0005 > > + errno: EIO > > + > > +Failed to create or connect to BT IO socket. This can also indicate ha= rdware > > +failure in the controller. > > + > > +BR/EDR connection invalid arguments > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0006 > > + errno: EHOSTUNREACH > > + > > +Failed due to invalid arguments. > > + > > +BR/EDR connection not powered > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > + code: 0x0007 > > + errno: EHOSTUNREACH > > + > > +Failed due to adapter not powered. > > + > > +BR/EDR connection not supported > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0008 > > + errno: EOPNOTSUPP, EPROTONOSUPPORT > > + > > +Failed due to unsupported state transition of L2CAP channel or other f= eatures > > +either by the local host or the remote. > > + > > +BR/EDR connection bad socket > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > + code: 0x0009 > > + errno: EBADFD > > + > > +Failed due to the socket is in bad state. > > + > > +BR/EDR connection memory allocation > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x000A > > + errno: EBADFD > > + > > +Failed to allocate memory in either host stack or controller. > > If this happens, then the code is wrong. Should be an ENOMEM. My mistake, this should be ENOMEM. Corrected in v3. > > > + > > +BR/EDR connection busy > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x000B > > + errno: EBUSY > > + > > +Failed due to other ongoing operations, such as pairing, busy L2CAP ch= annel or > > +the operation disallowed by the controller. > > + > > +BR/EDR connection concurrent connection limit > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x000C > > + errno: EMLINK > > + > > +Failed due to reaching the concurrent connection limit to a device. > > + > > +BR/EDR connection timeout > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D > > + code: 0x000D > > + errno: ETIMEDOUT > > + > > +Failed due to connection timeout > > + > > +BR/EDR connection refused > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D > > + code: 0x000E > > + errno: ECONNREFUSED > > + > > +Refused by the remote device due to limited resource, security reason = or > > +unacceptable address type. > > + > > +BR/EDR connection aborted by remote > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x000F > > + errno: ECONNRESET > > + > > +Terminated by the remote device due to limited resource or power off. > > + > > +BR/EDR connection aborted by local > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0010 > > + errno: ECONNABORTED > > + > > +Aborted by the local host. > > + > > +BR/EDR connection protocol error > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0011 > > + errno: EPROTO > > + > > +Failed due to LMP protocol error. > > + > > +BR/EDR connection canceled > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > > + code: 0x0012 > > + errno: none > > + > > +Failed due to cancellation caused by adapter drop, unexpected device d= rop, or > > +incoming disconnection request before connection request is completed. > > + > > +BR/EDR connection unknown error > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0013 > > + errno: ENOSYS > > + > > +Failed due to unknown reason. > > + > > +LE connection invalid arguments > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0101 > > + errno: EINVAL > > + > > +Failed due to invalid arguments. > > + > > +LE connection not powered > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D > > + code: 0x0102 > > + errno: EHOSTUNREACH > > + > > +Failed due to adapter not powered. > > + > > +LE connection not supported > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > + code: 0x0103 > > + errno: EOPNOTSUPP, EPROTONOSUPPORT > > + > > +Failed due to unsupported state transition of L2CAP channel or other f= eatures > > +(e.g. LE features) either by the local host or the remote. > > + > > +LE connection already connected > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0104 > > + errno: EALREADY, EISCONN > > + > > +Either the BT IO is already connected or LE link connection in place. > > + > > +LE connection bad socket > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > > + code: 0x0105 > > + errno: EBADFD > > + > > +Failed due to the socket is in bad state. > > + > > +LE connection memory allocation > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0106 > > + errno: ENOMEM > > + > > +Failed to allocate memory in either host stack or controller. > > + > > +LE connection busy > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0107 > > + errno: EBUSY > > + > > +Failed due to other ongoing operations, such as pairing, connecting, b= usy > > +L2CAP channel or the operation disallowed by the controller. > > + > > +LE connection refused > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x0108 > > + errno: ECONNREFUSED > > + > > +Failed due to that LE is not enabled or the attempt is refused by the = remote > > +device due to limited resource, security reason or unacceptable addres= s type. > > + > > +LE connection create socket > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > + code: 0x0109 > > + errno: EIO > > + > > +Failed to create or connect to BT IO socket. This can also indicate ha= rdware > > +failure in the controller. > > + > > +LE connection timeout > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x010A > > + errno: ETIMEDOUT > > + > > +Failed due to connection timeout > > + > > +LE connection concurrent connection limit > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x010B > > + errno: EMLINK > > + > > +Failed due to reaching the synchronous connection limit to a device. > > + > > +LE connection abort by remote > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > + code: 0x010C > > + errno: ECONNRESET > > + > > +Aborted by the remote device due to limited resource or power off. > > + > > +LE connection abort by local > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > + code: 0x010D > > + errno: ECONNABORTED > > + > > +Aborted by the local host. > > + > > +LE connection link layer protocol error > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + code: 0x010E > > + errno: EPROTO > > + > > +Failed due to link layer protocol error. > > + > > +LE connection GATT browsing > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > + code: 0x010F > > + errno: none > > + > > +Failed to complete the GATT browsing. > > + > > +LE connection unknown error > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > + code: 0x0110 > > + errno: ENOSYS > > + > > + Failed due to unknown reason. > > diff --git a/src/error.c b/src/error.c > > index 89517075e..73602c4bf 100644 > > --- a/src/error.c > > +++ b/src/error.c > > @@ -27,6 +27,7 @@ > > #include > > #endif > > > > +#include > > #include "gdbus/gdbus.h" > > > > #include "error.h" > > @@ -43,6 +44,12 @@ DBusMessage *btd_error_invalid_args_str(DBusMessage = *msg, const char *str) > > "%s", str); > > } > > > > +DBusMessage *btd_error_invalid_args_err(DBusMessage *msg, uint16_t err= ) > > +{ > > + return g_dbus_create_error(msg, ERROR_INTERFACE ".InvalidArgument= s", > > + "0x%04X", err); > > +} > > + > > DBusMessage *btd_error_busy(DBusMessage *msg) > > { > > return g_dbus_create_error(msg, ERROR_INTERFACE ".InProgress", > > @@ -79,12 +86,24 @@ DBusMessage *btd_error_in_progress(DBusMessage *msg= ) > > "In Progress"); > > } > > > > +DBusMessage *btd_error_in_progress_err(DBusMessage *msg, uint16_t err) > > +{ > > + return g_dbus_create_error(msg, ERROR_INTERFACE ".InProgress", "0= x%04X", > > + err); > > +} > > + > > DBusMessage *btd_error_not_available(DBusMessage *msg) > > { > > return g_dbus_create_error(msg, ERROR_INTERFACE ".NotAvailable", > > "Operation currently not availabl= e"); > > } > > > > +DBusMessage *btd_error_not_available_err(DBusMessage *msg, uint16_t er= r) > > +{ > > + return g_dbus_create_error(msg, ERROR_INTERFACE ".NotAvailable", > > + "0x%04X", err); > > +} > > + > > DBusMessage *btd_error_does_not_exist(DBusMessage *msg) > > { > > return g_dbus_create_error(msg, ERROR_INTERFACE ".DoesNotExist", > > @@ -121,8 +140,100 @@ DBusMessage *btd_error_not_ready(DBusMessage *msg= ) > > "Resource Not Ready"); > > } > > > > +DBusMessage *btd_error_not_ready_err(DBusMessage *msg, uint16_t err) > > +{ > > + return g_dbus_create_error(msg, ERROR_INTERFACE ".NotReady", "0x%= 04X", > > + err); > > +} > > + > > DBusMessage *btd_error_failed(DBusMessage *msg, const char *str) > > { > > return g_dbus_create_error(msg, ERROR_INTERFACE > > ".Failed", "%s", str); > > } > > + > > +DBusMessage *btd_error_failed_err(DBusMessage *msg, uint16_t err) > > +{ > > + return g_dbus_create_error(msg, ERROR_INTERFACE ".Failed", "0x%04= X", > > + err); > > +} > > + > > +uint16_t btd_error_bredr_conn_from_errno(int errno_code) > > +{ > > + switch (-errno_code) { > > + case EALREADY: > > + case EISCONN: // Fall through > > Don=E2=80=99t do this Fall through. It is actually not a fall through per= se. This is just a statement with two case labels. That is perfectly norma= l and no compiler should complain. And frankly no C-programmer should be co= nfused if this was intentional or not. Corrected in v3. > > > + return BTD_ERR_BREDR_CONN_ALREADY_CONNECTED; > > + case EHOSTDOWN: > > + return BTD_ERR_BREDR_CONN_PAGE_TIMEOUT; > > + case ENOPROTOOPT: > > + return BTD_ERR_BREDR_CONN_PROFILE_UNAVAILABLE; > > + case EIO: > > + return BTD_ERR_BREDR_CONN_CREATE_SOCKET; > > + case EINVAL: > > + return BTD_ERR_BREDR_CONN_INVALID_ARGUMENTS; > > + case EHOSTUNREACH: > > + return BTD_ERR_BREDR_CONN_ADAPTER_NOT_POWERED; > > + case EOPNOTSUPP: > > + case EPROTONOSUPPORT: // Fall through > > + return BTD_ERR_BREDR_CONN_NOT_SUPPORTED; > > + case EBADFD: > > + return BTD_ERR_BREDR_CONN_BAD_SOCKET; > > + case ENOMEM: > > + return BTD_ERR_BREDR_CONN_MEMORY_ALLOC; > > + case EBUSY: > > + return BTD_ERR_BREDR_CONN_BUSY; > > + case EMLINK: > > + return BTD_ERR_BREDR_CONN_CNCR_CONNECT_LIMIT; > > + case ETIMEDOUT: > > + return BTD_ERR_BREDR_CONN_TIMEOUT; > > + case ECONNREFUSED: > > + return BTD_ERR_BREDR_CONN_REFUSED; > > + case ECONNRESET: > > + return BTD_ERR_BREDR_CONN_ABORT_BY_REMOTE; > > + case ECONNABORTED: > > + return BTD_ERR_BREDR_CONN_ABORT_BY_LOCAL; > > + case EPROTO: > > + return BTD_ERR_BREDR_CONN_PROTO_ERROR; > > + default: > > + return BTD_ERR_BREDR_CONN_UNKNOWN; > > + } > > +} > > + > > +uint16_t btd_error_le_conn_from_errno(int errno_code) > > +{ > > + switch (-errno_code) { > > + case EINVAL: > > + return BTD_ERR_LE_CONN_INVALID_ARGUMENTS; > > + case EHOSTUNREACH: > > + return BTD_ERR_LE_CONN_ADAPTER_NOT_POWERED; > > + case EOPNOTSUPP: > > + case EPROTONOSUPPORT: // Fall through > > + return BTD_ERR_LE_CONN_NOT_SUPPORTED; > > + case EALREADY: > > + case EISCONN: // Fall through > > + return BTD_ERR_LE_CONN_ALREADY_CONNECTED; > > + case EBADFD: > > + return BTD_ERR_LE_CONN_BAD_SOCKET; > > + case ENOMEM: > > + return BTD_ERR_LE_CONN_MEMORY_ALLOC; > > + case EBUSY: > > + return BTD_ERR_LE_CONN_BUSY; > > + case ECONNREFUSED: > > + return BTD_ERR_LE_CONN_REFUSED; > > + case EIO: > > + return BTD_ERR_LE_CONN_CREATE_SOCKET; > > + case ETIMEDOUT: > > + return BTD_ERR_LE_CONN_TIMEOUT; > > + case EMLINK: > > + return BTD_ERR_LE_CONN_SYNC_CONNECT_LIMIT; > > + case ECONNRESET: > > + return BTD_ERR_LE_CONN_ABORT_BY_REMOTE; > > + case ECONNABORTED: > > + return BTD_ERR_LE_CONN_ABORT_BY_LOCAL; > > + case EPROTO: > > + return BTD_ERR_LE_CONN_PROTO_ERROR; > > + default: > > + return BTD_ERR_LE_CONN_UNKNOWN; > > + } > > +} > > diff --git a/src/error.h b/src/error.h > > index 7c8cad066..74d433aca 100644 > > --- a/src/error.h > > +++ b/src/error.h > > @@ -24,22 +24,74 @@ > > */ > > > > #include > > +#include > > > > #define ERROR_INTERFACE "org.bluez.Error" > > > > +/* BR/EDR connection failure reasons > > + * BT_ERR_* should be used as one of the parameters to btd_error_*_err= (). > > + */ > > +#define BTD_ERR_BREDR_CONN_ALREADY_CONNECTED 0x0001 > > +#define BTD_ERR_BREDR_CONN_PAGE_TIMEOUT 0x0002 > > +#define BTD_ERR_BREDR_CONN_PROFILE_UNAVAILABLE 0x0003 > > +#define BTD_ERR_BREDR_CONN_SDP_SEARCH 0x0004 > > +#define BTD_ERR_BREDR_CONN_CREATE_SOCKET 0x0005 > > +#define BTD_ERR_BREDR_CONN_INVALID_ARGUMENTS 0x0006 > > +#define BTD_ERR_BREDR_CONN_ADAPTER_NOT_POWERED 0x0007 > > +#define BTD_ERR_BREDR_CONN_NOT_SUPPORTED 0x0008 > > +#define BTD_ERR_BREDR_CONN_BAD_SOCKET 0x0009 > > +#define BTD_ERR_BREDR_CONN_MEMORY_ALLOC 0x000A > > +#define BTD_ERR_BREDR_CONN_BUSY 0x000B > > +#define BTD_ERR_BREDR_CONN_CNCR_CONNECT_LIMIT 0x000C > > +#define BTD_ERR_BREDR_CONN_TIMEOUT 0x000D > > +#define BTD_ERR_BREDR_CONN_REFUSED 0x000E > > +#define BTD_ERR_BREDR_CONN_ABORT_BY_REMOTE 0x000F > > +#define BTD_ERR_BREDR_CONN_ABORT_BY_LOCAL 0x0010 > > +#define BTD_ERR_BREDR_CONN_PROTO_ERROR 0x0011 > > +#define BTD_ERR_BREDR_CONN_CANCELED 0x0012 > > +#define BTD_ERR_BREDR_CONN_UNKNOWN 0x0013 > > + > > +/* LE connection failure reasons > > + * BT_ERR_* should be used as one of the parameters to btd_error_*_err= (). > > + */ > > +#define BTD_ERR_LE_CONN_INVALID_ARGUMENTS 0x0101 > > +#define BTD_ERR_LE_CONN_ADAPTER_NOT_POWERED 0x0102 > > +#define BTD_ERR_LE_CONN_NOT_SUPPORTED 0x0103 > > +#define BTD_ERR_LE_CONN_ALREADY_CONNECTED 0x0104 > > +#define BTD_ERR_LE_CONN_BAD_SOCKET 0x0105 > > +#define BTD_ERR_LE_CONN_MEMORY_ALLOC 0x0106 > > +#define BTD_ERR_LE_CONN_BUSY 0x0107 > > +#define BTD_ERR_LE_CONN_REFUSED 0x0108 > > +#define BTD_ERR_LE_CONN_CREATE_SOCKET 0x0109 > > +#define BTD_ERR_LE_CONN_TIMEOUT 0x010A > > +#define BTD_ERR_LE_CONN_SYNC_CONNECT_LIMIT 0x010B > > +#define BTD_ERR_LE_CONN_ABORT_BY_REMOTE 0x010C > > +#define BTD_ERR_LE_CONN_ABORT_BY_LOCAL 0x010D > > +#define BTD_ERR_LE_CONN_PROTO_ERROR 0x010E > > +#define BTD_ERR_LE_CONN_GATT_BROWSE 0x010F > > +#define BTD_ERR_LE_CONN_UNKNOWN 0x0110 > > + > > What is the intention to split BR/EDR and LE here. You do know up-front w= hat connection type you are. Trying to figure out from the error code what = connection you have been trying to establish is plain wrong. In fact the up-front connection type is not necessarily known. In the case of dual-mode devices, such as Bose QC35, a D-Bus client can issue Connect(), and it depends on the timing of connection request (adv usually arrive first compared to inquiry result), it can be either BR/EDR or LE link being established. Another aspect of this is the metrics collection, where knowing transport can be handy. For instance, we can associate the certain error to particular use cases at application layer, and that can help targeting the bottleneck to tackle. > > The description is that you want to know exactly where the connection fai= led. And I think that can be established independent from the transport. Indeed the intention is to know where it failed exactly. However, as mentioned above, transport information is also an important piece of information to know. > > In addition, I don=E2=80=99t like the 0x00?? vs 0x01?? reservation of any= number. That always goes bad at some point in the future. As replied above, having a code attached instead of a string description makes it easier for a D-Bus client to interpret and map to corresponding handlers, but I am happy to explore other options as well. > > Regards > > Marcel > Thanks, Miao