Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210722021952.18260-1-wangyouwan@uniontech.com>
In-Reply-To: <20210722021952.18260-1-wangyouwan@uniontech.com>
From:   Barry Byford <31baz66@gmail.com>
Date:   Thu, 22 Jul 2021 08:07:08 +0100
Message-ID: <CAAu3APbE1jQSC_zPzXDYQcuMJqoKQ3cbApQt5sJ6M_6ZDWQ4Jg@mail.gmail.com>
Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_bluez=3Afix_btmon_tools_=E2=80=9CAllow_slave=E2=80=9D_?=
        =?UTF-8?Q?to_=22Master_Or_Slave=22_=23431_=5Bhci0=5D_99=2E922927?=
To:     wangyouwan <wangyouwan@uniontech.com>
Cc:     Bluez mailing list <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, 22 Jul 2021 at 03:23, wangyouwan <wangyouwan@uniontech.com> wrote:
>
>     I want to explain it as=E3=80=80=E2=80=9CMaster Or Slave=E2=80=9D, be=
cause this is explained in the Core_v5.2
>

There is now Core V5.3 which has been updated to use inclusive
language as outlined by Archie in his post:

https://marc.info/?l=3Dlinux-bluetooth&m=3D162195325125419&w=3D2

I think the terms should be Central or Peripheral. Here is the same
extract from the spec in v5.3

8.6.5 Role switch
There are several occasions when a role switch is used:
=E2=80=A2 A role switch is necessary in order to make a paging device a Per=
ipheral
when joining an existing piconet, since by definition the paging device is
initially Central of a piconet involving the pager (Central) and the paged
(Peripheral) device.
=E2=80=A2 A role switch is necessary in order for a Peripheral in an existi=
ng piconet to
set up a new piconet with itself as Central and the original piconet Centra=
l as
Peripheral. If the original piconet had more than one Peripheral, then this
implies a double role for the original piconet Central; it becomes a Periph=
eral
in the new piconet while still maintaining the original piconet as Central.

>     8.6.5 Role switch
>     There are several occasions when a role switch is used:
>     =E2=80=A2 A role switch is necessary in order to make a paging device=
 a slave when
>     joining an existing piconet, since by definition the paging device is=
 initially
>     master of a piconet involving the pager (master) and the paged (slave=
)
>     device.
>     =E2=80=A2 A role switch is necessary in order for a slave in an exist=
ing piconet to set up
>     a new piconet with itself as master and the original piconet master a=
s slave.
>     If the original piconet had more than one slave, then this implies a =
double
>     role for the original piconet master; it becomes a slave
>
> Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
> ---
>  monitor/packet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8=
_t size)
>                 str =3D "Stay master";
>                 break;
>         case 0x01:
> -               str =3D "Allow slave";
> +               str =3D "Master Or Slave";
>                 break;
>         default:
>                 str =3D "Reserved";
> --
> 2.20.1
>
>
>