Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\))
Subject: =?utf-8?Q?Re=3A_=5BPATCH=5D_____bluez=3Afix_btmon_tools_=E2=80=9C?=
 =?utf-8?Q?Allow_slave=E2=80=9D_to_=22Master_Or_Slave=22__________________?=
 =?utf-8?Q?_______________________________________________________________?=
 =?utf-8?Q?______________________________________=23431_=5Bhci0=5D_99=2E92?=
 =?utf-8?Q?2927?=
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20210722021952.18260-1-wangyouwan@uniontech.com>
Date:   Thu, 22 Jul 2021 16:47:33 +0200
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <86E74CE4-C907-46A1-BD26-2D2F4EB15FE7@holtmann.org>
References: <20210722021952.18260-1-wangyouwan@uniontech.com>
To:     wangyouwan <wangyouwan@uniontech.com>
Precedence: bulk

Hi Wang,

>    I want to explain it as　“Master Or Slave”, because this is explained in the Core_v5.2
> 
>    8.6.5 Role switch
>    There are several occasions when a role switch is used:
>    • A role switch is necessary in order to make a paging device a slave when
>    joining an existing piconet, since by definition the paging device is initially
>    master of a piconet involving the pager (master) and the paged (slave)
>    device.
>    • A role switch is necessary in order for a slave in an existing piconet to set up
>    a new piconet with itself as master and the original piconet master as slave.
>    If the original piconet had more than one slave, then this implies a double
>    role for the original piconet master; it becomes a slave
> 
> Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
> 		str = "Stay master";
> 		break;
> 	case 0x01:
> -		str = "Allow slave";
> +		str = "Master Or Slave";
> 		break;

the text was verbatim from Bluetooth 4.x core spec. If that has changed in Core 5.3 spec, then we can use that one.

Regards

Marcel