Received: by 2002:a05:6a10:1287:0:0:0:0 with SMTP id d7csp3832439pxv; Mon, 26 Jul 2021 13:23:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw909YJtiss9YUh0/s+Q5fx3/Z3744BEB6LQ5IiLJMUdTgZ5NkBqxeo1fAntPf2bsC4OKx X-Received: by 2002:a5e:840f:: with SMTP id h15mr16063654ioj.93.1627331005568; Mon, 26 Jul 2021 13:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1627331005; cv=none; d=google.com; s=arc-20160816; b=dMhM5zktFH9JVKLwd9bBJKNZ0/GBe/Vi8TlyOIwDFBljAKrzD9vAlqzML/wBH8oqIz bOhcWlCiy6yT0mWk5og/VEtrPIisWb7rmo1B3Blfeu0PZCKfvJG5UUvcO2evhVySF5D9 NwPQoPHnwj/ex5ZtB9jY2NJ0mMx5Jw/vkLZtil7KuNlL0mQ29HbL2VlNTuMAHSY0tidr cKllt4bfK1f27usq07/58mRj/ByYRhchgbtGtDS1REoBE9JTPSxmIWcAexwynXBFM9Uf HbjfIB24X7/qU2puIVN1DvQC4kmdu+6UxXyCMwkW4PTr5pC00Gejr13jE7dIbQDtOXQ7 s3lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=YmhQ3VIwX/2HSA13XFQJ4Scf5Hrs2vzXcuk2eRLwD1Y=; b=Xb2fOBgqIaAIjcB/u/rN/i/BRhgstkorDwYhH3MzEo61WFEAb4PiE0Gy9FALdIoojw qDr/TrXUl5VI+iW+OK2wVUrOqf0I26+F38c28nLL6ImIQs0bo/UVZ8EiEb7ePR+HccQ4 xy/DXiUM09dyT8eIyLxjf0a/CZO7A7hgpVMhvoaYLhQHfcz61KwgC54lbxMT7Itleyg5 /0WB7jvw9Mdf/zSXScDDQ3k7swnDC+0BAV0Irsmef6PluCR2p0qVYW4OmiKxBVYjDQ71 3nEnXbgqmiCkR8Q18zNdqe5iR5iQK2nhncM5kZ6x3XbT1aPaH663jpmFfOGv3i5+40j6 Y1/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D09cpCdV; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si959217ilm.91.2021.07.26.13.23.13; Mon, 26 Jul 2021 13:23:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=D09cpCdV; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbhGZTmN (ORCPT + 99 others); Mon, 26 Jul 2021 15:42:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbhGZTmN (ORCPT ); Mon, 26 Jul 2021 15:42:13 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08055C061757 for ; Mon, 26 Jul 2021 13:22:41 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id c11so13020870plg.11 for ; Mon, 26 Jul 2021 13:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YmhQ3VIwX/2HSA13XFQJ4Scf5Hrs2vzXcuk2eRLwD1Y=; b=D09cpCdVzt0TahvmeOuIiNfp0IaMGJWP8XF/OYr/b4GoTi9P+qIYzP3h34dZsfow46 GYJX/eqNdsEzOZ3Ouj/u5EfvioPsnf3rAEpwg0xL4c2qC5seMYkqY8UBdY76K/uyJGDJ JtXqOV8aXy0jcGC4RKwUSYYlI0lKddcEw/MNPtI+isMT+qi3cljm264SwjL6b78kES0G d1h/ghWmb3PfxeFzS95Xk1Rh3jI4l2PDqUKa2/MXVJMYxJQViQilChaBu18YvKa2UsFd ojFd3XDSyUo/GUBsCEOTxb2WFBzki2xoddDFHSlkhihcMahcCVuLckp6Qel9/MVz8CMP CvNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YmhQ3VIwX/2HSA13XFQJ4Scf5Hrs2vzXcuk2eRLwD1Y=; b=Rn2MgHkc7w3AWhWx3M0p+GH1FRoTvmn2bleQ2dJ9KJvc6KwHCoS17g+A1I+uFnOxTx n52Ms1Yf2g2P90CFWYG0SSK9d5mreIHNeuY0gaS8PCXeigVFshb6Em0KEntxfI7PHeJ+ DzDizPdcafKkUdtjd0rrauZ/fsCszdgE4bh7N3v1X4LwpUgqE9+KqxNbQfHyGamS2Jil VXygl58lmnOtDi3vb8v79VAu69ekQCDvDsLEPhlO2beKtQOaE8hTBTwShjPezjRBB5gv liO1C4OsFn3JJXSzv0M9cYkSK+DyuZggKraasuQNwZdeZgEaRSrGy1Bk3UKcg42I+EeC tGeA== X-Gm-Message-State: AOAM530NAnbqSrsg6kbIqEkqe0cdMn5qVXBeBfYXsBlB85/8aRd2OWs2 /OWef4MKobSkL9Pi8EQqCOw/ZOyka5A= X-Received: by 2002:a62:1982:0:b029:356:3484:b7ec with SMTP id 124-20020a6219820000b02903563484b7ecmr19798174pfz.48.1627330960347; Mon, 26 Jul 2021 13:22:40 -0700 (PDT) Received: from han1-mobl3.intel.com ([2601:1c0:6a01:d830::7cb2]) by smtp.gmail.com with ESMTPSA id j3sm924526pfe.98.2021.07.26.13.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 13:22:39 -0700 (PDT) From: Tedd Ho-Jeong An To: linux-bluetooth@vger.kernel.org Cc: Tedd Ho-Jeong An Subject: [PATCH] Bluetooth: mgmt: Fix wrong opcode in the response for add_adv cmd Date: Mon, 26 Jul 2021 13:22:36 -0700 Message-Id: <20210726202236.136598-1-hj.tedd.an@gmail.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: Tedd Ho-Jeong An This patch fixes the MGMT add_advertising command repsones with the wrong opcode when it is trying to return the not supported error. Fixes: cbbdfa6f33198 ("Bluetooth: Enable controller RPA resolution using Experimental feature") Signed-off-by: Tedd Ho-Jeong An --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 3663f880df11..1e21e014efd2 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -7725,7 +7725,7 @@ static int add_advertising(struct sock *sk, struct hci_dev *hdev, * advertising. */ if (hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY)) - return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_ADVERTISING, + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING, MGMT_STATUS_NOT_SUPPORTED); if (cp->instance < 1 || cp->instance > hdev->le_num_of_adv_sets) -- 2.26.3