Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [PATCH] net: bluetooth: delete the redundant refcnt increment
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20210815085044.GA70199@nilus-desk>
Date:   Mon, 16 Aug 2021 18:02:31 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <A2180CC1-FA05-4439-A721-78A457F5CBC0@holtmann.org>
References: <20210815085044.GA70199@nilus-desk>
To:     Nil Yi <teroincn@163.com>
Precedence: bulk

Hi Nil,

> As the chan's refcnt is increased in l2cap_chan_create,
> no need to increase it again for l2cap_pi(sk)->chan.
> 
> Signed-off-by: Nil Yi <teroincn@163.com>
> ---
> net/bluetooth/l2cap_sock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> index c99d65ef1..4804c311d 100644
> --- a/net/bluetooth/l2cap_sock.c
> +++ b/net/bluetooth/l2cap_sock.c
> @@ -1831,8 +1831,7 @@ static struct sock *l2cap_sock_alloc(struct net *net, struct socket *sock,
> 		return NULL;
> 	}
> 
> -	l2cap_chan_hold(chan);
> -
> +	/* chan's refcnt is held in l2cap_chan_create() */
> 	l2cap_pi(sk)->chan = chan;

can you be a bit more specific what this is fixing?

Regards

Marcel