Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp2182420pxb; Mon, 23 Aug 2021 14:05:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5+AJuHX98aK3vYTAeR69HEwcfDiiwVunW/zHTzGxKN/wgXRuE5Ib5HQVuFmLygr5AarST X-Received: by 2002:a02:8189:: with SMTP id n9mr10399399jag.107.1629752706977; Mon, 23 Aug 2021 14:05:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629752706; cv=none; d=google.com; s=arc-20160816; b=RGcnL+qd/vZxzZS0ZRTNTV1RURvPeI1HvPq6uWh6Wq8cPq1BuoXQLiahqBnNZd13tS FBhVgLVB+LdE9jPNKPkwFjDrGnO5J6nGGAvqj1gPzKD6Hdm3Yh53Fb6V/AeK1+Mhstyz trKGoNlFVOlo4/oMEvwsUi1FLtBbsuI3Eka7rkEw9gu8Mta5vsi1BCe8wDBovgbfjHm2 BUIIFFCvgcc67HcH3lQxpoHagte0HWCvtVHMCIVnU+oifv1t3gZoCcQbJ8SeMdcjU9wT uDa9vtUu4/S9UPATfgP27En9KCTiKfiCdTIMmQq56Nbc7euuPDe0cvQe8N2HazSPGJu0 +EKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=voXXeLKlFlOLRsbMe7Mju4M35OwX86Fuz1jihyhQPTM=; b=eCVfk8XXtXuKQCX86jxIeCA7y+cL3QJSt8K04tIXvS058Jeo0sr720dRTcX/76Q9m3 75AGqxvgHn/kUrprco9bDZF/+qR/wffDAMGwfvvnroagxL7cfAO8t3zGGn+2h+YonbnI HSFJYv1EdhzC6rCUYperHqy/QtpisbN1273105l7zN1B0UM/yUI0IvA0e8M11Vmqf3Jm fBXSN+Z2dwxMBgS7EqVX9IasgxGlRYTP1/SXgGpHyyPMoKUgd8VFhSayJVZk4xxdKbzV SGEL9Np1sdbvDl4HGbwx4V+ERU6Gxk1LxUeC5EwMZaRRlP5g5PKPfYY3zPH9jsCUwwTx ApeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q1+kGAQj; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si10783607iod.86.2021.08.23.14.04.38; Mon, 23 Aug 2021 14:05:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q1+kGAQj; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbhHWVEy (ORCPT + 99 others); Mon, 23 Aug 2021 17:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232503AbhHWVEv (ORCPT ); Mon, 23 Aug 2021 17:04:51 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08276C061575 for ; Mon, 23 Aug 2021 14:04:08 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id j13so15567042ybj.9 for ; Mon, 23 Aug 2021 14:04:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=voXXeLKlFlOLRsbMe7Mju4M35OwX86Fuz1jihyhQPTM=; b=Q1+kGAQjivkE1KBQILIxb9/bjS6+eVeU0OyD05rp9KgSX6M4W0aMBnD6QnTY97njIp hcsuA4JA0LmqeBWTQUCOShqnkcWnq9DDUs+LK1evZxeM5S730s9E1Hqm4Dn5IIMB4m79 xLNuwQmdd9S0LpYpxUnLrMRBUOGbSyfSQrMMn4juDKEwZdEgyId/492vRsyuXNieQd26 ZyqaI1dVvMH/gx61vwnuTi4kfXpXY4lxCK9BnYMVixwtuNjPwbtEBsnaxKlpmySPV4wT iPAJ2qhYqMcOrMd9Pbyh65Q8FFET6xRFtIk9CR9I3jrW3u73RHn7USXHYz1Tpnfbyz56 fQEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=voXXeLKlFlOLRsbMe7Mju4M35OwX86Fuz1jihyhQPTM=; b=fVPKVTbqOHJSn4JvkWXmszxBoUAYDiBDMGrZMJcJbd+mFIIbM5uc077dJKHLcRiEVr q3j5/XYLvRZX0MkeYNHG9oZfeqQquG48vfsZwPLpOkfxHZcpAUNrCzxXWs1Q8181/xej bYBqiwjBkf5T181C5FzRcEicyyflzl1FQY8kRUlWHVSk130OX4q1U/XULeQk8qHjQGqX 4eZSgDZni1GmqxMLwlMaABUaCsY670XjMbZySvPdjWMWvD7+5KY7lTOSqa5rIgK5Ie+H sUec12nJfZPY3bDdNtsjpCSGnaPl7GBf7nDb+0k1KEG3pj7nmsDXB2sgisohOonv7w2w oqpA== X-Gm-Message-State: AOAM530JDDHYHTXnERo0N7ncGVTPIxHdzRHUuD8Ke128mjYtrahzJbyl KGJwwAR77ytI53r2mM9faCDW9qLnpLN+6cgtgdBcQ9cN X-Received: by 2002:a25:be02:: with SMTP id h2mr47571008ybk.91.1629752647157; Mon, 23 Aug 2021 14:04:07 -0700 (PDT) MIME-Version: 1.0 References: <20210722074208.8040-1-penguin-kernel@I-love.SAKURA.ne.jp> <246902bb-aafa-43bf-bf7c-ff26bfed5be1@i-love.sakura.ne.jp> In-Reply-To: <246902bb-aafa-43bf-bf7c-ff26bfed5be1@i-love.sakura.ne.jp> From: Luiz Augusto von Dentz Date: Mon, 23 Aug 2021 14:03:56 -0700 Message-ID: Subject: Re: [PATCH] Bluetooth: reorganize functions from hci_sock_sendmsg() To: Tetsuo Handa Cc: Marcel Holtmann , Johan Hedberg , "linux-bluetooth@vger.kernel.org" , LinMa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Tetsuo, On Sun, Aug 22, 2021 at 8:42 AM Tetsuo Handa wrote: > > On 2021/07/24 6:44, Luiz Augusto von Dentz wrote: > > Hi Tetsuo, > > > > On Thu, Jul 22, 2021 at 12:42 AM Tetsuo Handa > > wrote: > >> > >> Since userfaultfd mechanism allows sleeping with kernel lock held, > >> avoiding page fault with kernel lock held where possible will make > >> the module more robust. This patch just brings memcpy_from_msg() calls > >> to out of sock lock. > >> > >> Signed-off-by: Tetsuo Handa > > > > Reviewed-by: Luiz Augusto von Dentz > > > > Can this patch go to v5.15 ? Applied, thanks. I will be sending another pull-request by the end of this week which shall include it. -- Luiz Augusto von Dentz