Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp616897pxb; Wed, 25 Aug 2021 10:47:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDbc153OGIwUE5lcW85hqv+VSLdo11ZuU0M/25Vs27xc+NrcplUzY6jT+0/imBecwU9rQB X-Received: by 2002:a17:906:3598:: with SMTP id o24mr7756258ejb.191.1629913664455; Wed, 25 Aug 2021 10:47:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629913664; cv=none; d=google.com; s=arc-20160816; b=zJdv/cjaJt/mIzPqSsu3DJKFWrLpQiVOXrbF5ftppnd51qRgtDlZw15oopZdrbvOmJ beyyu1Ea9KmVi9eJgsOKooTj0TDiRA9oINcxE+3FkjmI1iptZieEMqWzdSnpaCbCT9l+ EpdVKOL8A/w+3e8seVtRWcEt+d12Kck/xTasolh/dhAiAgyiNS4CQMuu+Us0/CAZMPjq 8Znhzphwy+/FNXzDbx4eA2w+owRwoOLRXOQR9HIHXHSrU4/rmhD09nZhvNpa3TdQtqvh GWR+SvFRLnfaJV5TUhqqa0gUZBad/4lP1rBaDXrFQlHID8H6Bygg9G9s1cWtPDTgNZ70 M0nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=huGsUFwIPThK61p3wjNu91TtEXOY29J/+YXbtebsPz0=; b=jfc5/ZYdrkqHbGTQfertogjeznVvQpSgwvFcYrTjySHWNW1lw9TuMu1Dus9+tP1fYe qWrWWNdGJvBZ/gGExdFr/eV6zgQYfqADMLYtQkfo1E3w8QpUuSPE8R1FxjEFhH8azSSW DVs0MOoY6WW1E+XOXCsa1gtmP7uE/PUPJ89HKWwmtWsJS56FBWdYkTrIlHc5M0/Xrrym AkmKXlenFXAb48gVbHI8YfIchz4BwJoAbLtyyM130NoBY2z+HU/DjZEdsTxm7iOVgH0p lQ3gIQpubqt5DiEcUPGEATtVTDOhWhTC3WBi5f+NZwurT6VDtweknx+fgoQrH5wbU6IH u/Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b="yEgxNrj/"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lv19si414749ejb.445.2021.08.25.10.46.35; Wed, 25 Aug 2021 10:47:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b="yEgxNrj/"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234115AbhHYRpj (ORCPT + 99 others); Wed, 25 Aug 2021 13:45:39 -0400 Received: from vern.gendns.com ([98.142.107.122]:40544 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233405AbhHYRpj (ORCPT ); Wed, 25 Aug 2021 13:45:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=huGsUFwIPThK61p3wjNu91TtEXOY29J/+YXbtebsPz0=; b=yEgxNrj/6TLkFQQ7G+4INDvXD7 9Dwr7mCUucKEGdgR4u4DbIdbDYS7+dyx/QTEZfU90QLcY3sltSvJivCtAtQldnYBgpoPSK5zYlZRh FZLnfMEauWwJS/0eFGqB1nVno+WrBnj/Gejv4mTRj4xjBy/FIyLWI1E3zCWlOKenL58tpqCKv1zF2 vhOGlq3CuO+vnWaoEPJdjhkl+k6NGRrb/SdEAVujLKjpDVLAoeRlfMWacFcW9uBWU9ST2VXtHPvnd Q0rIaEaTYO1oHBNIIk2shOjVfIy/Sd4Yz2c3xVX/cnM/0O/7P3rYrilgLUdchklpd14TGgF8UCoUX UhoEnLuQ==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:56538 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mIwx9-0007WS-Mc; Wed, 25 Aug 2021 13:44:52 -0400 Subject: Re: [PATCH BlueZ] device: Remove GATT Attribute when device is removed To: Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org References: <20210824225202.826941-1-luiz.dentz@gmail.com> From: David Lechner Message-ID: <0028fab2-5707-8011-d3f6-d14c7337d449@lechnology.com> Date: Wed, 25 Aug 2021 12:44:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210824225202.826941-1-luiz.dentz@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On 8/24/21 5:52 PM, Luiz Augusto von Dentz wrote: > From: Luiz Augusto von Dentz > > This makes the GATT Attribute cache to be removed when device is removed > just like SDP ServiceRecords. > > Fixes: https://github.com/bluez/bluez/issues/191 > --- Tested-by: David Lechner But wouldn't it be better to just delete the file altogether? This would prevent any future sections from being forgotten to be removed as well. I sent an alternative patch that does this: "device: delete cache file when device is removed"