Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210824225202.826941-1-luiz.dentz@gmail.com> <0028fab2-5707-8011-d3f6-d14c7337d449@lechnology.com>
In-Reply-To: <0028fab2-5707-8011-d3f6-d14c7337d449@lechnology.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 25 Aug 2021 14:16:16 -0700
Message-ID: <CABBYNZLUo5wAATmUVYNoV-Nd1cUjC_zN0+tQQ7XSYywe6YSGcw@mail.gmail.com>
Subject: Re: [PATCH BlueZ] device: Remove GATT Attribute when device is removed
To:     David Lechner <david@lechnology.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi David,

On Wed, Aug 25, 2021 at 10:44 AM David Lechner <david@lechnology.com> wrote:
>
> On 8/24/21 5:52 PM, Luiz Augusto von Dentz wrote:
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > This makes the GATT Attribute cache to be removed when device is removed
> > just like SDP ServiceRecords.
> >
> > Fixes: https://github.com/bluez/bluez/issues/191
> > ---
> Tested-by: David Lechner <david@lechnology.com>
>
> But wouldn't it be better to just delete the file altogether?
> This would prevent any future sections from being forgotten to
> be removed as well.
>
> I sent an alternative patch that does this: "device: delete
> cache file when device is removed"

We do like to keep some details such as the name, etc.

-- 
Luiz Augusto von Dentz