Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp4418563pxb; Tue, 31 Aug 2021 04:53:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFo56BpNextqfDlAwkv496ZozODv1pu43iuR4xgNuOnE2+vjgvOB+M1sBmTr9JZ/7EjfxP X-Received: by 2002:a02:ac11:: with SMTP id a17mr2470087jao.100.1630410784730; Tue, 31 Aug 2021 04:53:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630410784; cv=none; d=google.com; s=arc-20160816; b=S2xCsG8JstPwGsdBc/3YaoZWT67QOBblHdVwlEYPt7nMRMqODs18G6l9y0J3zo1fng VqIlBe1zQ7+DKpKBjywvzBqhQjj0OYrLm2ne00FjOcnwFV/UaoXHYmUwzNhGjwGjkkyn 01hQlWfIpfhUWBNTwqVQVaSh3wYvDpLBtb+Ok84qlqP0ACvHwHbpBu4FIVUI6LDP08Jv p6y0uWzoO88QZQe/KtysNcsBGf24caHyVYtYuvSld/RyQ02uovEAFkCHIaEBqkFhtcul 3RwJY3C+W//1/hsi++Z6BqKttxVMvEqyfORogINga//ocgDO2HP7EJCTQyx9e7zTrpo2 DP3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=Ko7a1DhNx8A0ZtE2Htph15pJwxhDeuek7rMTJGLzm/I=; b=cmwOxuFmOGURpxjBR9damdp03IjyrGCSb1vwu3Zuyu/BNhnlQ0YVg2WPqIlaRxyWCf Rwo5OMpQRnjvnKNfBdiQDQER3W2JPi9RDGP1pEaj2Fo9aSJ6idXca7POJSscd9aCXoPW /oILpxh0xyPWeNid1IL817I0gJuwtvMtjdU1ORS0CAhoGb0hxCSMWTbaPWmZWMxcHp1j AKFmjkjDzv1FkflRZ8/2BBhpiiJf+b67kZrxsyBMZqmXWiVqfrlJRVldRB6Z89cOrm1V CCKXYVSa7kSc7Eir5UtXTl/7Vy/JbQvx0I5XQqUy76k605zhW1bgg+UBGXg4esVidRCC 5hEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si17297998ioh.20.2021.08.31.04.52.24; Tue, 31 Aug 2021 04:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbhHaLw3 (ORCPT + 99 others); Tue, 31 Aug 2021 07:52:29 -0400 Received: from mga02.intel.com ([134.134.136.20]:36804 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241607AbhHaLw2 (ORCPT ); Tue, 31 Aug 2021 07:52:28 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10092"; a="205674735" X-IronPort-AV: E=Sophos;i="5.84,366,1620716400"; d="scan'208";a="205674735" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2021 04:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,366,1620716400"; d="scan'208";a="498264545" Received: from intel-lenovo-legion-y540-15irh-pg0.iind.intel.com ([10.224.186.95]) by fmsmga008.fm.intel.com with ESMTP; 31 Aug 2021 04:51:32 -0700 From: Kiran K To: linux-bluetooth@vger.kernel.org Cc: Kiran K Subject: [PATCH v13 11/12] Bluetooth: Add offload feature under experimental flag Date: Tue, 31 Aug 2021 17:26:36 +0530 Message-Id: <20210831115637.6713-11-kiran.k@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210831115637.6713-1-kiran.k@intel.com> References: <20210831115637.6713-1-kiran.k@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Allow user level process to enable / disable codec offload feature through mgmt interface. By default offload codec feature is disabled. Signed-off-by: Kiran K Reviewed-by: Chethan T N Reviewed-by: Srivatsa Ravishankar --- Notes: changes in v13: - rebase on HEAD and resolve conflicts changes in v12: - Move definiton of mgmt flag to control hfp offload to patch 04/10 changes in v11: net/bluetooth/mgmt.c | 103 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 102 insertions(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index af1e65c4e00e..8818ede3d788 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -3797,6 +3797,12 @@ static const u8 quality_report_uuid[16] = { 0x2d, 0x49, 0x06, 0x75, 0xbc, 0x59, 0x08, 0x33, }; +/* a6695ace-ee7f-4fb9-881a-5fac66c629af */ +static const u8 offload_codecs_uuid[16] = { + 0xaf, 0x29, 0xc6, 0x66, 0xac, 0x5f, 0x1a, 0x88, + 0xb9, 0x4f, 0x7f, 0xee, 0xce, 0x5a, 0x69, 0xa6, +}; + /* 671b10b5-42c0-4696-9227-eb28d1b049d6 */ static const u8 simult_central_periph_uuid[16] = { 0xd6, 0x49, 0xb0, 0xd1, 0x28, 0xeb, 0x27, 0x92, @@ -3812,7 +3818,7 @@ static const u8 rpa_resolution_uuid[16] = { static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev, void *data, u16 data_len) { - char buf[82]; /* Enough space for 4 features: 2 + 20 * 4 */ + char buf[102]; /* Enough space for 5 features: 2 + 20 * 5 */ struct mgmt_rp_read_exp_features_info *rp = (void *)buf; u16 idx = 0; u32 flags; @@ -3874,6 +3880,26 @@ static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev, idx++; } + if (hdev) { + if (hdev->get_data_path_id) { + /* BIT(0): indicating if offload codecs are + * supported by controller. + */ + flags = BIT(0); + + /* BIT(1): indicating if codec offload feature + * is enabled. + */ + if (hci_dev_test_flag(hdev, HCI_OFFLOAD_CODECS_ENABLED)) + flags |= BIT(1); + } else { + flags = 0; + } + memcpy(rp->features[idx].uuid, offload_codecs_uuid, 16); + rp->features[idx].flags = cpu_to_le32(flags); + idx++; + } + rp->feature_count = cpu_to_le16(idx); /* After reading the experimental features information, enable @@ -4152,6 +4178,80 @@ static int set_quality_report_func(struct sock *sk, struct hci_dev *hdev, return err; } +static int exp_offload_codec_feature_changed(bool enabled, struct sock *skip) +{ + struct mgmt_ev_exp_feature_changed ev; + + BT_INFO("enabled %d", enabled); + + memset(&ev, 0, sizeof(ev)); + memcpy(ev.uuid, offload_codecs_uuid, 16); + ev.flags = cpu_to_le32(enabled ? BIT(0) : 0); + + return mgmt_limited_event(MGMT_EV_EXP_FEATURE_CHANGED, NULL, + &ev, sizeof(ev), + HCI_MGMT_EXP_FEATURE_EVENTS, skip); +} + +static int set_offload_codec_func(struct sock *sk, struct hci_dev *hdev, + struct mgmt_cp_set_exp_feature *cp, + u16 data_len) +{ + bool val, changed; + int err; + struct mgmt_rp_set_exp_feature rp; + + /* Command requires to use a valid controller index */ + if (!hdev) + return mgmt_cmd_status(sk, MGMT_INDEX_NONE, + MGMT_OP_SET_EXP_FEATURE, + MGMT_STATUS_INVALID_INDEX); + + /* Parameters are limited to a single octet */ + if (data_len != MGMT_SET_EXP_FEATURE_SIZE + 1) + return mgmt_cmd_status(sk, hdev->id, + MGMT_OP_SET_EXP_FEATURE, + MGMT_STATUS_INVALID_PARAMS); + + /* Only boolean on/off is supported */ + if (cp->param[0] != 0x00 && cp->param[0] != 0x01) + return mgmt_cmd_status(sk, hdev->id, + MGMT_OP_SET_EXP_FEATURE, + MGMT_STATUS_INVALID_PARAMS); + + val = !!cp->param[0]; + changed = (val != hci_dev_test_flag(hdev, HCI_OFFLOAD_CODECS_ENABLED)); + + if (!hdev->get_data_path_id) { + bt_dev_info(hdev, "offload codecs not supported"); + return mgmt_cmd_status(sk, hdev->id, + MGMT_OP_SET_EXP_FEATURE, + MGMT_STATUS_NOT_SUPPORTED); + } + + if (changed) { + if (val) + hci_dev_set_flag(hdev, HCI_OFFLOAD_CODECS_ENABLED); + else + hci_dev_clear_flag(hdev, HCI_OFFLOAD_CODECS_ENABLED); + } + + bt_dev_info(hdev, "offload codecs enable %d changed %d", + val, changed); + + memcpy(rp.uuid, offload_codecs_uuid, 16); + rp.flags = cpu_to_le32(val ? BIT(0) : 0); + hci_sock_set_flag(sk, HCI_MGMT_EXP_FEATURE_EVENTS); + err = mgmt_cmd_complete(sk, hdev->id, + MGMT_OP_SET_EXP_FEATURE, 0, + &rp, sizeof(rp)); + + if (changed) + exp_offload_codec_feature_changed(val, sk); + + return err; +} + static const struct mgmt_exp_feature { const u8 *uuid; int (*set_func)(struct sock *sk, struct hci_dev *hdev, @@ -4163,6 +4263,7 @@ static const struct mgmt_exp_feature { #endif EXP_FEAT(rpa_resolution_uuid, set_rpa_resolution_func), EXP_FEAT(quality_report_uuid, set_quality_report_func), + EXP_FEAT(offload_codecs_uuid, set_offload_codec_func), /* end with a null feature */ EXP_FEAT(NULL, NULL) -- 2.17.1