Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210913152801.v3.1.I17f57656757b83a1c0fb4b78525d8aca581725db@changeid>
 <D38B22EC-EFC8-44A0-84BE-F3710380C022@holtmann.org>
In-Reply-To: <D38B22EC-EFC8-44A0-84BE-F3710380C022@holtmann.org>
From:   Joseph Hwang <josephsih@google.com>
Date:   Sun, 26 Sep 2021 15:14:48 +0800
Message-ID: <CAHFy41-iVHf9wqBo20gHa7gR2EiXjLdb0faDXQjkekz3YbjMiQ@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth
 Quality Report
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
        kernel test robot <lkp@intel.com>,
        Miao-chen Chou <mcchou@chromium.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Marcel:

  I am very sorry that I missed your review comment! I have used
net/bluetooth/aosp.c to replace drivers/bluetooth/btandroid.c, and
enable the aosp capability by hci_set_aosp_capable() in the drivers.

  The new patch subject is

      [v4,1/4] Bluetooth: aosp: Support AOSP Bluetooth Quality Report

  (https://patchwork.kernel.org/project/bluetooth/patch/20210926150657.v4.1=
.Iaa4a0269e51d8e8d8784a6ac8e05899b49a1377d@changeid/)

  Please take a look.

Thanks and regards,
Joseph


On Mon, Sep 13, 2021 at 10:32 PM Marcel Holtmann <marcel@holtmann.org> wrot=
e:
>
> Hi Joseph,
>
> > Add the btandroid.c file to support Android BQR commands.
> >
> > This module may be referenced by btusb, btrtl, and hci_qca when a
> > Bluetooth controller supports the Android Bluetooth Quality Report.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> > Signed-off-by: Joseph Hwang <josephsih@chromium.org>
> > ---
> >
> > Changes in v3:
> > - Fix the auto build test ERROR
> >  "undefined symbol: btandroid_set_quality_report" that occurred
> >  with some kernel configs.
> > - Note that the mgmt-tester "Read Exp Feature - Success" failed.
> >  But on my test device, the same test passed. Please kindly let me
> >  know what may be going wrong. These patches do not actually
> >  modify read/set experimental features.
> > - As to CheckPatch failed. No need to modify the MAINTAINERS file.
> >  Thanks.
> >
> > Changes in v2:
> > - Fix the titles of patches 2/3 and 3/3 and reduce their lengths.
> >
> > drivers/bluetooth/Kconfig     |   5 ++
> > drivers/bluetooth/Makefile    |   1 +
> > drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++
> > drivers/bluetooth/btandroid.h |  10 ++++
> > 4 files changed, 122 insertions(+)
> > create mode 100644 drivers/bluetooth/btandroid.c
> > create mode 100644 drivers/bluetooth/btandroid.h
>
> I am confused now. Did you read my review comments? I do _not_ want it th=
is way; so please read my previous response and don=E2=80=99t send the exac=
t same patch again.
>
> Regards
>
> Marcel
>


--=20

Joseph Shyh-In Hwang
Email: josephsih@google.com