Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210929210049.35597-1-hj.tedd.an@gmail.com>
In-Reply-To: <20210929210049.35597-1-hj.tedd.an@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 29 Sep 2021 15:44:30 -0700
Message-ID: <CABBYNZLtBmnPAxNoBddy=z1ZFu0nCjsM0dE7b7wkAZmrjC_dUg@mail.gmail.com>
Subject: Re: [BlueZ PATCH] tools/mgmt-tester: Fix Read Experiemental Feature
 test case
To:     Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tedd,

On Wed, Sep 29, 2021 at 2:34 PM Tedd Ho-Jeong An <hj.tedd.an@gmail.com> wrote:
>
> From: Tedd Ho-Jeong An <tedd.an@intel.com>
>
> The quality report feature is supported only if the device support it.
> Current emulator/btdev doesn't support it yet.
>
> This patch updates the supported experimental feature list to align with
> the current btdev implementation.
> ---
>  tools/mgmt-tester.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
> index 9c5b26c9a..e62c4dcdc 100644
> --- a/tools/mgmt-tester.c
> +++ b/tools/mgmt-tester.c
> @@ -9334,7 +9334,7 @@ static const struct generic_data set_dev_flags_fail_3 = {
>  };
>
>  static const uint8_t read_exp_feat_param_success[] = {
> -       0x04, 0x00,                             /* Feature Count */
> +       0x03, 0x00,                             /* Feature Count */
>         0xd6, 0x49, 0xb0, 0xd1, 0x28, 0xeb,     /* UUID - Simultaneous */
>         0x27, 0x92, 0x96, 0x46, 0xc0, 0x42,     /* Central Peripheral */
>         0xb5, 0x10, 0x1b, 0x67,
> @@ -9343,14 +9343,10 @@ static const uint8_t read_exp_feat_param_success[] = {
>         0xde, 0xb3, 0xea, 0x11, 0x73, 0xc2,
>         0x48, 0xa1, 0xc0, 0x15,
>         0x02, 0x00, 0x00, 0x00,                 /* Flags */
> -       0x7f, 0x03, 0x14, 0x06, 0x6f, 0x9a,     /* UUID - Quality Report */
> -       0x70, 0x93, 0x2d, 0x49, 0x06, 0x75,
> -       0xbc, 0x59, 0x08, 0x33,
> -       0x00, 0x00, 0x00, 0x00,                 /* Flags */
>         0xaf, 0x29, 0xc6, 0x66, 0xac, 0x5f,     /* UUID - Codec Offload */
>         0x1a, 0x88, 0xb9, 0x4f, 0x7f, 0xee,
>         0xce, 0x5a, 0x69, 0xa6,
> -       0x01, 0x00, 0x00, 0x00                  /* Flags */
> +       0x00, 0x00, 0x00, 0x00                  /* Flags */
>  };
>
>  static const struct generic_data read_exp_feat_success = {
> --
> 2.25.1

Applied, thanks.

-- 
Luiz Augusto von Dentz