Received: by 2002:a05:6a10:d5a5:0:0:0:0 with SMTP id gn37csp4067000pxb; Mon, 4 Oct 2021 16:39:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxinUSixTzXccUmW40ypa6zD/wgzlS/OkWHzC9tG/qT4aTBBywSMzJeoMeoLuXOIOP1RwIs X-Received: by 2002:a50:d802:: with SMTP id o2mr21044740edj.331.1633390769257; Mon, 04 Oct 2021 16:39:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1633390769; cv=none; d=google.com; s=arc-20160816; b=Xu9DN4r5VNEePYJdGC0PpWCRCOLZlwk5Td3Ugc80ZmIOFrs4RkNMBqEswWYzLvwOtu 5YhGOrAanvb4hwxP1dc/oGOglTKgjlYs2fkVx8pVEfjZSiq07Gxc0V3YgE3zQnESaF9w vua7geL8YtzedT+AJXpsBxoKg3kUWX2eXfQNqTs9zVWlEKXSUaaGdoVIbc7987StupTR waUsu+Pq41lMPfY6p8pASUDP90U2Kw9+iFCpaXyVHL2baGvz0fsCtSkL/CxWlmlgDJHO /6t2e9CDKkVeWvd9XBqeaYuDWKVH8zeTY6JAruS77BQ0cMCrgdAr3riq0bYrh/JKkEHg Zccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5lPwZ+iwsuPnoAxmrkeLnm/5OtvoYrkkwPtp9yTV4PE=; b=JMGlxlhfp6R+K0gJaC2XLjx1SYqRDXDE+cLSgynMWw+nkWtNKB/a+QHqe64Jlr5h76 /6r+3Ociy6hUwpQktr877b+DUTPn4w5bWTkFgUVE9jAlXjr/90SsuZ90cq6blBAs3Id3 2aIxoHVPetcU9do81KsnkoQD6EoTsAkIsMG1zQHd9ikqx3AGoEdQZbUyUCvUPDa+r1bQ C5mKg1oxhQhSeGGo3tCUMFk+dQlWjHU1BZPFR8FYhgH8MtLZvA8QpQw6J63k5mi9jFaq /2vgySkzUKhIOi/+40a2F8Elqd6Liq1jdM+Y/YcJLeSWCuAH2JQ0u5YQvuCo+0ThHTkd Xj/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hgF1ZS5h; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m3si18167165ejn.256.2021.10.04.16.38.55; Mon, 04 Oct 2021 16:39:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hgF1ZS5h; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233543AbhJDTqj (ORCPT + 99 others); Mon, 4 Oct 2021 15:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233382AbhJDTqi (ORCPT ); Mon, 4 Oct 2021 15:46:38 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5958EC06174E for ; Mon, 4 Oct 2021 12:44:49 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id 24so23153004oix.0 for ; Mon, 04 Oct 2021 12:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5lPwZ+iwsuPnoAxmrkeLnm/5OtvoYrkkwPtp9yTV4PE=; b=hgF1ZS5hnGhwUx2jX7oe2GHCphP61nmlCP4jO1u7qYsCENPZl9Qq27TGGNB+bkKiac jdQn2fj8+mXEEmTTF6pL+5RGN3fhZ9Mc5u6QUYrdVHMefiUrfQvD3gfU4n6+G0lQThA5 g+MynwqkJ3Y7M+fZUlMYwhxFJU8oRv1d5a5USP7B1XsA0TjlUPEtd2l2VyabrC8owMJT 1ae6r6JkuwqaaK5hC6lHMiG4iAM7Umrh2CRIEjUwLH0VH0mt7+X76isPUD6aUXldQV1j KvISpuM2NO8ZbrBKQyIohf6z9eiKHATGZe2xJACeqb2PiuDlaYzUnn5XiXQM9Gi3hMRT 5WDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5lPwZ+iwsuPnoAxmrkeLnm/5OtvoYrkkwPtp9yTV4PE=; b=iInWo4HF6PYYvwr2UMvkZ+0Brt6OXwCwANhWoUKg6hsV3zD4r4bz/wgbIW3Obe9c3w VaqzUehQBLPbuf/WyE7vDNE8bTd0UbwCZTQTvxVuAtgWxLcf5ZdI7DI4BCFdJhuUtsT9 ayNfXjHDPE5e9QxdXQ26CRv6Jsz2hBReaG60Fp5rVNUeU7uKF1ard4qyfVNuCH8Svz+h 8uGgJOiztlUkazrBBVGXzcWkpLl7p7Cx7pHRPgNOaEdw8ORvP/jaggZcmyPbLoRy+cCT KHZoQbJs9HiGlowvXmqjkkRY9GiG61ex1+rmNzRTb5uu2e58sJmJcRVrqY4+Sf+hHMHp CaVw== X-Gm-Message-State: AOAM531k/HOky7eVN17FSa6nh+1SpREoIkqcFSEHnl9WUeKTPuf8Hc1E vY6OnQcp6JXHlLKz/skBGWKnwg== X-Received: by 2002:aca:f0c3:: with SMTP id o186mr13729435oih.37.1633376688632; Mon, 04 Oct 2021 12:44:48 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id j10sm2972251oog.39.2021.10.04.12.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 12:44:48 -0700 (PDT) Date: Mon, 4 Oct 2021 12:46:31 -0700 From: Bjorn Andersson To: Mianhan Liu Cc: Andy Gross , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next -v2] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c Message-ID: References: <20210928200811.22059-1-liumh1@shanghaitech.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928200811.22059-1-liumh1@shanghaitech.edu.cn> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Tue 28 Sep 13:08 PDT 2021, Mianhan Liu wrote: If you run a "git log --oneline -- drivers/bluetooth/btqcomsmd.c" you will see that the appropriate prefix would be "Bluetooth: btqcomsmd: " In other words, a better $subject would be: [PATCH v2] Bluetooth: btqcomsmd: remove superfluous includes > btqcomsmd.c hasn't use any macro or function declared in linux/of.h > and linux/slab.h. > Thus, these files can be removed from btqcomsmd.c safely without > affecting the compilation of the ./drivers/bluetooth module > > Signed-off-by: Mianhan Liu > > --- Here is an excellent place to state "Changes since v1" and mention that you no longer remove btqca.h and you added your S-o-b. > drivers/bluetooth/btqcomsmd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c > index 2acb719e5..e556d96a4 100644 > --- a/drivers/bluetooth/btqcomsmd.c > +++ b/drivers/bluetooth/btqcomsmd.c > @@ -5,9 +5,7 @@ > */ > > #include > -#include > #include > -#include > This looks reasonable. Regards, Bjorn > #include > #include > -- > 2.25.1 > >