Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211002182109.165456-1-hj.tedd.an@gmail.com> <86E45D71-62B4-4ED0-A31A-FB021D86F9B3@holtmann.org>
In-Reply-To: <86E45D71-62B4-4ED0-A31A-FB021D86F9B3@holtmann.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 4 Oct 2021 15:27:08 -0700
Message-ID: <CABBYNZJp5phSoGwOZ7yUQ0o9E9Pf5wi-Kh3u1WjAf_1iDk2Bhw@mail.gmail.com>
Subject: Re: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Tedd Ho-Jeong An <hj.tedd.an@gmail.com>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        Tedd Ho-Jeong An <tedd.an@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Marcel, Tedd,

On Sat, Oct 2, 2021 at 2:04 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Tedd,
>
> > This patch sets the wakeup value in the vhci driver data after reading
> > the value.
> >
> > Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> > ---
> > drivers/bluetooth/hci_vhci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> > index b45db0db347c..5fd91106e853 100644
> > --- a/drivers/bluetooth/hci_vhci.c
> > +++ b/drivers/bluetooth/hci_vhci.c
> > @@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
> >       if (data->wakeup == enable)
> >               return -EALREADY;
> >
> > +     data->wakeup = enable;
> > +
> >       return count;
>
> patch looks good, but the commit message is confusing.

Ive ended up fixing the original patch since I had to force push due
to the pull request problem with committer/sign-off problem.

> Regards
>
> Marcel
>


-- 
Luiz Augusto von Dentz