Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210930223726.2886139-1-mcchou@chromium.org>
In-Reply-To: <20210930223726.2886139-1-mcchou@chromium.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 4 Oct 2021 15:48:00 -0700
Message-ID: <CABBYNZL2cX9Rx25DqFd3ggmRM8ZQXF2nPK5dUSWNB5c1qmjN9Q@mail.gmail.com>
Subject: Re: [BlueZ PATCH v7 0/4] Detailed error string
To:     Miao-chen Chou <mcchou@chromium.org>
Cc:     Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
        Howard Chung <howardchung@google.com>,
        Alain Michaud <alainm@chromium.org>,
        Marcel Holtmann <marcel@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Miao,

On Thu, Sep 30, 2021 at 3:46 PM Miao-chen Chou <mcchou@chromium.org> wrote:
>
> Chromium OS has been working closely with Linux Bluetooth community to
> improve BlueZ stack, and there are increasing needs from applications
> building their features around Bluetooth. One of the major feedback
> from these application is the lack of the detailed failure reasons as
> return for D-Bus method call, and these failure reasons can be used in
> metrics, optimizing retry mechanism, hinting the reproduce scenario to
> improve BlueZ stack. The current org.bluez.Error.* are serving the
> generic errors well. However,g given org.bluez.Error.* errors are used
> across different interface context which does not serve the detailed
> failure reasons well. (See https://github.com/bluez/bluez/issues/131)
>
> Changes in v7:
> - Fix nits
>
> Changes in v6:
> - Rephrase error string
>
> Changes in v5:
> - Replace error code with error string
>
> Changes in v4:
> - Address make errors.
>
> Changes in v3:
> - Correct error-codes.txt.
>
> Changes in v2:
> - Add documentation for error codes
>
> Miao-chen Chou (4):
>   Add errors.txt to describe errors of D-Bus method returns
>   BR/EDR and LE connection failure reasons
>   Include detailed error string in Connect() return
>   Print error code for connect methods
>
>  client/main.c  |   3 +-
>  doc/errors.txt | 233 +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/device.c   |  46 ++++++----
>  src/error.c    | 100 +++++++++++++++++++++
>  src/error.h    |  57 ++++++++++++
>  5 files changed, 422 insertions(+), 17 deletions(-)
>  create mode 100644 doc/errors.txt
>
> --
> 2.33.0.800.g4c38ced690-goog

Applied, thanks.

-- 
Luiz Augusto von Dentz