Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210921181243.BlueZ.v1.1.I261f9c1ee78b90f81a6c323c23065615be917c33@changeid>
 <CAGPPCLDZF_BFbGV4Cd1s0SOKYJwwpM-cM3zvDdjHOTtBcvDT0Q@mail.gmail.com>
In-Reply-To: <CAGPPCLDZF_BFbGV4Cd1s0SOKYJwwpM-cM3zvDdjHOTtBcvDT0Q@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 4 Oct 2021 15:47:37 -0700
Message-ID: <CABBYNZJYjecA503BWTDc-+SgDTAnda3p079H2d4W4j3xS-VpZw@mail.gmail.com>
Subject: Re: [BlueZ PATCH v1] adv_monitor: Mark the device as lost on device_lost_timeout
To:     Manish Mandlik <mmandlik@google.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Yun-Hao Chung <howardchung@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Manish,

On Mon, Sep 27, 2021 at 11:30 AM Manish Mandlik <mmandlik@google.com> wrote:
>
> Friendly reminder to review this patch. :)
>
> Regards,
> Manish.
>
>
> On Tue, Sep 21, 2021 at 6:13 PM Manish Mandlik <mmandlik@google.com> wrote:
>>
>> Mark the device as lost on device_lost_timeout so that it can be found
>> again next time.
>>
>> Verified this by adding a monitor using bluetoothctl and confirming that
>> the DeviceLost event is getting triggered when bt peer stops advertising
>> and DeviceFound event gets triggered again when the bt peer restarts the
>> advertising.
>>
>> Reviewed-by: Yun-Hao Chung <howardchung@google.com>
>> ---
>>
>>  src/adv_monitor.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/adv_monitor.c b/src/adv_monitor.c
>> index 715ac5904..a55e1ea2d 100644
>> --- a/src/adv_monitor.c
>> +++ b/src/adv_monitor.c
>> @@ -1892,7 +1892,9 @@ static bool handle_device_lost_timeout(gpointer user_data)
>>         g_dbus_proxy_method_call(monitor->proxy, "DeviceLost",
>>                                  report_device_state_setup,
>>                                  NULL, dev->device, NULL);
>> +
>>         dev->lost_timer = 0;
>> +       dev->found = false;
>>
>>         return FALSE;
>>  }
>> --
>> 2.33.0.464.g1972c5931b-goog
>>

Applied, thanks.

-- 
Luiz Augusto von Dentz