Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211003101834.45448-1-thomas@t-8ch.de> <61598804.1c69fb81.d279a.fe3f@mx.google.com>
In-Reply-To: <61598804.1c69fb81.d279a.fe3f@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 4 Oct 2021 21:15:37 -0700
Message-ID: <CABBYNZ+-7QASvCoA9XJQ_Jmi8=e2-dZQSnL4Xft4Ci_WGb=nPA@mail.gmail.com>
Subject: Re: [BlueZ] Use accurate icons for headphones and headsets
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     thomas@t-8ch.de
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Thomas,

On Sun, Oct 3, 2021 at 3:40 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=556811
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    FAIL      1.36 seconds
> GitLint                       PASS      0.92 seconds
> Prep - Setup ELL              PASS      47.51 seconds
> Build - Prep                  PASS      0.46 seconds
> Build - Configure             PASS      8.78 seconds
> Build - Make                  PASS      194.30 seconds
> Make Check                    PASS      8.98 seconds
> Make Distcheck                PASS      228.49 seconds
> Build w/ext ELL - Configure   PASS      8.21 seconds
> Build w/ext ELL - Make        PASS      176.63 seconds
>
> Details
> ##############################
> Test: CheckPatch - FAIL
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
> Output:
> [BlueZ] Use accurate icons for headphones and headsets
> WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #50:
> are in practice implemented by at least Adwaita, Gnome, Oxygen, Arc and Breeze
>
> /github/workspace/src/12532673.patch total: 0 errors, 1 warnings, 11 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> /github/workspace/src/12532673.patch has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
>
>
> ---
> Regards,
> Linux Bluetooth

Shouldn't they be proposed to be added to the standard before we do
these changes? I mean it is better to have an icon then not have
anything or is there a fallback mechanism e.g. audio prefix fallback
to audio-card?

-- 
Luiz Augusto von Dentz