Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3406575pxb; Wed, 13 Oct 2021 05:30:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX9BHkuBcpzC+iQxYUFaGV5lPYe8aVrsNr2FZOMQijQI+vqFkdgcwBomRWJEDaVWVnzi/9 X-Received: by 2002:a17:902:e743:b0:13f:18ba:c8a8 with SMTP id p3-20020a170902e74300b0013f18bac8a8mr28228348plf.72.1634128225843; Wed, 13 Oct 2021 05:30:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634128225; cv=none; d=google.com; s=arc-20160816; b=B8XXPUhX7Nyv6+3ZwGHJqrU1Z3cqFo/Kqu8Ci1FITwXYQq7/Ksd075zdG+yfhr0eHZ 924yX+gYmaZu46cgRZEadffhRKTsl6TSaZgWi0ziuz5m8B65D96McTnNlO1AAxv4e2lp 7m8J7i/D6SJcklEqgdnoU3KtJ6Nfa76Ew1KupvT70tYiQ/tIzbNTOmQ7hk/pRfHTMabq 2gbTY/9k3blNw6taqGl2/yPXBN9PT5RE9bPJRbZoj+PUKloTe6VPr5Z41A6fN63AcFPy kVPJZxcffpJNVdJvYuTJTeSzBB8hR2lUX892fkA5PvUk7ECZIA5ARgFT+UPLbT+xG9JW bAZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=zMFJtuO5WMYkNDyLOjn+mBC8oI9wEi9kz97LLwP5wM0=; b=b0ITXE/KrL6ff6wWBujYsf3fsQnUizFZGUEK0JRKDfmHdgGAiywkozaXvMM0fd7hME fDO3CSNJkVryNExSuF/DuSTHlBW5L61Pp08tIfjSwAoE6zojk2bRqkDIy4AQyl4v879z ILkUrX0uAL50yc+qSAfBMrPP1Ztvho9S4HsJW+LtYDZusE7q6mO7OZI7df1BkYKiCcMV AJNIQvoPa7Q42H8DnE6JEfT0gRlY15A0B5n3+20dcXIjYyWwnHMPjuYV3Ak/k779b1id TMeX8guQdS+WPnWPPqWt1h2thu3TywEkX/CEd44at9igIXyVOe1ZWCCUIOmoA+x8ZqSG XCdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si21103853plr.41.2021.10.13.05.29.59; Wed, 13 Oct 2021 05:30:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232491AbhJMMbF (ORCPT + 99 others); Wed, 13 Oct 2021 08:31:05 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:51356 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232977AbhJMMbE (ORCPT ); Wed, 13 Oct 2021 08:31:04 -0400 Received: from smtpclient.apple (p4ff9f2d2.dip0.t-ipconnect.de [79.249.242.210]) by mail.holtmann.org (Postfix) with ESMTPSA id 8BFAACECF6; Wed, 13 Oct 2021 14:29:00 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH] Bluetooth: Fix debugfs entry leak in hci_register_dev() From: Marcel Holtmann In-Reply-To: <20211013085546.101615-1-weiyongjun1@huawei.com> Date: Wed, 13 Oct 2021 14:29:00 +0200 Cc: linux-bluetooth , Johan Hedberg , Luiz Augusto von Dentz Content-Transfer-Encoding: 7bit Message-Id: References: <20211013085546.101615-1-weiyongjun1@huawei.com> To: Wei Yongjun X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Wei, > Fault injection test report debugfs entry leak as follows: > > debugfs: Directory 'hci0' with parent 'bluetooth' already present! > > When register_pm_notifier() failed in hci_register_dev(), the debugfs > create by debugfs_create_dir() do not removed in the error handing path. > > Add the remove debugfs code to fix it. > > Signed-off-by: Wei Yongjun patch has been applied to bluetooth-next tree. Regards Marcel