Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp3408070pxb; Wed, 13 Oct 2021 05:32:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/O5dq794bUey1LpMsN8hnLZ1wOfy+Nvee26RI9HFpghIjCajnknVC/eVu5Kswq99X4BEp X-Received: by 2002:a17:902:c402:b0:13f:1c07:5a25 with SMTP id k2-20020a170902c40200b0013f1c075a25mr26141332plk.38.1634128338091; Wed, 13 Oct 2021 05:32:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1634128338; cv=none; d=google.com; s=arc-20160816; b=jvx+DlbWCAnVKmkDfcN+3fpgqj632zmFWXF0aUY6T9Q5v8RtmxETyP6jBAYrPcu/oZ rtAajZgQQgridQ3xg6wAa9fyD9BPM4Eba/O9yt1pIUDAiVKwhRPZXnaE3lfjbSchONf9 6UZPWDCDR6ZlpEBx8A8oTKfNH0qAse2uk4pC9WTGMO+qsZBpQFAt4/EosRdxvOSWvlUR AoMfFKrLVaCByBJtMx1nmFBA+3ryFu0gzunMmyF0QT3L9ETpkDgIquIu0B4rVv11zuB2 IFHF7UosRVyAaeU3IaL422/FR4vK8nnr/xatuCcB8TwyQOcRf980HhT7uEW6c2ppX/Wc c+OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=8MvOkN5zC/uQr6nfctFNB3/O+SMDZmCXGOE3s5QTU/I=; b=ONPOZqgLlfDvW6MdcBze6jokV27SfQc7Va9OAwMpsigpWlp0Bqqhx8Z5nKYje8Wzwt rY69qLzYCX625oTKFg4E7MFBHkqPYz1QPkB2qp4taIODfKamKQimT5xA8A0V/1eGer9b 9ixZJwNTYboEYZGjqpvvjtkxJXug69F6y+rGB4pvt0VOap0e3rmUPjdRC2+mvovx2KJI Vk3LAyDeaHowVW9RD7j4iZUPMmbCRo5PP8MNTIyhyy8UShp2+GN24FwraFRmOdwYqdWz 35MIdpa0Ar0OGPNtI1sspIIYs+BwkV0ShoeR3JKGr5CwuE1lBi7qvHToA0DwPOcC8Y8V TDRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si14653274pgl.48.2021.10.13.05.32.01; Wed, 13 Oct 2021 05:32:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231414AbhJMMdd (ORCPT + 99 others); Wed, 13 Oct 2021 08:33:33 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:34252 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbhJMMdc (ORCPT ); Wed, 13 Oct 2021 08:33:32 -0400 Received: from smtpclient.apple (p4ff9f2d2.dip0.t-ipconnect.de [79.249.242.210]) by mail.holtmann.org (Postfix) with ESMTPSA id 70460CECF6; Wed, 13 Oct 2021 14:31:28 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: [PATCH v2] Bluetooth: btintel: Fix bdaddress comparison with garbage value From: Marcel Holtmann In-Reply-To: <20211013080511.23945-1-kiran.k@intel.com> Date: Wed, 13 Oct 2021 14:31:28 +0200 Cc: linux-bluetooth , "Srivatsa, Ravishankar" , "Tumkur Narayan, Chethan" , "An, Tedd" , Luiz Augusto von Dentz Content-Transfer-Encoding: 7bit Message-Id: <21FB3BDC-FAA0-4CA5-A00E-D99167E3C9B3@holtmann.org> References: <20211013080511.23945-1-kiran.k@intel.com> To: Kiran K X-Mailer: Apple Mail (2.3654.120.0.1.13) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Kiran, > Intel Read Verision(TLV) data is parsed into a local structure variable > and it contains a field for bd address. Bd address is returned only in > bootloader mode and hence bd address in TLV structure needs to be validated > only if controller is present in boot loader mode. > > Signed-off-by: Kiran K > Reviewed-by: Tedd Ho-Jeong An > --- > > Notes: > changes in v2: > - Add comment for memsetting ver_tlv > > drivers/bluetooth/btintel.c | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel