Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f657c955-2a04-d6ae-cc10-3b0476a33fa3@systech.com>
Date:   Wed, 10 Nov 2021 07:46:50 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Content-Language: en-US
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     Jay Foster <jay.foster@systech.com>
From:   Jay Foster <jay.foster@systech.com>
Organization: Systech Corporation
Subject: BlueZ hciconfig: Segmentation Fault
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dENCSG84QmFObVdabm5rb1RYbmpOU2xWU21VbGNZQTdOWDUxdTllc3ZIVmVJ?=
 =?utf-8?B?L1JzbzdUNzdJbktac3NkZ1Y4VE94aUxDSnlNUTRXTERrekZIZDNGbmdsamxV?=
 =?utf-8?B?eDBkOXN2U25DRzJtcnNkUGovUGE1OTIvaWZjYzVmKy94bUtJR2lzTTBCaG45?=
 =?utf-8?B?eFdrWFFQRDg2WHRmT1ZTTVNxb3VZTDl4aFJGWlJYZWNld2hXZUtSS1ZodDhI?=
 =?utf-8?B?V2kraWlsdExtZ2I4cnZJN1BudTA3UWFid0lKbEhqRjVMdVdNSWg2b1R1QVdE?=
 =?utf-8?B?b09HK2xZS2lUVis1THFIdzJLbldnYVNTR2hPNWlwaTU0MU5TOVlPSDh5bm5u?=
 =?utf-8?B?M1E2VFZnZUZSYUVQT0JzV1ZseGVwQmxMZ1F6N3VPeUlWamFGV1R6UklPek1o?=
 =?utf-8?B?WTk1bEdra2ZaNEVqYktrdHorSUt3YlpKM1Rxd0FOTUJZbzFPcnoxWDQrOWI4?=
 =?utf-8?B?ZkxvUDhHWE1INDlGbTJSUXB3WGx1MUJGSGN6M2l3dVRuam5pZHFSL3hjdTYy?=
 =?utf-8?B?WDE4Mnc2RnByYVVsSUdIMXIrLzZIaTZSOUowODh5WHNSSzVQNTNrRUlpYjlP?=
 =?utf-8?B?alY3SGNNU0gydFBRb0l5dktwZVJhazBsZU92VmxBSHN0bHFOelFYVjZhd3Vy?=
 =?utf-8?B?bHQ3N3hTY1NTMkdvUVBFNFN4cUJ4ZVRKVk44SHNoM2g2N1Znd0k4cTV6VDdu?=
 =?utf-8?B?d2ZLdjdQek9xOXd5UmdWVXo4dG5mbkZRVUVHd29VTGFhYjRVcU1NQkNTT3Jp?=
 =?utf-8?B?R3VFL3U2SlhHOGpzenBINU4wVkU0VEtkWXoxeVpYdjBoM3FsVXYrVTdBTWpU?=
 =?utf-8?B?ZTN3T01NWDZtRms0cEZrSVhVZ0ZYZWdlTkRJOXVkYmpPV2pqL3NZSGJHU25y?=
 =?utf-8?B?aEVrTHQxSi9rUDYwa1M2Vy9xbHNrWXUwaENNWE8wYnhoS1BPQXBDbjVhNmxi?=
 =?utf-8?B?MzBqNk9EZVhlNldwd0k5ODVVVENiWXRLVEtTcXJqS3prUURSSk5uSG1YSXY4?=
 =?utf-8?B?b0NYUkJJT2Y0MHB5MUZlWWpQWVB6T1cwQ3dKaUFwaU1Ecno0UEZ6T1ZWQ25H?=
 =?utf-8?B?QnZNdUttQitJVXozeEdJUnMxWGRpUmtkWkhsSFpIYURFMXJQWGp5cmV2Nmhy?=
 =?utf-8?B?Yy9ETkxhRGdJZGVCVERpVmlRb0llVFpGM2loR1NrQWQ1OGlrK2N5M29nWHBP?=
 =?utf-8?B?U0tSQWd2UHIySEJCZ1B6SkhSVis1dUF0YlhObkdqS3pjNy82RllzRkxmZ2pV?=
 =?utf-8?B?MEZvS3A4TVJPSmdxSlFaejF3TWpqS3U2ZlBTVUVVMEVqOXpsTmkwaWptZEwx?=
 =?utf-8?B?THNiWG4wYUdsUzVkYkN4empSVGhmbzJGeG9TWExzcGhiQk1RcHRGbFl2eVRR?=
 =?utf-8?B?TlFFN1FBV2I1eEh5Qkw1Yjl1Qjc2U0FBZ05tVkcrZ0c4V2xTSGVXU2V2R1Rp?=
 =?utf-8?B?aGZCWHJXNTJyNjRkendYNlRndTBBOWdaMVE3a1grRHpjRHVxbEg1bzY5dXhI?=
 =?utf-8?B?SVV3Q0VkWmQ3S2tmSkNhQjZHNThzQWR2bFJFVXphS0lobmJabUtEWkU4R2FH?=
 =?utf-8?B?RmpRdyszU1dpNEZMaHNBYmp6YzNjMmMzbnNicVd5N0xYNUpwT1ViMkRpSnBW?=
 =?utf-8?B?YzYvaVh6WkdnZW9hV0RHbGwvQWc5aTk0dHJlZkdWUnZQaUdLOWRPcU83SjBK?=
 =?utf-8?B?NzdKeVNNekQ1djRFZ3hQc3U2T29wNlU0UEZRampSVjlQYUJvT284WDFhYlo5?=
 =?utf-8?B?QTN1eE1EUWNINHhaMjNqdVVWRFVWd0NjaUc5cHgrSHQ1R0d5Q2x4TUl4Rldw?=
 =?utf-8?B?QmloYm0rRmJ0Unl4ZkJaTEVzRzdnOXhDT2gvSnBZUGFqbG9IeWdOQ01vd2VK?=
 =?utf-8?B?OEFRbTFaZGI0dnZYZzlVSkh4NVprd3VuLzd1a29HNU1UZ01SdEhKQXJjZ1FG?=
 =?utf-8?B?V2dyQWFLdktTOUJMZVFRODYxMFNVUys3RFZCdUVjanp2SVhnRjJKdzNnT0VD?=
 =?utf-8?B?bER4Z3M3Q1FsRWZ6SHNSeTlQODdpL25jaU1PZUdxOEdVdGtnaXJhS2gyUXpD?=
 =?utf-8?B?YTg5aU5qTlQrM2F1U0RmVnFjM3BBWFlLcmpjaDNLaXhZeE9UQ0UxTnJZZUNv?=
 =?utf-8?B?YjJYenJ0S09HL3RQL0tQVUJRSmgwSnBkbWR2bnFOMFdFUFY0WjB6Z2pQYUNK?=
 =?utf-8?Q?j+xBg664wXvSoh2xts2xxBU=3D?=
X-OriginatorOrg: systech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9db6c878-2fa0-46ad-0153-08d9a46153d0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR20MB2664.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 15:46:57.9466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 47224f68-59f8-42cf-9b0c-62ae261b2df6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V2Ym6eKSbdik1oBv90pwli4LsvOaA5af1mY4jTlLx3OW9KkpFfLg3VPCIxkSnVahufn4XaF/z5tjTwABAOo3LQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR20MB2247
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

From: Jay Foster <jay.foster@systech.com>

hciconfig segfaults in the Bluez 5.62 release.

The 'hciconfig lm' command, used to show the current link mode settings,
de-references a NULL pointer when calling strcasestr().  This results in
a segmentation fault.  This is a regression in release 5.62 from the updates
to implement the appropriate language changes.

The hci_str2bit() function handles a NULL str value, but strcasestr() 
does not.

Signed-off-by: Jay Foster <jay.foster@systech.com>

--- a/lib/hci.c    2021-10-13 11:38:34.000000000 -0700
+++ b/lib/hci.c    2021-11-08 09:19:59.880207913 -0800
@@ -323,7 +323,7 @@ int hci_strtolm(char *str, unsigned int
      int ret = hci_str2bit(link_mode_map, str, val);

      /* Deprecated name. Kept for compatibility. */
-    if (strcasestr(str, "MASTER")) {
+    if (str && strcasestr(str, "MASTER")) {
          ret = 1;
          *val |= HCI_LM_MASTER;
      }