Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\))
Subject: Re: [PATCH v3] Bluetooth: btusb: re-definition for board_id in struct
 qca_version
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <96d03a2b0bd50da90a20990c42a814d9@codeaurora.org>
Date:   Mon, 15 Nov 2021 18:30:27 +0100
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        MSM <linux-arm-msm@vger.kernel.org>,
        Balakrishna Godavarthi <bgodavar@codeaurora.org>,
        c-hbandi@codeaurora.org, Hemantg <hemantg@codeaurora.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Rocky Liao <rjliao@codeaurora.org>, zijuhu@codeaurora.org
Content-Transfer-Encoding: 8BIT
Message-Id: <1593EED1-5745-49D1-B17A-F4C553F28644@holtmann.org>
References: <305e41a55a4c117da86f786c374a57dc@codeaurora.org>
 <8E687716-E810-4A46-B010-A08BB261D2FF@holtmann.org>
 <96d03a2b0bd50da90a20990c42a814d9@codeaurora.org>
To:     tjiang@codeaurora.org
Precedence: bulk

Hi Tim,

>  the following is the explanation from qc btsoc team:
> 
> The board ID should be split into two bytes.
> The 1st byte is chip ID, and the 2nd byte is platform ID.
> For example, board ID 0x010A, 0x01 is platform ID. 0x0A is chip ID.
> Currently we have several platforms, and platform IDs are continuously added.
> We would not distinguish different chips if we get these mixed up.
> Platform ID:
> •             0x00 is for Mobile
> •             0x01 is for X86( ID # from 257)
> •             0x02 is for Automotive(ID# from 513 )
> •             0x03 is for Consumer electronic( ID# from 769)
> …

then use u8 chip_id and u8 platform_id in the data structure and add description like above when you combine chip_id and platform_id into board_id.

Regards

Marcel