MIME-Version: 1.0
References: <20211117110627.BlueZ.v5.1.I7f6bdb9282c1e12ffc6c662674678f2b1cb69182@changeid>
 <20211117110627.BlueZ.v5.6.I363090b80e59a3cda134c9bd2df0b3bca2cb527b@changeid>
In-Reply-To: <20211117110627.BlueZ.v5.6.I363090b80e59a3cda134c9bd2df0b3bca2cb527b@changeid>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 17 Nov 2021 13:09:15 -0800
Message-ID: <CABBYNZL994EW-=6xrknc3LK0sRv4pv7OReKiWzC3eF54MBK0xw@mail.gmail.com>
Subject: Re: [BlueZ PATCH v5 6/6] core: Update default advmon Sampling_Period
 to 0xFF
To:     Manish Mandlik <mmandlik@google.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>,
        Miao-chen Chou <mcchou@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Manish,

On Wed, Nov 17, 2021 at 11:15 AM Manish Mandlik <mmandlik@google.com> wrote:
>
> Update default Advertisemet Monitor Sampling_Period to 0xFF. It
> indicates that controller will report only one advertisement per
> monitoring period for a device. This will help reduce the power
> consumption drastically.
>
> Reviewed-by: Miao-chen Chou <mcchou@google.com>
> ---
>
> Changes in v5:
> - New patch in the series. Update default Sampling_Period to 0xFF.
>
>  src/main.c    | 2 +-
>  src/main.conf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index 5ca8d5644..1f852fdf6 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -932,7 +932,7 @@ static void init_defaults(void)
>         btd_opts.avdtp.session_mode = BT_IO_MODE_BASIC;
>         btd_opts.avdtp.stream_mode = BT_IO_MODE_BASIC;
>
> -       btd_opts.advmon.rssi_sampling_period = 0;
> +       btd_opts.advmon.rssi_sampling_period = 0xFF;
>  }
>
>  static void log_handler(const gchar *log_domain, GLogLevelFlags log_level,
> diff --git a/src/main.conf b/src/main.conf
> index e05291d8e..e49259453 100644
> --- a/src/main.conf
> +++ b/src/main.conf
> @@ -260,5 +260,5 @@
>  [AdvMon]
>  # Default RSSI Sampling Period. This is used when a client registers an
>  # advertisement monitor and leaves the RSSISamplingPeriod unset.
> -# Default: 0
> +# Default: 0xFF (Report only one Adv per device during the monitoring period)
>  #RSSISamplingPeriod=0

While at it it would be good to explain what is the unit used here,
also it is common practice to have the default on the commented entry.

> --
> 2.34.0.rc1.387.gb447b232ab-goog
>


-- 
Luiz Augusto von Dentz