From:   "K, Kiran" <kiran.k@intel.com>
To:     Marcel Holtmann <marcel@holtmann.org>
CC:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        "Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
        "Von Dentz, Luiz" <luiz.von.dentz@intel.com>
Subject: RE: [PATCH v2 1/9] adapter: Enable MSFT a2dp offload codec when
 Experimental is set
Thread-Topic: [PATCH v2 1/9] adapter: Enable MSFT a2dp offload codec when
 Experimental is set
Thread-Index: AQHX3SkDRTg+1M7f0EyccYn2B9o55qwKn9OAgAAA0RA=
Date:   Fri, 19 Nov 2021 10:10:06 +0000
Message-ID: <DM8PR11MB5573C323C7A90D177E0EB4A7F59C9@DM8PR11MB5573.namprd11.prod.outlook.com>
References: <20211119094235.2432-1-kiran.k@intel.com>
 <089A59F0-C858-43BF-80AC-0C384799A87F@holtmann.org>
In-Reply-To: <089A59F0-C858-43BF-80AC-0C384799A87F@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tOkPlWhHX7zx/KrwIn84nsrNY20FxpntPtGb9BnWnHTUps+7sQ7p50rROcIx?=
 =?us-ascii?Q?jPJxVjeFk8hcQSGC6ELYUCagyawlLgd51ot2Pp41lJk991yck7/atVHfglxb?=
 =?us-ascii?Q?9ayraK64q9w4PA4qArWkxhnUE5FtlpuYGVbFM1gT/P8qgS5DpsRplgrD5Ncg?=
 =?us-ascii?Q?t956qC1us3FBdElg9QC4GhkHP/Zm4JkqODAY8mZm6136JUN2akKc50ckkd1h?=
 =?us-ascii?Q?Yuu0eOWXe+1XK99b+q4M7WuvtJHFg0qtXctAFpPeUOQQJUDjBX2B/USj/fI+?=
 =?us-ascii?Q?Ge5lQc+qQ38lSwao2J2KllNfSTAxTzVk5roPio9NJAG1mXlsXqXvlkdsLBF/?=
 =?us-ascii?Q?jjQmGBFc+cPewwZyvWM0HsgiYrwHTg48pB4dPxZ40U+8vc6pEGE9IkK/cfLg?=
 =?us-ascii?Q?tbr+W3fXZPCclhZspdXA9zzCpxWh8ZtnJ/ZsXuQU4X/MX4kzI1P+XEqIC0hX?=
 =?us-ascii?Q?nu48qm+YIT41GsRkma2pKV/B2BOrYiGjdSb5HiRHpSczNJ7LC8aIn65A4jGd?=
 =?us-ascii?Q?VMhQ7cAQ/VQvZOEZg8vm+Z3i9W4TCFw6prHLHv3TpEonIdu6zogOCWxPZmzu?=
 =?us-ascii?Q?RaSVcobRpGxoJ/YgyDvQAySu6/iOgOFQRsquVbxWPIPhZ3UaZ50zGp3U68zo?=
 =?us-ascii?Q?SnGbLiarAogtwaemra+vDbt0T7kyr9ote6auTABpBvRft+5EiUm62h8jxfwT?=
 =?us-ascii?Q?brKpyq8GpjW9EuYpFUz0G/doGDjioX3qelQs/FbBxqbhnmAXgsr04czS2WIs?=
 =?us-ascii?Q?EBRURW3cemp8EBMVW87e4OBTuVm9ac1ENLuCwpzg4CUYwgRyVjJHS/CMKZ6q?=
 =?us-ascii?Q?1w1uC4yqYY7uazTYvIrwI7A3mCGhFFarXVC/OJdF6XE0p/GDk5LpW2keayxI?=
 =?us-ascii?Q?lZsNHHwx4enOppyeJTKl+EcrVo+vrJNSpKLWnZb49MhkjYSeFqDNHtOl7oZY?=
 =?us-ascii?Q?sbvuiipjEuPjI+kKEONvz2Fpd4Qh+tisicoOOPhmLk3VyskRo2T4MgUKu4Vf?=
 =?us-ascii?Q?jjt9As7pUQKT7Lbl4ofbZI7iHL4f8KLvXnNrKoogjefn4RDPgsvoFJpD9h4F?=
 =?us-ascii?Q?4BPTIQSQJZq3OvXMFYpZu+HCXXP9O7WcjcAWbWLverxZfxSE4/l0f3TnEj2H?=
 =?us-ascii?Q?+lsylqr1kNE4qfYDThaKqs07J9bTnWubpRtQ2irsppLAKw9H4xmgbjlVmioZ?=
 =?us-ascii?Q?xgd54CovLl5LVcAvkoB1pjNh827pORDOVlmQ58+WcQiv+YTiQSnIA8xpZiUP?=
 =?us-ascii?Q?x87dGCK4pxKY/7K/XdsQYxh98xO8qr/zNUdtX6/XPqRdlvt1yCkkNhjQIH+/?=
 =?us-ascii?Q?/7kBEPMPsaEjAkFRa5nzyI4+jZUyAsQUGIVHDldaf7Z7u2WilBksRpyIqbPY?=
 =?us-ascii?Q?cdf8E9YklTlo63GQ1Dfce1rSUtr8XgM45ZxLGdUzO5CNoGesxWXc3e52OzVf?=
 =?us-ascii?Q?Vn3E1S0Zy2C9eFqCcn+267eULyqqXZ54+b/CBVZ9Lp7WC7/V/vCc98fy0OpG?=
 =?us-ascii?Q?T/8m2rHhXIl2MYCpm0X4VJsW5Ulg3cM8ftw/AVc+gOcIJw4Yhhb8SNVMP2nm?=
 =?us-ascii?Q?n0dggl97aKcWlZqs8g5VOv7OKQgC8o5Igd0yXxgfQwQ6BBTUq8M7RlXXmgd3?=
 =?us-ascii?Q?eg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e03fb72-b9da-47ae-f1f6-08d9ab44c323
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2021 10:10:06.8838
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jjUiqbUOL+9jMJPyHDn82fyC1WOAqjFYI8XTZ6FcwbQeADk45vJ4FzywnrfNuIYIaG3Tfcg+DaBh4y9u8pl1UA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Hi Marcel,

> -----Original Message-----
> From: Marcel Holtmann <marcel@holtmann.org>
> Sent: Friday, November 19, 2021 3:36 PM
> To: K, Kiran <kiran.k@intel.com>
> Cc: linux-bluetooth@vger.kernel.org; Srivatsa, Ravishankar
> <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@intel.com>; Von Dentz, Luiz
> <luiz.von.dentz@intel.com>
> Subject: Re: [PATCH v2 1/9] adapter: Enable MSFT a2dp offload codec when
> Experimental is set
>=20
> Hi Kiran,
>=20
> > This enables codec offload experimental feature if its UUIDs has been
> > enabled by main.conf:Experimental or -E has been passed in the command
> > line.
> > ---
> > src/adapter.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> > src/main.c    |  1 +
> > src/main.conf |  1 +
> > 3 files changed, 45 insertions(+)
> >
> > diff --git a/src/adapter.c b/src/adapter.c index
> > 309956bbb5be..1627cc127057 100644
> > --- a/src/adapter.c
> > +++ b/src/adapter.c
> > @@ -142,6 +142,13 @@ static const struct mgmt_exp_uuid
> codec_offload_uuid =3D {
> > 	.str =3D "a6695ace-ee7f-4fb9-881a-5fac66c629af"
> > };
> >
> > +/* 0cc2131f-96f0-4cd1-b313-b97e7cbc8335 */ static const struct
> > +mgmt_exp_uuid msft_a2dp_offload_codecs_uuid =3D {
> > +	.val =3D { 0x35, 0x83, 0xbc, 0x7c, 0x7e, 0xb9, 0x13, 0xb3,
> > +		0xd1, 0x4c, 0xf0, 0x96, 0x1f, 0x13, 0xc2, 0x0c},
> > +	.str =3D "0cc2131f-96f0-4cd1-b313-b97e7cbc8335"
> > +};
> > +
> > static DBusConnection *dbus_conn =3D NULL;
> >
> > static uint32_t kernel_features =3D 0;
> > @@ -9789,6 +9796,41 @@ static void codec_offload_func(struct
> btd_adapter *adapter, uint8_t action)
> > 	btd_error(adapter->dev_id, "Failed to set Codec Offload"); }
> >
> > +static void msft_a2dp_offload_complete(uint8_t status, uint16_t len,
> > +				       const void *param, void *user_data) {
> > +	struct btd_adapter *adapter =3D user_data;
> > +	uint8_t action =3D btd_opts.experimental ? 0x01 : 0x00;
> > +
> > +	if (status !=3D 0) {
> > +		error("Set MSFT a2dp offload codec failed with status 0x%02x
> (%s)",
> > +		       status, mgmt_errstr(status));
> > +		return;
> > +	}
> > +
> > +	DBG("MSFT a2dp offload codecs successfully set");
>=20
> we need to switch to using btd_debug or DBG_IDX to include the index
> number in the traces.

Ok.
>=20
> > +
> > +	if (action)
> > +		queue_push_tail(adapter->exps,
> > +				(void *)msft_a2dp_offload_codecs_uuid.val);
> > +}
> > +
> > +static void msft_a2dp_offload_func(struct btd_adapter *adapter,
> > +uint8_t action) {
> > +	struct mgmt_cp_set_exp_feature cp;
> > +
> > +	memset(&cp, 0, sizeof(cp));
> > +	memcpy(cp.uuid, msft_a2dp_offload_codecs_uuid.val, 16);
> > +	cp.action =3D action;
> > +
> > +	if (mgmt_send(adapter->mgmt, MGMT_OP_SET_EXP_FEATURE,
> > +		      adapter->dev_id, sizeof(cp), &cp,
> > +		      msft_a2dp_offload_complete, adapter, NULL) > 0)
> > +		return;
> > +
> > +	btd_error(adapter->dev_id, "Failed to set RPA Resolution"); }
>=20
> We are no longer dealing with the blunt copy-and-paste mistakes, please d=
o
> a proper review before sending any patch.

My bad. I will address in the next patchset.
>=20
> Regards
>=20
> Marcel

Thanks,
Kiran