MIME-Version: 1.0
References: <20211119082027.12809-1-kiran.k@intel.com> <20211119082027.12809-6-kiran.k@intel.com>
In-Reply-To: <20211119082027.12809-6-kiran.k@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 23 Nov 2021 15:52:31 -0800
Message-ID: <CABBYNZ+9k60YTUsg1F_k2UgVz=9YixoQS5nwBrdJRjL+HOkPig@mail.gmail.com>
Subject: Re: [PATCH v4 06/14] Bluetooth: Remove unused member in struct hci_vnd_codec_v2
To:     Kiran K <kiran.k@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
        Chethan T N <chethan.tumkur.narayan@intel.com>,
        Luiz Augusto Von Dentz <luiz.von.dentz@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Kiran,

On Fri, Nov 19, 2021 at 12:16 AM Kiran K <kiran.k@intel.com> wrote:
>
> Remove unused "u8 id" member in struct hci_vnd_codec_v2. Vendor codec
> is identifiable by Company Id and Vendor Id fields.
>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> ---
>  include/net/bluetooth/hci.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index e52fd2f1e046..54fae19f3758 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -1395,7 +1395,6 @@ struct hci_std_codecs_v2 {
>  } __packed;
>
>  struct hci_vnd_codec_v2 {
> -       __u8    id;
>         __le16  cid;
>         __le16  vid;
>         __u8    transport;
> --
> 2.17.1

Not following this change, afaik LC3 for example should be id 0x06
cid/vid 0x0000 as that is not a vendor, or this is never used for
codecs defined in the spec?


-- 
Luiz Augusto von Dentz