Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8972C433F5 for ; Mon, 29 Nov 2021 08:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241837AbhK2I10 convert rfc822-to-8bit (ORCPT ); Mon, 29 Nov 2021 03:27:26 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:52963 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242541AbhK2IZZ (ORCPT ); Mon, 29 Nov 2021 03:25:25 -0500 Received: from smtpclient.apple (p5b3d2e91.dip0.t-ipconnect.de [91.61.46.145]) by mail.holtmann.org (Postfix) with ESMTPSA id CD473CED1F; Mon, 29 Nov 2021 09:22:06 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [PATCH 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16 inch, 2019) From: Marcel Holtmann In-Reply-To: <47A8DBEC-322F-4C42-AF69-5FDB828B8680@live.com> Date: Mon, 29 Nov 2021 09:22:06 +0100 Cc: Thorsten Leemhuis , Orlando Chamberlain , Daniel Winkler , Greg KH , Johan Hedberg , "linux-bluetooth@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Luiz Augusto von Dentz , "regressions@lists.linux.dev" , "sonnysasaka@chromium.org" , "stable@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: <056FB976-25A3-466C-8C6D-DD5E11FDACCD@holtmann.org> References: <20211001083412.3078-1-redecorating@protonmail.com> <70a875d0-7162-d149-dbc1-c2f5e1a8e701@leemhuis.info> <20211116090128.17546-1-redecorating@protonmail.com> <3B8E16FA-97BF-40E5-9149-BBC3E2A245FE@live.com> <52DEDC31-EEB2-4F39-905F-D5E3F2BBD6C0@live.com> <8919a36b-e485-500a-2722-529ffa0d2598@leemhuis.info> <20211117124717.12352-1-redecorating@protonmail.com> <40550C00-4EE5-480F-AFD4-A2ACA01F9DBB@live.com> <332a19f1-30f0-7058-ac18-c21cf78759bb@leemhuis.info> <5B9FF471-42DD-44DA-A9CE-0A83BA7A4212@live.com> <47A8DBEC-322F-4C42-AF69-5FDB828B8680@live.com> To: Aditya Garg X-Mailer: Apple Mail (2.3693.20.0.1.32) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Aditya, >>> Bluetooth on Apple MacBook Pro 16,1 is unable to start due to LE Min/Max Tx Power being queried on startup. Add a DMI based quirk so that it is disabled. >> >> list all the MacBooks that you found problematic right now. We add the >> initial as a large batch instead of all individual. >> >>> >>> Signed-off-by: Aditya Garg >>> Tested-by: Aditya Garg >>> --- >>> drivers/bluetooth/btbcm.c | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c >>> index e4182acee488c5..c1b0ca63880a68 100644 >>> --- a/drivers/bluetooth/btbcm.c >>> +++ b/drivers/bluetooth/btbcm.c >>> @@ -8,6 +8,7 @@ >>> >>> #include >>> #include >>> +#include >>> #include >>> >>> #include >>> @@ -343,9 +344,23 @@ static struct sk_buff *btbcm_read_usb_product(struct hci_dev *hdev) >>> return skb; >>> } >>> >>> +static const struct dmi_system_id disable_broken_read_transmit_power[] = { >>> + { >>> + /* Match for Apple MacBook Pro 16,1 which needs >>> + * Read LE Min/Max Tx Power to be disabled. >>> + */ >> >> Actually leave the comment out. You are not adding any value that isn’t >> already in the variable name or the DMI. It is just repeating the obvious. > Alright, I prepare the patches into a single one two patches, one for adding the quirk to the core and one for adjusting the driver. Regards Marcel