Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7BCC433EF for ; Thu, 2 Dec 2021 16:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359676AbhLBQvL (ORCPT ); Thu, 2 Dec 2021 11:51:11 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:57212 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359624AbhLBQvK (ORCPT ); Thu, 2 Dec 2021 11:51:10 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D9BF42170C; Thu, 2 Dec 2021 16:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1638463666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxRcxXmxG76qGgTBaBeUpBFize7WnysyyQikOH1GeMQ=; b=HUXDDvix0EhVysEIXBAAeRj4c+oJvzf2MgTIPIDWLWcEpDLwLDQKQIh4zbp2A8tc1Erm3T O6e6QA/Oe5GH206Bfr/u+9ueXt0F4RL2EewIkSFgTkXayDasehTgy/j3OsgPGwNAv9uxB8 nexnS57PKndbNKcWaRt8W8yUfCT4Tjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1638463666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mxRcxXmxG76qGgTBaBeUpBFize7WnysyyQikOH1GeMQ=; b=Bbllj+KgbrxrHyOjRGzVQ8mF0qCLSExZfVYOv6b8mDHyJBBRRltfYEXih5ItosZXsXiTPz 6zMdUMDMf187UXCQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id BFDC5A3B83; Thu, 2 Dec 2021 16:47:46 +0000 (UTC) Date: Thu, 02 Dec 2021 17:47:46 +0100 Message-ID: From: Takashi Iwai To: Paul Menzel Cc: Takashi Iwai , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Tedd Ho-Jeong An , linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: Apply initial command workaround for more Intel chips In-Reply-To: References: <20211202162256.31837-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Thu, 02 Dec 2021 17:32:14 +0100, Paul Menzel wrote: > > Dear Takashi, > > > Am 02.12.21 um 17:22 schrieb Takashi Iwai: > > It seems that a few more Intel chips require the workaround for the > > broken initial command. At least, per openSUSE Bugzilla reports, > > 8087:0a2a and 8087:0026 need BTUSB_INTEL_BROKEN_INITIAL_NCMD flag. > > > > Fixes: 83f2dafe2a62 ("Bluetooth: btintel: Refactoring setup routine for legacy ROM sku") > > Buglink: https://bugzilla.opensuse.org/show_bug.cgi?id=1193124 > > Signed-off-by: Takashi Iwai > > > > […] > > I have a Dell Latitude E7250 with > > Bus 001 Device 003: ID 8087:0a2a Intel Corp. Bluetooth wireless > interface > > and Bluetooth seems to work fine minus some Linux warnings [1] and a > problem transferring greater than some bytes files with the Nokia N9 > [2]. > > Linux 5.16-rc3, Dell Inc. Latitude E7250/0TVD2T, BIOS A19 01/23/2018: > > ``` > $ sudo dmesg | grep -i bluet > [ 8.173417] calling bt_init+0x0/0xb3 [bluetooth] @ 301 > [ 8.173439] Bluetooth: Core ver 2.22 > [ 8.173463] NET: Registered PF_BLUETOOTH protocol family > [ 8.173464] Bluetooth: HCI device and connection manager initialized > [ 8.173467] Bluetooth: HCI socket layer initialized > [ 8.173470] Bluetooth: L2CAP socket layer initialized > [ 8.173473] Bluetooth: SCO socket layer initialized > [ 8.173475] initcall bt_init+0x0/0xb3 [bluetooth] returned 0 after > 35 usecs > [ 8.216875] Bluetooth: hci0: Legacy ROM 2.5 revision 1.0 build 3 > week 17 2014 > [ 8.233515] bluetooth hci0: firmware: direct-loading firmware > intel/ibt-hw-37.8.10-fw-1.10.3.11.e.bseq > [ 8.233520] Bluetooth: hci0: Intel Bluetooth firmware file: > intel/ibt-hw-37.8.10-fw-1.10.3.11.e.bseq > [ 8.540884] Bluetooth: hci0: unexpected event for opcode 0xfc2f > [ 8.558942] Bluetooth: hci0: Intel BT fw patch 0x32 completed & activated > ``` Thanks, so this seems depending on the hardware, maybe a subtle difference matters. As far as I read the code changes, the workaround was applied in the past unconditionally, so it must be fairly safe even if the chip works as is. Or, for avoiding the unnecessarily application of the workaround, should it be changed as a fallback after the failure at the first try...? Takashi