MIME-Version: 1.0
References: <20211208223923.519664-1-hj.tedd.an@gmail.com>
In-Reply-To: <20211208223923.519664-1-hj.tedd.an@gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 9 Dec 2021 10:45:05 -0800
Message-ID: <CABBYNZJQsn5JVVzR4Uy3AMmkZyhLbXqS_rY=H9-OZFHOeAPqoA@mail.gmail.com>
Subject: Re: [BlueZ V2 PATCH 0/5] Replace random number generation function
To:     Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Tedd Ho-Jeong An <tedd.an@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tedd,

On Wed, Dec 8, 2021 at 5:29 PM Tedd Ho-Jeong An <hj.tedd.an@gmail.com> wrote:
>
> From: Tedd Ho-Jeong An <tedd.an@intel.com>
>
> The Coverity scan reported (CWE-676):
>   rand() should not be used for security-related applications, because
>   linear congruential algorithms are too easy to break.
>
> This series of patch replaces the standard random number generation
> function, rand(), to getrandom() syscall, which provides more secure
> random number than the standard rand() function.
>
> Tedd Ho-Jeong An (5):
>   emulator: Replace random number generation function
>   peripheral: Replace random number generation function
>   tools/btgatt-server: Replace random number generation function
>   plugins: Replace random number generation function
>   profiles/health: Replace random number generation function
>
>  emulator/le.c          | 11 +++++++++--
>  emulator/phy.c         | 10 ++++++++--
>  peripheral/main.c      | 11 ++++++-----
>  plugins/autopair.c     |  8 +++++++-
>  profiles/health/hdp.c  | 11 +++++++----
>  profiles/health/mcap.c | 17 +++++++++++++++--
>  tools/btgatt-server.c  |  7 ++++++-
>  7 files changed, 58 insertions(+), 17 deletions(-)
>
> --
> 2.25.1

Applied, thanks.

-- 
Luiz Augusto von Dentz