From:   "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@quicinc.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@quicinc.com>
CC:     Johan Hedberg <johan.hedberg@gmail.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        "Hemant Gupta (QUIC)" <quic_hemantg@quicinc.com>,
        MSM <linux-arm-msm@vger.kernel.org>,
        quic_bgodavar <quic_bgodavar@quicinc.com>,
        Rocky Liao <rjliao@codeaurora.org>,
        "hbandi@codeaurora.org" <hbandi@codeaurora.org>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
        Miao-chen Chou <mcchou@chromium.org>,
        "PANICKER HARISH (Temp) (QUIC)" <quic_pharish@quicinc.com>
Subject: RE: [PATCH v2] Bluetooth: btqca: sequential validation
Thread-Topic: [PATCH v2] Bluetooth: btqca: sequential validation
Thread-Index: AQHX7MjINdT5VbQJeEaHM/dJwnhK5Kwp+ikAgAl59uA=
Date:   Wed, 15 Dec 2021 11:28:16 +0000
Message-ID: <SN4PR0201MB87254F7D357675346E138AF7E3769@SN4PR0201MB8725.namprd02.prod.outlook.com>
References: <1639032466-8457-1-git-send-email-quic_saluvala@quicinc.com>
 <42E81D62-346C-4AC0-9B97-A54D67482331@holtmann.org>
In-Reply-To: <42E81D62-346C-4AC0-9B97-A54D67482331@holtmann.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 8e2f9f89-0a4a-4abb-dc6c-08d9bfbdfce1
x-ms-traffictypediagnostic: SA0PR02MB7291:EE_
x-ld-processed: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d,ExtAddr
x-microsoft-antispam-prvs: <SA0PR02MB7291BE32821B3A3720EC38109F769@SA0PR02MB7291.namprd02.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2887;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: HKwxjbBF0sD+mcPkim5IxaqmFJr8SljneA0KiLyK0w2Pz/CqjxZ4ecwtKRtYNMder3842s+UCi3pcl3mIVaqVjYmqj3kPVLQWncLo4yXGxfdPpIpIQfUwhiQXaRT+f0zXEQHybGRpT1tM/hnD+l7GySUeCb2Zfy++mOxC81wb8j3JA90uon54NMBo/ZT8wHpVdU/cnfiPtIv7EbmDWxBggwSL8oMhFqkRsBvdSoyfnnxc8fGwpk+Zf4ROKOBFS772d5/3/yv8ez9No2xtD22FbCsSJ6sjUN100WtUrJrnxZrLVzRzca9JxZI9jz8H7N6xDm3wdBlJR4Bc/l8bwjDYu/+RpgsIsK1qG9QpzQc0XZBVWTvsVAmSpZMcS1oY9JRKFGlUUnbNi6qy00qYFFCOJpZcIBLTHMy/41hzPFxhHSrhM3IU2nOsHF6/xiGGC1A1WQgpnHOGYVfBpPCotxuSOHQKH+5CBjVAbMcqWiGU0Ln6+qv1sgGryAE8uO+B/pt2E3i1X/iDhUGQ0ff5yFaeyGfOwi0k3RivI5xwRV1cwDCkir+f/wKzOXnaYxA8Nkz7sP65UL3GSEeDt1LsNl4DbnfO8EncWUwsYYjCevzmZfOApW5qdCnjy7ZCWLpmObst4A3RKQtp8FGl1gk25yZfeFbDDf/U5muRcVl3WBX7KVJAvAJK1EWUQax6oa9rtA2AIB9nCJB8BffkaKBJEbtYQ==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR0201MB8725.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(2906002)(33656002)(55016003)(316002)(7696005)(38070700005)(107886003)(38100700002)(5660300002)(186003)(6506007)(122000001)(86362001)(52536014)(53546011)(110136005)(7416002)(64756008)(54906003)(4326008)(83380400001)(508600001)(71200400001)(66446008)(26005)(9686003)(66946007)(66556008)(66476007)(76116006)(8676002);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BjJMgW91EYRpCj3O1kaOWqqTAtMJKZ8AkNErtNVlye/K+VE2wBeyGUAoIqXM?=
 =?us-ascii?Q?MSngxPRWaBOV7nCrlUh4pnOv1wgd38s9tlZOibj4gR9zPPXjGgAHjvRMe7nE?=
 =?us-ascii?Q?5tiKJ/3QfjoRmvgRQ62/jYEPqMyA3Ka4BxXMCxpOZS/yU6fmCTsho3qC2qT1?=
 =?us-ascii?Q?GME193zZA/2PXwyNFv+jZ1v0HZ85HId64tVcdxdSgw5s2SR3HjZNSPFdHBiW?=
 =?us-ascii?Q?PKioY6MN2sBvyeRYjcOAenSDvGB0xoqKDHt0PSdr3Z38r4lXYN/45c8lZIPX?=
 =?us-ascii?Q?ODg7EXaBhajKcw6xUkecot4g9BRGwKTrT3m71gz6u5ArFuptLMOtE2EY3B7t?=
 =?us-ascii?Q?kk4SJnTEp9Sfu66Z5fVADVX9iKR9ibshFdoWlAdqv02zqD91y7Y21su18LSX?=
 =?us-ascii?Q?sRsZuZHdKGrgsM15n7qqYeagploZalqqjGMd3aex0JONWsAcE9ivUUUWS4nQ?=
 =?us-ascii?Q?E85hA6atmZ2hNFIedfHMdChKBLaOaw1uTbVnfOudK/X8YDfaqgNwstEHrHmq?=
 =?us-ascii?Q?TGzJqLDdQE+BJ4uzcqY7LwMM0/uUHeMR16/Ka+jfzs9h8sjN932bRGxDKCPp?=
 =?us-ascii?Q?ZNN4eiNqabj9B0IOJ3wfrM3ciYV1boTs93VmQaYf4FTgvVBaO/yjBpkVKKQi?=
 =?us-ascii?Q?K8I7mQC2BTRGLzCaERRn1IyxHnYL12HtYHjtxPCpo1NcjU6AAI1jH/pC7hzK?=
 =?us-ascii?Q?9kRMq3UJRSolIzCb4muVhruyzkNeOFbzrgxCM6TvEkGpsbYLpIL7KnhwULA8?=
 =?us-ascii?Q?/a89hFlSa0xifqF2SfuvI38Y70AXEyUGZcg0cK/gFMidtSaHVzWtHhmfDori?=
 =?us-ascii?Q?LJbJVuuFKzaQF4kCTMrK4GBF8td45h8zUXdriG9cQF5SGGlahcWuxQgV4ybV?=
 =?us-ascii?Q?8kvY2IRCN8gDlXSDZmwRf5xs6ztUJZ7AhI6IogaVhGV+MHc/h/teIs7G+lSq?=
 =?us-ascii?Q?J1XRxr4AOo9anYF+fUOZA7myraCbk4aSXyISZkPfoMYBk/OidG0hy62Pm85+?=
 =?us-ascii?Q?7vyM3Wnkgu3A2sEBmski1rB+NlZ3OoYWz7tOiI61zd6mstiIvq+lGkNamNpl?=
 =?us-ascii?Q?i8uegOiaEpQXKcaaXtcH13kh5xdTFH+Vu9iWceJqKmhOwwaychXAlEMftaUl?=
 =?us-ascii?Q?QVRTUfkUQ6vua/wUcNPKTXE4qH/3NpbrjDu0czynnF7vBW1GSSU+g031cxra?=
 =?us-ascii?Q?w7PbMZvVUS1rKWmicu//n1jkrFx/USw7ZG/GQqU3N54X5Owdg3A7E+Q+PQGR?=
 =?us-ascii?Q?waytcV5rXkRX9Lv8hbFl8PrPmdI6b2pwovT2DVsYDxuNB2KfiSZCyEotKxoh?=
 =?us-ascii?Q?ngAGpz3Q6vTOViE9G2HVGDi56SogZjcAPI7KNFhFAXkodpLyZK8gS0cmxWkX?=
 =?us-ascii?Q?i8wMpWhhIOqDpq/QnZIayPemGroiJV+su59e3n1c/Ss7xE8l9BQJyr89ooeS?=
 =?us-ascii?Q?TOljwg1U9C/Hmup1+lEIIWjEXPp4JrpSZngwwfCc//VP+OPX4OXY8ZY04vIv?=
 =?us-ascii?Q?AzVZJ5//bA5Ap/DIj81NMgKICODohjWtzTNRvMu3RautYK6l/oJN8RGE7rH4?=
 =?us-ascii?Q?VIk3Of98jD/NpJbCAhQhywfJcIKVcItGgYmD7BHCP1nvSb0kMhV20Uj9o9rI?=
 =?us-ascii?Q?05Lrn3erY7b0vH3/jiX/92ixQM3plaXWXD9p5ItHolhJT7n5uPVr8LqMi72K?=
 =?us-ascii?Q?GDbk2Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0201MB8725.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e2f9f89-0a4a-4abb-dc6c-08d9bfbdfce1
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 11:28:16.0458
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Vg4mZjFnXFOrWFUUAu4dKnnDD+adv8yCue7QqC+CyomHC9hCMCeJq8L0Q31vsywBKqp2N6jWusBKQUE0PWIeLvP5FCUdY/+NKh0deX6mLq8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7291
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org


-----Original Message-----
From: Marcel Holtmann <marcel@holtmann.org>=20
Sent: Thursday, December 9, 2021 4:15 PM
To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>; Matthias Kaehlcke <mka@chromiu=
m.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; linux-blu=
etooth <linux-bluetooth@vger.kernel.org>; Hemant Gupta (QUIC) <quic_hemantg=
@quicinc.com>; MSM <linux-arm-msm@vger.kernel.org>; quic_bgodavar <quic_bgo=
davar@quicinc.com>; Rocky Liao <rjliao@codeaurora.org>; hbandi@codeaurora.o=
rg; Abhishek Pandit-Subedi <abhishekpandit@chromium.org>; Miao-chen Chou <m=
cchou@chromium.org>; PANICKER HARISH (Temp) (QUIC) <quic_pharish@quicinc.co=
m>
Subject: Re: [PATCH v2] Bluetooth: btqca: sequential validation

Hi Sai,

> This change will have sequential validation support & patch config=20
> command is added
>=20
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> ---
> drivers/bluetooth/btqca.c | 50=20
> +++++++++++++++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btqca.h |  2 ++
> 2 files changed, 52 insertions(+)
>=20
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c=20
> index be04d74..633a24c 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -141,6 +141,53 @@ static int qca_read_fw_build_info(struct hci_dev *hd=
ev)
> 	return err;
> }
>=20
> +static int qca_send_patch_config_cmd(struct hci_dev *hdev) {
> +	struct sk_buff *skb;
> +	int err =3D 0;
> +	u8 cmd[] =3D {EDL_PATCH_CONFIG_CMD, 0x01, 0, 0, 0};

is there are reason not to address review comments?
[Sai] : I will address in next patch

	const u8 cmd[] =3D { EDL_PATCH_CONFIG_CMD, 0x01, 0, 0, 0 };

> +	u8 rlen =3D 0x02;
> +	struct edl_event_hdr *edl;
> +	u8 rtype =3D EDL_PATCH_CONFIG_CMD;

I missed these two and must have assumed there are used somewhere, rlen and=
 rtype are a waste to be declared.
[Sai] : I will delete rlen in next patch.

> +
> +	bt_dev_dbg(hdev, "QCA Patch config");
> +
> +	skb =3D __hci_cmd_sync_ev(hdev, EDL_PATCH_CMD_OPCODE, sizeof(cmd),
> +				cmd, HCI_EV_VENDOR, HCI_INIT_TIMEOUT);
> +	if (IS_ERR(skb)) {
> +		err =3D PTR_ERR(skb);
> +		bt_dev_err(hdev, "Sending QCA Patch config failed (%d)", err);
> +		return err;
> +	}
> +
> +	if (skb->len !=3D rlen) {

	if (skb->len !=3D 2) {

> +		bt_dev_err(hdev, "QCA Patch config cmd size mismatch len %d", skb->len=
);
> +		err =3D -EILSEQ;
> +		goto out;
> +	}
> +
> +	edl =3D (struct edl_event_hdr *)(skb->data);
> +	if (!edl) {
> +		bt_dev_err(hdev, "QCA Patch config with no header");
> +		err =3D -EILSEQ;
> +		goto out;
> +	}
> +
> +	if (edl->cresp !=3D EDL_PATCH_CONFIG_RES_EVT || edl->rtype !=3D rtype) =
{

	     edl->rtype !=3D EDL_PATCH_CONFIG_CMD) {

[Sai] : I will update in next patch.


> +		bt_dev_err(hdev, "QCA Wrong packet received %d %d", edl->cresp,
> +			   edl->rtype);
> +		err =3D -EIO;
> +		goto out;
> +	}
> +
> +out:
> +	kfree(skb);
> +	if (err)
> +		bt_dev_err(hdev, "QCA Patch config cmd failed (%d)", err);
> +
> +	return err;
> +}
> +

Regards

Marcel