MIME-Version: 1.0
References: <20211216033453.9806-1-hj.tedd.an@gmail.com> <904d134a-a672-72a9-dddb-1c48d151e62e@molgen.mpg.de>
 <7bca0b8840cc1bab1c7ea7f25d8cca6ee41ecb04.camel@intel.com> <3ae32390-a8e5-9b65-6252-9e7f201bd08a@molgen.mpg.de>
In-Reply-To: <3ae32390-a8e5-9b65-6252-9e7f201bd08a@molgen.mpg.de>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 17 Dec 2021 11:27:23 -0800
Message-ID: <CABBYNZJSF6CEU+oJHeKtU5Z-pqL5rn_pO9CxaDwbuWeATBk-QA@mail.gmail.com>
Subject: Re: [RFC PATCH] Bluetooth: btintel: Fix broken LED quirk for legacy
 ROM device
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Tedd An <tedd.an@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Paul,

On Fri, Dec 17, 2021 at 7:33 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Tedd,
>
>
> Am 16.12.21 um 19:38 schrieb An, Tedd:
>
> > On Thu, 2021-12-16 at 08:52 +0100, Paul Menzel wrote:
>
> >> Am 16.12.21 um 04:34 schrieb Tedd Ho-Jeong An:
> >>> From: Tedd Ho-Jeong An <tedd.an@intel.com>
> >>>
> >>> This patch fix the broken LED quirk for Intel legacy ROM devices.
> >>
> >> fix*es*
> >>
> >> Excuse my ignorance, but what are Intel legacy ROM devices? Maybe also
> >> mention the IDs 0x0a2a and 0x0aa7 in the commit message?
> >>
> >>> Legacy device sends the SW RFKILL while shutting down the device (lik=
e
> >>> HCI interface down) to turn off the LED by putting the device in asse=
rt.
> >>>
> >>> Once the SW RFKILL is on, it needs the HCI_Reset to exit from the SW
> >>> RFKILL state. This patch checks the quirk and send the HCI_Reset befo=
re
> >>
> >> send*s*
> >>
> >>> sending the HCI_Intel_Read_Version command.
> >>
> >> Is that document in some datasheet/specification? If so, please mentio=
n it.
> >>
> >> Also, in the commit message summary you write =E2=80=9CFix=E2=80=9D. I=
f it fixes an old
> >> commit, please add a Fixes: tag.
> >>
> >>> Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> >>> ---
> >>>    drivers/bluetooth/btintel.c | 13 ++++++-------
> >>>    drivers/bluetooth/btusb.c   | 10 ++++++++--
> >>>    2 files changed, 14 insertions(+), 9 deletions(-)
> >>
> >> I have a Dell Latitude E7250 with the 8087:0a2a. How can I test this?
> >
> > Apply this patch on top of the bluetooth-next (or current mainline)
> > The BT interface should be available after reboot.
>
> On the laptop, I do not have any problems with missing BT interface
> after reboot with Linux 5.16-rc5. Are not all devices affected?

If the problem is fixed for you please confirm it by replying with a
Tested-by line.

--=20
Luiz Augusto von Dentz