MIME-Version: 1.0
References: <20211213212650.2067066-1-luiz.dentz@gmail.com>
 <61b7c408.1c69fb81.22a92.79f9@mx.google.com> <CABBYNZ+4CAg=4V7DHHws3J8T1LfVGJ8S91gCEgg-bQuSebkEAw@mail.gmail.com>
 <CAGPPCLAe0MbE3++O7Rdczc_M8C8jT038igiyr-Z40Z5MvcjqWQ@mail.gmail.com>
In-Reply-To: <CAGPPCLAe0MbE3++O7Rdczc_M8C8jT038igiyr-Z40Z5MvcjqWQ@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 20 Dec 2021 13:07:20 -0800
Message-ID: <CABBYNZJmv5-sLhz7sK_5ytZEfjz7oyq-MM1yB_iFu8c0r_3Z4A@mail.gmail.com>
Subject: Re: Bluetooth: mgmt: Fix mgmt_device_found panic
To:     Manish Mandlik <mmandlik@google.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Marcel,

On Fri, Dec 17, 2021 at 4:44 PM Manish Mandlik <mmandlik@google.com> wrote:
>
>
>
> On Fri, Dec 17, 2021 at 5:43 PM Luiz Augusto von Dentz <luiz.dentz@gmail.com> wrote:
>>
>> Hi Marcel,
>>
>> On Mon, Dec 13, 2021 at 2:07 PM <bluez.test.bot@gmail.com> wrote:
>> >
>> > This is automated email and please do not reply to this email!
>> >
>> > Dear submitter,
>> >
>> > Thank you for submitting the patches to the linux bluetooth mailing list.
>> > This is a CI test results with your patch series:
>> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=595033
>> >
>> > ---Test result---
>> >
>> > Test Summary:
>> > CheckPatch                    FAIL      1.63 seconds
>> > GitLint                       FAIL      0.92 seconds
>> > BuildKernel                   PASS      317.18 seconds
>> > Incremental Build with patchesPASS      321.54 seconds
>> > TestRunner: Setup             PASS      454.37 seconds
>> > TestRunner: l2cap-tester      PASS      11.79 seconds
>> > TestRunner: bnep-tester       PASS      5.89 seconds
>> > TestRunner: mgmt-tester       PASS      112.27 seconds
>> > TestRunner: rfcomm-tester     PASS      7.41 seconds
>> > TestRunner: sco-tester        PASS      7.54 seconds
>> > TestRunner: smp-tester        PASS      7.34 seconds
>> > TestRunner: userchan-tester   PASS      6.14 seconds
>> >
>> > Details
>> > ##############################
>> > Test: CheckPatch - FAIL - 1.63 seconds
>> > Run checkpatch.pl script with rule in .checkpatch.conf
>> > Bluetooth: mgmt: Fix mgmt_device_found panic\WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
>> > #103:
>> > FS:  0000000000000000(0000) GS:ffffffff8c097000(0000) knlGS:0000000000000000
>> >
>> > total: 0 errors, 1 warnings, 0 checks, 16 lines checked
>> >
>> > NOTE: For some of the reported defects, checkpatch may be able to
>> >       mechanically convert to the typical style using --fix or --fix-inplace.
>> >
>> > /github/workspace/src/12674615.patch has style problems, please review.
>> >
>> > NOTE: Ignored message types: UNKNOWN_COMMIT_ID
>> >
>> > NOTE: If any of the errors are false positives, please report
>> >       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>> >
>> >
>> > ##############################
>> > Test: GitLint - FAIL - 0.92 seconds
>> > Run gitlint with rule in .gitlint
>> > Bluetooth: mgmt: Fix mgmt_device_found panic
>> > 77: B1 Line exceeds max length (97>80): "Fixes: 2023db7e3a343 ("Bluetooth: mgmt: Make use of mgmt_send_event_skb in MGMT_EV_DEVICE_FOUND")"
>>
>> Can you please fixup/squash this one, this is breaking inquiry
>> response processing.
>>
>> --
>> Luiz Augusto von Dentz
>
>
> Tested-by: Manish Mandlik <mmandlik@google.com>

Ping, we really need to fix this up.

-- 
Luiz Augusto von Dentz