Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\))
Subject: Re: [PATCH v2] Bluetooth: hci_sync: Push sync command cancellation to
 workqueue
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20211217152809.671966-1-benjamin@sipsolutions.net>
Date:   Wed, 22 Dec 2021 09:39:17 +0100
Cc:     Oliver Neukum <oneukum@suse.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth <linux-bluetooth@vger.kernel.org>,
        syzbot <syzbot+485cc00ea7cf41dfdbf1@syzkaller.appspotmail.com>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Benjamin Berg <bberg@redhat.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <DC60AC06-E9BE-46BA-AB00-7AFF2248FBC7@holtmann.org>
References: <20211217152809.671966-1-benjamin@sipsolutions.net>
To:     Benjamin Berg <benjamin@sipsolutions.net>
Precedence: bulk

Hi Benjamin,

> syzbot reported that hci_cmd_sync_cancel may sleep from the wrong
> context. To avoid this, create a new work item that pushes the relevant
> parts into a different context.
> 
> Note that we keep the old implementation with the name
> __hci_cmd_sync_cancel as the sleeping behaviour is desired in some
> cases.
> 
> Reported-and-tested-by: syzbot+485cc00ea7cf41dfdbf1@syzkaller.appspotmail.com
> Fixes: c97a747efc93 ("Bluetooth: btusb: Cancel sync commands for certain URB errors")
> Signed-off-by: Benjamin Berg <bberg@redhat.com>
> 
> ---
> 
> v2:
> - Add Signed-off-by and changed email address
> ---
> include/net/bluetooth/hci_core.h |  1 +
> include/net/bluetooth/hci_sync.h |  1 +
> net/bluetooth/hci_core.c         |  2 +-
> net/bluetooth/hci_request.c      |  2 +-
> net/bluetooth/hci_sync.c         | 27 ++++++++++++++++++++++++++-
> 5 files changed, 30 insertions(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel