MIME-Version: 1.0
References: <20220107213216.3754372-1-luiz.dentz@gmail.com> <61d8c001.1c69fb81.24621.10e4@mx.google.com>
In-Reply-To: <61d8c001.1c69fb81.24621.10e4@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 7 Jan 2022 14:47:52 -0800
Message-ID: <CABBYNZL5hh7+4B_2C4KsKZF-bd041CSSqK6MqPcc7BMCVKuBMA@mail.gmail.com>
Subject: Re: [BlueZ] avdtp: Fix runtime errors passing NULL to memcpy
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Fri, Jan 7, 2022 at 2:34 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=3D603=
674
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    PASS      1.65 seconds
> GitLint                       PASS      0.99 seconds
> Prep - Setup ELL              PASS      42.29 seconds
> Build - Prep                  PASS      0.74 seconds
> Build - Configure             PASS      8.38 seconds
> Build - Make                  FAIL      1256.13 seconds
> Make Check                    FAIL      3.67 seconds
> Make Check w/Valgrind         FAIL      261.62 seconds
> Make Distcheck                FAIL      158.23 seconds
> Build w/ext ELL - Configure   PASS      8.46 seconds
> Build w/ext ELL - Make        FAIL      1230.37 seconds
> Incremental Build with patchesPASS      0.00 seconds
>
> Details
> ##############################
> Test: Build - Make - FAIL
> Desc: Build the BlueZ source tree
> Output:
> tools/mgmt-tester.c: In function =E2=80=98main=E2=80=99:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded =
with =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avdtp.c: In function =E2=80=98main=E2=80=99:
> unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with=
 =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
>   766 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avrcp.c: In function =E2=80=98main=E2=80=99:
> unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with=
 =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
>   989 | int main(int argc, char *argv[])
>       |     ^~~~
> profiles/audio/avdtp.c: In function =E2=80=98send_request=E2=80=99:
> profiles/audio/avdtp.c:2710:14: error: implicit declaration of function =
=E2=80=98util_memdup=E2=80=99; did you mean =E2=80=98util_hexdump=E2=80=99?=
 [-Werror=3Dimplicit-function-declaration]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |              ^~~~~~~~~~~
>       |              util_hexdump
> profiles/audio/avdtp.c:2710:12: error: assignment to =E2=80=98void *=E2=
=80=99 from =E2=80=98int=E2=80=99 makes pointer from integer without a cast=
 [-Werror=3Dint-conversion]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |            ^
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:9445: profiles/audio/bluetoothd-avdtp.o] Error 1
> make: *** [Makefile:4302: all] Error 2
>
>
> ##############################
> Test: Make Check - FAIL
> Desc: Run 'make check'
> Output:
> profiles/audio/avdtp.c: In function =E2=80=98send_request=E2=80=99:
> profiles/audio/avdtp.c:2710:14: error: implicit declaration of function =
=E2=80=98util_memdup=E2=80=99; did you mean =E2=80=98util_hexdump=E2=80=99?=
 [-Werror=3Dimplicit-function-declaration]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |              ^~~~~~~~~~~
>       |              util_hexdump
> profiles/audio/avdtp.c:2710:12: error: assignment to =E2=80=98void *=E2=
=80=99 from =E2=80=98int=E2=80=99 makes pointer from integer without a cast=
 [-Werror=3Dint-conversion]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |            ^
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:9445: profiles/audio/bluetoothd-avdtp.o] Error 1
> make: *** [Makefile:11306: check] Error 2
>
>
> ##############################
> Test: Make Check w/Valgrind - FAIL
> Desc: Run 'make check' with Valgrind
> Output:
> tools/mgmt-tester.c: In function =E2=80=98main=E2=80=99:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded =
with =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> profiles/audio/avdtp.c: In function =E2=80=98send_request=E2=80=99:
> profiles/audio/avdtp.c:2710:14: error: implicit declaration of function =
=E2=80=98util_memdup=E2=80=99; did you mean =E2=80=98util_hexdump=E2=80=99?=
 [-Werror=3Dimplicit-function-declaration]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |              ^~~~~~~~~~~
>       |              util_hexdump
> profiles/audio/avdtp.c:2710:12: error: assignment to =E2=80=98void *=E2=
=80=99 from =E2=80=98int=E2=80=99 makes pointer from integer without a cast=
 [-Werror=3Dint-conversion]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |            ^
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:9445: profiles/audio/bluetoothd-avdtp.o] Error 1
> make: *** [Makefile:4302: all] Error 2
>
>
> ##############################
> Test: Make Distcheck - FAIL
> Desc: Run distcheck to check the distribution
> Output:
> ../../profiles/audio/avdtp.c: In function =E2=80=98send_request=E2=80=99:
> ../../profiles/audio/avdtp.c:2710:14: warning: implicit declaration of fu=
nction =E2=80=98util_memdup=E2=80=99; did you mean =E2=80=98util_hexdump=E2=
=80=99? [-Wimplicit-function-declaration]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |              ^~~~~~~~~~~
>       |              util_hexdump
> ../../profiles/audio/avdtp.c:2710:12: warning: assignment to =E2=80=98voi=
d *=E2=80=99 from =E2=80=98int=E2=80=99 makes pointer from integer without =
a cast [-Wint-conversion]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |            ^
> /usr/bin/ld: profiles/audio/bluetoothd-avdtp.o: in function `send_request=
':
> /github/workspace/src/bluez-5.62/_build/sub/../../profiles/audio/avdtp.c:=
2710: undefined reference to `util_memdup'
> collect2: error: ld returned 1 exit status
> make[2]: *** [Makefile:5877: src/bluetoothd] Error 1
> make[1]: *** [Makefile:4302: all] Error 2
> make: *** [Makefile:11227: distcheck] Error 1
>
>
> ##############################
> Test: Build w/ext ELL - Make - FAIL
> Desc: Build BlueZ source with '--enable-external-ell' configuration
> Output:
> tools/mgmt-tester.c: In function =E2=80=98main=E2=80=99:
> tools/mgmt-tester.c:12364:5: note: variable tracking size limit exceeded =
with =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
> 12364 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avdtp.c: In function =E2=80=98main=E2=80=99:
> unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with=
 =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
>   766 | int main(int argc, char *argv[])
>       |     ^~~~
> unit/test-avrcp.c: In function =E2=80=98main=E2=80=99:
> unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with=
 =E2=80=98-fvar-tracking-assignments=E2=80=99, retrying without
>   989 | int main(int argc, char *argv[])
>       |     ^~~~
> profiles/audio/avdtp.c: In function =E2=80=98send_request=E2=80=99:
> profiles/audio/avdtp.c:2710:14: error: implicit declaration of function =
=E2=80=98util_memdup=E2=80=99; did you mean =E2=80=98util_hexdump=E2=80=99?=
 [-Werror=3Dimplicit-function-declaration]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |              ^~~~~~~~~~~
>       |              util_hexdump
> profiles/audio/avdtp.c:2710:12: error: assignment to =E2=80=98void *=E2=
=80=99 from =E2=80=98int=E2=80=99 makes pointer from integer without a cast=
 [-Werror=3Dint-conversion]
>  2710 |  req->data =3D util_memdup(buffer, size);
>       |            ^
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:9445: profiles/audio/bluetoothd-avdtp.o] Error 1
> make: *** [Makefile:4302: all] Error 2
>
>
>
>
> ---
> Regards,
> Linux Bluetooth

Pushed.

--=20
Luiz Augusto von Dentz