Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3057998pxb; Mon, 24 Jan 2022 01:12:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJwX+XI0uPEriO1ltCzDBBpKHGacSSMQ8Lw5p9yD4Yiy6bsmWBjEoifsYit+Kcp6npVPMDvo X-Received: by 2002:a63:b504:: with SMTP id y4mr11202380pge.354.1643015544795; Mon, 24 Jan 2022 01:12:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643015544; cv=none; d=google.com; s=arc-20160816; b=rV7upJrnedD2iG2zGPJE+EzXS6Wjrc3mYCCS3Lp3JpiBTWgIUtzRaBJ0b4ctdbRjOJ tuA4Dgf+G/W62MV4vusdKDWiZzRi8/1ZUoYasJjXriNOXC0zN+Zexd6mlYGT+aUoci8/ z+VzSiaezONNHD8k9f0rxlOo6gbZG1rMYDCsIMqutl+WEliM98lJtTPxTbTwFZSsiXeX ivBadGAMEQRZ4FntBfkP8av0dywJ5RZk5E4QyAA5u3ahqGfQN3qVBI9tTxJ4G9uPwPGw EfP6ggdGKUdTBSWl1AYCeiD6ZGCF7EKFdqzcnnZL5SNJLMCq4vuAuu2MPMTQ6jkStnH+ +AMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=TSaCZRqtYcL5J/24M0ahMncAxm4zC6R+Quk4O7W7qgs=; b=InHsSHzKvF+IydUsUabK2YwlpAaDd/plX0E5gmFYbrdux5rYz5SAjpbKNOWH8VGi2+ y1HjoTHydH9zyoZw6wvBsvcO2ZsjcVW5U5HX+SOjcRLlH3M317k2Fh+qclzZDTW84Nbd PFQReEcLCPi9lQbTSOgkj/2ohNtiF043xjbnWS2siYnGZguTuqxyn50caIkGSi8mbX2w 4PatEhhEi8v0CmPmYV1K9tE00Wgnudkf7l7v+PPwWUs7ThEovEwT5evLbxtO1XkpggiL uo+SZpsCM+kAkYhGUYts8m784M0RC5f/5aDntxNcm1nTenpyo4Os/D3fc69sbvOdw/Rh Zq5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v7si13713044plp.523.2022.01.24.01.12.11; Mon, 24 Jan 2022 01:12:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236746AbiAWOav (ORCPT + 99 others); Sun, 23 Jan 2022 09:30:51 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:60493 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236742AbiAWOav (ORCPT ); Sun, 23 Jan 2022 09:30:51 -0500 Received: from smtpclient.apple (p4fefca45.dip0.t-ipconnect.de [79.239.202.69]) by mail.holtmann.org (Postfix) with ESMTPSA id 2ED49CED41; Sun, 23 Jan 2022 15:30:49 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: [PATCH v2] Bluetooth: msft: fix null pointer deref on msft_monitor_device_evt From: Marcel Holtmann In-Reply-To: <20220123055709.7925-1-soenke.huster@eknoes.de> Date: Sun, 23 Jan 2022 15:30:48 +0100 Cc: Johan Hedberg , Luiz Augusto von Dentz , "David S. Miller" , Jakub Kicinski , BlueZ , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <6455AE62-B472-41E2-8B32-FFF350EF3250@holtmann.org> References: <20220123055709.7925-1-soenke.huster@eknoes.de> To: Soenke Huster X-Mailer: Apple Mail (2.3693.40.0.1.81) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Soenke, > msft_find_handle_data returns NULL if it can't find the handle. > Therefore, handle_data must be checked, otherwise a null pointer > is dereferenced. > > Signed-off-by: Soenke Huster > --- > v2: Remove empty line > > net/bluetooth/msft.c | 2 ++ > 1 file changed, 2 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel