Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp3591383pxb; Fri, 4 Feb 2022 11:51:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFSF2Xy6TjS8dBsMKIIqDNc7gk+7+AuSGBjgchb8agvYtDRjIB5XKLWo9LnqrPfOcWXAIb X-Received: by 2002:a17:902:7287:: with SMTP id d7mr4925714pll.0.1644004291493; Fri, 04 Feb 2022 11:51:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644004291; cv=none; d=google.com; s=arc-20160816; b=OLKyaHENRyJ7sf4TJnXX7MbgmzCk5Wfs58MQlPhhzrj1SW/1PjXJvcSY8IW7kzPPqx C0USLVgFlBlF0yyQtZ/e6bCc+yaFp6Gj+L3nHzX+ZPK9mT/lkiTCLMQoe63toG83zWo5 hbchfjlWFAjhnHp9awa5hGPuUHjc3F++ovqx8AKAf+n1Y3VOrxFPOzFGx5ZnEOv+nYL+ QNiqYi3MgYYHU9DCqrwTc1Bf+gK7lroFCczCoyp55K8HdyEnMsFtyRLyUFAPUvA77nwu D4IYfYNiWsVFRNCl2d0Y/0Tu7L1IibR62xbSGIGQ1aFmwDQeDI7mWyM+2Kd18Dc+wr/e 09EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ESTmxUioHjdyhMilETVAh1WJAaSVTxysha5yciTah90=; b=tOh72ThQ0FoDg8jThY/VCGWOv1PJG6vhPFxpf2fmPCEMpAEVaEThVeUHh7JSvjusyj PPwU/lGiLuFMZDKuAu31KEz8WljyqoVvBcYw6amdP5YT9DTCdV/XJA7lA2q9djadBsiC 9P+e+djLqxM3S+69+zqM0XgkGg5a3X8xwEBP2gxct0hgZkGqBp4EXaL9SuqPni1OdpAV iEt1axe2nQ8qGNUDwN1YA+d5zd+S5Kvx6ByUkCRp3Bpgomxf4aeU0OYXVnhecB5vV3Dt HDq/ISO5IAHdDFOldo2qVMpuJAJgmuQGoh0OcjijKoXkaQiT/Y2sILRDkXqGfVefpfgZ Jveg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=etXgFFNn; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u71si2687051pgd.304.2022.02.04.11.51.06; Fri, 04 Feb 2022 11:51:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=etXgFFNn; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348706AbiBCXK0 (ORCPT + 99 others); Thu, 3 Feb 2022 18:10:26 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:41792 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233999AbiBCXK0 (ORCPT ); Thu, 3 Feb 2022 18:10:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F2859B835E8; Thu, 3 Feb 2022 23:10:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2279DC340E8; Thu, 3 Feb 2022 23:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643929823; bh=9nlI9+KCIgp6rqiYYJPe3fzW1xxTvg1lpzDst24Ejr0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=etXgFFNnWHK+YXX0jgh/G1dt7rJ5d/E/XSCeAILkSM18nCQkuc26QdQBIC42/lZNO 90S6cgV1VugLyPvDy4qWuj8ghnCH/mQa4w1JXsUdidsrj1kLWrH98XoIsbuPSbQPwF lfpuz9etAaS5EqT4OA/5+bIUMC1yRhgQOE49B+187ZeC3bepBHYQFB6y4s8+MDFmG5 hn5Ryg6V6x04IELZ+GxUwyyvYkOnVvAEcGMNVB60YF9OuXQGmdDOFsKU153dx7YBuC Eyi0bUuxkraIvNiG9CriEK8gztU4il5I+xRF4iAJFYsYV6LetYUs5sN8C33uxnRU6/ 8bTIm4HQBosHQ== Date: Thu, 3 Feb 2022 15:10:21 -0800 From: Jakub Kicinski To: David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, oliver@neukum.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, stefan@datenfreihafen.org, jk@codeconstruct.com.au, matt@codeconstruct.com.au, linux-usb@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org Subject: Re: [PATCH net-next] net: don't include ndisc.h from ipv6.h Message-ID: <20220203151021.6a276271@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20220203043457.2222388-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Thu, 3 Feb 2022 15:48:28 -0700 David Ahern wrote: > > --- a/include/net/ndisc.h > > +++ b/include/net/ndisc.h > > @@ -71,7 +71,6 @@ do { \ > > > > struct ctl_table; > > struct inet6_dev; > > -struct net_device; > > ndisc_parse_options references net_device. This part seems unrelated to > the patch intent. Indeed, I'll post v2 with this fixed. The reason was this header includes linux/netdevice.h so the forward declaration is unnecessary.