Received-SPF: softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
Subject: Re: [BlueZ PATCH v3 9/9] monitor: print quality report cmd
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20220209092414.751642-7-josephsih@chromium.org>
Date:   Wed, 9 Feb 2022 22:09:07 +0100
Cc:     linux-bluetooth@vger.kernel.org,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        pali@kernel.org, chromeos-bluetooth-upstreaming@chromium.org,
        josephsih@google.com
Content-Transfer-Encoding: 8BIT
Message-Id: <289435E7-4B3D-415C-B13A-AF31D1BF87E8@holtmann.org>
References: <20220209092414.751642-1-josephsih@chromium.org>
 <20220209092414.751642-7-josephsih@chromium.org>
To:     Joseph Hwang <josephsih@chromium.org>
Precedence: bulk

Hi Joseph,

> This patch prints the set quality command properly.
> 
> Signed-off-by: Joseph Hwang <josephsih@chromium.org>
> ---
> 
> Changes in v3:
> - This is a new patch that prints the set quality command.
> 
> monitor/packet.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 397000644..4dce2f681 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -12011,6 +12011,7 @@ static const struct bitfield_data mgmt_settings_table[] = {
> 	{ 15, "Static Address"		},
> 	{ 16, "PHY Configuration"	},
> 	{ 17, "Wideband Speech"		},
> +	{ 18, "Quality Report"		},
> 	{ }
> };
> 
> @@ -13607,6 +13608,13 @@ static void mgmt_remove_adv_monitor_patterns_rsp(const void *data,
> 	print_field("Handle: %d", handle);
> }
> 
> +static void mgmt_set_quality_report_cmd(const void *data, uint16_t size)
> +{
> +	uint8_t action = *(uint8_t *)data;

please use get_u8(data).

> +
> +	print_field("Set Quality Report %u", action);
> +}
> +
> struct mgmt_data {
> 	uint16_t opcode;
> 	const char *str;
> @@ -13864,6 +13872,9 @@ static const struct mgmt_data mgmt_command_table[] = {
> 				mgmt_add_adv_monitor_patterns_rssi_cmd, 8,
> 									false,
> 				mgmt_add_adv_monitor_patterns_rsp, 2, true},
> +	{ 0x0057, "Set Quality Report",
> +				mgmt_set_quality_report_cmd, 1, true,
> +				mgmt_null_rsp, 0, true },
> 	{ }
> };

We also have a few mgmt commands that miss decodes. If you have bandwidth, feel free to add these as well.

And we should have them also added to btmon --todo.

Regards

Marcel