Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@quicinc.com>
To:     "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "Sai Teja Aluvala (Temp) (QUIC)" <quic_saluvala@quicinc.com>
CC:     "marcel@holtmann.org" <marcel@holtmann.org>,
        "johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
        "mka@chromium.org" <mka@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Hemant Gupta (QUIC)" <quic_hemantg@quicinc.com>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        quic_bgodavar <quic_bgodavar@quicinc.com>,
        quic_rjliao <quic_rjliao@quicinc.com>,
        quic_hbandi <quic_hbandi@quicinc.com>,
        "abhishekpandit@chromium.org" <abhishekpandit@chromium.org>,
        "mcchou@chromium.org" <mcchou@chromium.org>
Subject: RE: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for
 Bluetooth node on CRD
Thread-Topic: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply
 for Bluetooth node on CRD
Thread-Index: AQHYHN0JCTQRi4S5dky48gKpz7KY6ayNheAAgADcoxA=
Date:   Fri, 11 Feb 2022 13:49:02 +0000
Message-ID: <SN4PR0201MB8725606835F55D90A4F50FDAE3309@SN4PR0201MB8725.namprd02.prod.outlook.com>
References: <1644318803-14950-1-git-send-email-quic_saluvala@quicinc.com>
 <YgWwNiLDCZ0jEV30@builder.lan>
In-Reply-To: <YgWwNiLDCZ0jEV30@builder.lan>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 470cc0bc-0406-4615-d86d-08d9ed65431e
x-ms-traffictypediagnostic: CY4PR02MB2453:EE_
x-ld-processed: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d,ExtAddr
x-microsoft-antispam-prvs: <CY4PR02MB2453F006D5BA1E7D1C385E4C9F309@CY4PR02MB2453.namprd02.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:4941;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 2TnY2JsVoaKfiUJkgxCGXP/Db0aMwEBO8mnTiw0aHIki0xyEx5AN4I5EX2XnsB8KKgC+p8shzeAcjtIij4E8sNozA4/kaVUrpBSxHBTcRQP5RjH2pWWrzHsaHsbbgEawX2FmWzXvgn/kBjxEi4L2plCw1ggq+qUbbza8mYPvy9xCg4Uy/zANCkT2jqW6OOqiGzYUP1bllnL9yOmlEiwX5QZEjpAVdwSthZZVwfs8YWDjGYmnrpDoh0VniFygT1s5p3wq1xkZN2OfiKZ88gg31AGa6kqggzy2pFk6MxpPWxgB05xz9TZJIe6WtSpdBVmWPsjaiqPZHsDSI5SmztDQAVtXdVrp548VAxI5UVYDsEgOAwClFln6jJg2N3wZdxZVSFZBUla08v580zVWQRGAmzHSoZQu1L1HocpCPAycPdFsXOZlbP7aYR28y2At4daNlH39awbCw6iRC8nFXA+QVvMQU+MMNlTIsAuQe8gms5fdpDimcs2BLiMsEgYZkPbmiYsPDQ5Pxse9TOFh8OC0ZFqHSCcU3gJKT+LhVAi0J9NZ4T9XZUq8DOLTUekObED5mtyFtx6MhNQO84zkgaEdzYQmMd1UxkhY05fwGeYnI8Pz9/qzDjf4YWGF53bxXBZxkgNCcw0vW3PBY9FfE1piYKuiU+u5uNm03pGnM2ixd6Q6ztdok1CmWekxGGvPp44QA2EFL7mFN9KXtfYG/w+Rqg==
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR0201MB8725.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7696005)(8676002)(64756008)(9686003)(5660300002)(4326008)(66446008)(6506007)(52536014)(53546011)(71200400001)(54906003)(508600001)(8936002)(55016003)(110136005)(38070700005)(86362001)(33656002)(122000001)(26005)(186003)(38100700002)(83380400001)(76116006)(66946007)(66476007)(2906002)(316002)(66556008);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LbQvVMlbKLx6uB9HUk+fldlR1VBY+jN0ZG8+VdBUNU0uPnj0rOCiFmPfCgaV?=
 =?us-ascii?Q?zmpj2jIvQRE0bzTInl35NggBW0FVzCuMCxLynWo3WeqkhgJZ4RHljJ7QBnpT?=
 =?us-ascii?Q?ayyyKrOC3C92ePS/muMsxV7aQ1OwN5IorpSPAt+iU5jN/xjEoBryOK55wQOk?=
 =?us-ascii?Q?I/8xTsNs7Cezp5e9/EngprQ3Y+QOpzO3HM2fS7b4+tempgyH7QlBP0D0ub4d?=
 =?us-ascii?Q?PFGyzJ5DF55OCUvjRF+RK6hKvnnOlDbAIaheepovGrCE1iLCYm8+agUSz2Sp?=
 =?us-ascii?Q?wi2Eu1cEdh+PLDi/aslyu46XF5zIDwE2cRxAtyZ9l8DAQai5+gQceDB+z+jU?=
 =?us-ascii?Q?1FqsXpHNefURysoj9CJ79UbxcY0WWwyCcTeToKeUzgdNr1h6aL0cGZn/s05s?=
 =?us-ascii?Q?4ZSmPySheE/K5UH9ORC0DS2gLLS2lEWJz08O96DVN/FpUuua54iQ35dKU11K?=
 =?us-ascii?Q?71/1PnYBkb5VbMpN5xSpBPRJ7g5cFAg7gDUqzchqr1I7h2ieWBHZk9+F5+6n?=
 =?us-ascii?Q?cbh6v6DZE45E65jJ7Vljd3L0Rv6QRchzE1cmMMEXMhPOmKkau8fohyC4NPu5?=
 =?us-ascii?Q?gozaJe9ikgFQ8fN6J64pzVmiXww17H9XQ0JNYN6oUV9A48mqG/XqhqxsVL3U?=
 =?us-ascii?Q?rDcHFBk/AOOQALQeCsovRus0K2p4jLiwhD8ad0YDVmf/+k4C/NO5ish6LmnG?=
 =?us-ascii?Q?W+rMT+sZxDlnA/6FouXQOMt1VNejEqCiLrtxTjgbJCNw+hBx8qE6CNuiKzkg?=
 =?us-ascii?Q?QZ+3Rz7nZrHd2mEKq8J6aqjbm5zWaIm4lFB0EZ+eoDD/2C0Jj5DFO6/FLV0B?=
 =?us-ascii?Q?WNXPZyZIXEp6oYHwJBnoTzMAGyVpgIpF53LC4C/zQC0cPugmkT1ikOOvR8HG?=
 =?us-ascii?Q?52SRPzPx7bwaQZaej34o7KJahR0FRiSLSyd7O+jpvKsHJihMlenoos6v8b3u?=
 =?us-ascii?Q?PBc1DIrwafo1Xdji9MZSzHckn7HuEyL8kgisx5+G1C5klyKepW6fKJccb4gP?=
 =?us-ascii?Q?Beqk0E5xFGwqRmiGFEUYFKeMX/GeMky5dwQPYT3FsmNtoaNejRtZIIq4cOlJ?=
 =?us-ascii?Q?7Vtwy2yNYfjKz79f/HsnqBa3SsGcKPKIbsuBRadigBTVq8a/Xqb22ISuFL4g?=
 =?us-ascii?Q?59g4/IdJ/5umrNFBt61AXqorT6uepgGM35/ny0L9gW1XvDeCRrl22M5lbtlr?=
 =?us-ascii?Q?fVXjRbGmK9DfLmwi7WSMz1Gw+7Qa5YLHaOZyxr5CNzMgKXwkvKGGNvEMad5v?=
 =?us-ascii?Q?JJaxjlaHHxlnVaXXZisRAvzvDEphurpE8uAtniN3Z3WBdqFP0PzNXZTiX7GT?=
 =?us-ascii?Q?fzpOHEt2mKZYF+t5b/a2dG7ENZOtuTstNxrP5NitHzi2mBfoyG+sXlW82yye?=
 =?us-ascii?Q?rbU8fd/rV9bmi48+EV+g4zdRzkUwRepelc3HaDHek9XHkp6z97zKxP24MxU2?=
 =?us-ascii?Q?HgxdnOCNHdAZ/b0g/Q6E6ySYOKgq63OF/pkeNuGSfE8DqhY/XWRXlpXEbtwj?=
 =?us-ascii?Q?RbH/ZFIKRudrt//h7hyg5/owvMVE0hFSEc8Yu6Rz78wWOL1gbOO+N7CJZF5o?=
 =?us-ascii?Q?/s3ELU6u+aVU/d+OC2m7ztJrlD+bE8At6EFKPPCTMB00AS5yc0MjpdYlgEd8?=
 =?us-ascii?Q?ql5x77FYMcsERwAkkoeJAQmyAh6JynocnGPWCgC8081N4NUqIaeBapbpKeX1?=
 =?us-ascii?Q?J4QJ6w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0201MB8725.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 470cc0bc-0406-4615-d86d-08d9ed65431e
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2022 13:49:02.1804
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dtA30nX+9xwy/kLzu5CpT8c4Wd7FLKIjyuVJr66ABB3E011fykjzI3VGEIPAGAlAk4EJZnd5/O+IEcVzNsIUpb12Ylbk/8IrJoi2STr1aec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2453
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org


-----Original Message-----
From: Bjorn Andersson <bjorn.andersson@linaro.org>=20
Sent: Friday, February 11, 2022 6:09 AM
To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com>
Cc: marcel@holtmann.org; johan.hedberg@gmail.com; mka@chromium.org; linux-k=
ernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC)=
 <quic_hemantg@quicinc.com>; linux-arm-msm@vger.kernel.org; quic_bgodavar <=
quic_bgodavar@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; quic_hba=
ndi <quic_hbandi@quicinc.com>; abhishekpandit@chromium.org; mcchou@chromium=
.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply =
for Bluetooth node on CRD

On Tue 08 Feb 05:13 CST 2022, Sai Teja Aluvala wrote:

> setting the vddio supply for Bluetooth SoC WCN6750 node on SC7280 crd=20
> board
>=20

While this does better describe what the change does, as Matthias requested=
 on v1, it fails to provide any information about why this done.

Is vddio simply not powered on the IDP? Or did someone forget to add it to =
the idp.dtsi?
[Sai]: Vddio regulator handle is different for IDP and IDP2. So in common d=
tsi file i.e. sc7280-idp.dtsi we haven't enabled vddio instead we have add =
the regulator handle in board specific dts file.
So for CRD too we are adding it in the sc7280-crd.dts file.


Regards,
Bjorn

> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts=20
> b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index cd2755c..53ea3b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,10 @@
>  	};
>  };
> =20
> +&bluetooth {
> +	vddio-supply =3D <&vreg_l18b_1p8>;
> +};
> +
>  ap_tp_i2c: &i2c0 {
>  	status =3D "okay";
>  	clock-frequency =3D <400000>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
>=20