Received-SPF: softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220212084541.221196-1-daniel.trnka@gmail.com>
In-Reply-To: <20220212084541.221196-1-daniel.trnka@gmail.com>
From:   Sonny Sasaka <sonnysasaka@chromium.org>
Date:   Mon, 14 Feb 2022 10:58:52 -0800
Message-ID: <CAO271mn+kd08LkTsByqqGt6EuvJpEdNpRHZsK2eVZg0so_KmQA@mail.gmail.com>
Subject: Re: [PATCH BlueZ] adapter: battery provider for non-LE controllers
To:     Daniel Trnka <daniel.trnka@gmail.com>
Cc:     BlueZ <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>

On Sat, Feb 12, 2022 at 12:48 AM Daniel Trnka <daniel.trnka@gmail.com> wrote:
>
> Enable battery provider dbus interface BatteryProviderManager1 for
> non-LE controllers, so external clients like pipewire can provide
> battery information for bluetooth headsets on non-LE controllers.
> ---
>  src/adapter.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index eef50f67a..2071cf8db 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -8976,6 +8976,11 @@ static int adapter_register(struct btd_adapter *adapter)
>                 agent_unref(agent);
>         }
>
> +       if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
> +               adapter->battery_provider_manager =
> +                       btd_battery_provider_manager_create(adapter);
> +       }
> +
>         /* Don't start GATT database and advertising managers on
>          * non-LE controllers.
>          */
> @@ -9010,11 +9015,6 @@ static int adapter_register(struct btd_adapter *adapter)
>                 }
>         }
>
> -       if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
> -               adapter->battery_provider_manager =
> -                       btd_battery_provider_manager_create(adapter);
> -       }
> -
>         db = btd_gatt_database_get_db(adapter->database);
>         adapter->db_id = gatt_db_register(db, services_modified,
>                                                         services_modified,
> --
> 2.35.1
>