Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp363774pxb; Tue, 15 Feb 2022 15:30:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJwp3lr8hqmyYc/DOTPHKmHepXpEuFpUSY9w7nX2Xm5zt7A5CAl5aHayNMqHIM+EnbaX04ag X-Received: by 2002:a17:906:360a:b0:6b9:1f8:9cdd with SMTP id q10-20020a170906360a00b006b901f89cddmr214960ejb.461.1644967806868; Tue, 15 Feb 2022 15:30:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644967806; cv=none; d=google.com; s=arc-20160816; b=zir25zETBBl5RtcTssZP3J7Ex/H8nCbnena3jRon+YKfPZ96Fc9aYvBxPAunEV8agx YJ3EFDx5bZOqOlEdCQarksZhPuWKaBoF6iJjJKfgupmCqIsZtXkVZlEFvh0c3QqTXOVI MKxQAQ3Oz1ZsM9TFn7GasfVFGdLKFe9sgxtr6HIMzsm4qlDUTo2WofXxisXb1n9McxUb EmHIyTNz29Onazz2Ym9Zqe0hl1LSlWaRq0JHxsOOc+R4BhfBtn4SSgA6YIEgP3pxblQk xJ58YBOh0GQSSdLOEjVli5CXgaGuhuhT7Za6CE4XcICZmay95TWkDd5p1Vrs86REkNhP AwDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=mexl3os4BQqYiQV1Two8gyEZOIW76cOBbYjh80oXZRc=; b=Cm6x5pUPj2KApewMXGKObfhUrDN4P059TArGC67P32wS+R7ih5AkTKg3XjDKNChrvK o0raDwTEp5QQoakSI5XEF0lxfZSJ0Qo61OdiPDQrLgkxW+K+8jd1swEmDYOcwaJ34gtE LpMXDkxH2hnY5MMqTdS7YxHlJSQy+wG9w1K2Rm3b3dVTuuaULF7CHZlifDncnIPPlKX4 l1klS9ZmsdC3rauJMk7h/cZihZzfY6PHwpAvtbO1p32Ye0wkIo8MT7bLUVUYHefKDY0w OhfXJRMzWiW6QsM+S14P6BNwKa4NkxXfvMSIebL0SbfABntKqsCF1YYiphq2GQ7+tUik OgZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XuFSQmRr; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 13si19877641ejk.406.2022.02.15.15.29.07; Tue, 15 Feb 2022 15:30:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XuFSQmRr; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235362AbiBOVvY (ORCPT + 99 others); Tue, 15 Feb 2022 16:51:24 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234664AbiBOVvX (ORCPT ); Tue, 15 Feb 2022 16:51:23 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31BC2D5F72; Tue, 15 Feb 2022 13:51:13 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id m7so502396pjk.0; Tue, 15 Feb 2022 13:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mexl3os4BQqYiQV1Two8gyEZOIW76cOBbYjh80oXZRc=; b=XuFSQmRrVV5aRBEPyP3BEPRjdy/3JQIe2BH9WIOfwaBRne8yld3renrqxEmMJh+ElN vH1LuvUiyeSSIUfg2W//ST8J55qFhQIpj8nfzUVCjxjudsKcWDIE57FIepm0C+nSuupX Sk7ADm8lFFtdQr54NfN2GZWNhRP4JD9eWnu2B81UbaykpWelj6gFC00T9Nby2fjW1x6P yfdP8nvNXP1HstDUZ4vuQ6agbv38e2JApSEs6Ke/UwX0aKKn9lAUSCXUlX1sta3KSz4Q /yj05EqV+MOM5OCXL51GHne6DBtDWb6/LdIj8NQ9rm7FLV/HixV+41W3yHIgSICVXDsU lXcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mexl3os4BQqYiQV1Two8gyEZOIW76cOBbYjh80oXZRc=; b=g9cU6rgy6MIUOu6UwbVjgUu4JQdjUJF4zDJDkVQKcgwRikvlhr/VXY02tcnX+RQwMQ DQD1Mc9YQR2MTtXtT2+gjvxCG8F46ZsFM+qauUwtZY5F++6HdhUuyqw3f6tfHCuEXg5V wQE6e2XYO4ElWl46B/PokDV5mqiIbtZOamAccDJbib47HnE6b+O0lNwxbsY0GHG57Z+Y lZw340kEji4pb2uuuuSFsPWYCM8tnNNPdI0P9OQkeKQiF570VLJEJIrujXT10W1hivcp FEMW+/L+BLjL6USSGffG15K6Ua9VajLJB1nHIRawzvzwbrg6Xl63t4O6kUTDACldnGZs OzLg== X-Gm-Message-State: AOAM530LGeLh6Wh6WrggSmQvaRyRuRMnkqm3fIJ1NqdEMEM6DPnp5s2P LxkaSuvZcTvYSpKJOkcaja4= X-Received: by 2002:a17:90b:3e85:: with SMTP id rj5mr946051pjb.65.1644961872676; Tue, 15 Feb 2022 13:51:12 -0800 (PST) Received: from [192.168.86.21] (c-73-241-150-58.hsd1.ca.comcast.net. [73.241.150.58]) by smtp.gmail.com with ESMTPSA id e4sm2230484pgr.35.2022.02.15.13.51.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 13:51:12 -0800 (PST) Message-ID: <8cb46dd1-c2eb-869a-0af8-443d84a83b85@gmail.com> Date: Tue, 15 Feb 2022 13:51:10 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: 4 missing check bugs Content-Language: en-US To: Jinmeng Zhou , marcel@holtmann.org, johan.hedberg@gmail.com, davem@davemloft.net, Jakub Kicinski Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, shenwenbosmile@gmail.com References: From: Eric Dumazet In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On 2/15/22 04:37, Jinmeng Zhou wrote: > Dear maintainers, > > Hi, our tool finds several missing check bugs on > Linux kernel v4.18.5 using static analysis. > We are looking forward to having more experts' eyes on this. Thank you! > > Before calling sk_alloc() with SOCK_RAW type, > there should be a permission check, ns_capable(ns,CAP_NET_RAW). > For example, v4.18 is not a stable kernel. No one is supposed to use v4.18.5, and expect others to fix bugs in it.