Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp702390pxb; Wed, 16 Feb 2022 02:27:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJy6c8WWAG4O/Afo+o2KfJ+5VyKpPzATLAXcNTJCuXYb4s20l5lupAjZG+pmmo9LdUndq173 X-Received: by 2002:a17:90b:3e8c:b0:1b9:58f2:e0e5 with SMTP id rj12-20020a17090b3e8c00b001b958f2e0e5mr904364pjb.85.1645007228580; Wed, 16 Feb 2022 02:27:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645007228; cv=none; d=google.com; s=arc-20160816; b=ZOFBWHgu4vsWzxw30p/bzMBQBOIlTO1DhObooy9YKlTCyV7IwqH4GzjQYkd23V1ymb tCA273fZiuJOLugHn44FUkdf/Cyq30exOWAXQpQhfILAs4aKrguyODbuvL+UOjyk+//N cS161kZTqdJzEvgCx6i5qsHsRKxSV6zDGrxvonPvgN8RAn63hHDjHeQelBweXTGoqPEu gKFmemUJ7WhwSenqd1CBdIRiWH8taIicI8Sy3vvgWpTgBBgNTRVLlBTi17VQ4vhvFe3K sK+f6f0UVgCMO8168hT/BetFOoRPvQAMYDSULsUw+Xkthv0uXjWBI61FJrOckbdg7e3U ZMAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=cSOBTSyPb/di+SkjbPUJcCXOSAz7iyfDpQTy1+SJTes=; b=jFIWqE9YXpF6zyZPplUALY0ytnUHM7YrVyczH3cXBzrjV/rFEFw3SZsGyvxU2x+gFA 61k4xmZR0xRgcr8B268yGVACkdYOCRfazVSgrWc80ukEwJet9BiDFAuJ+oKeXhbVTc0N LrnujQj8ZKqds+ZgcoAeCrP9EeoDkIYyYPayEkVHfZp1hsDakS8fzgYzCkpS9PATCbu1 Y6gtz7+ZnWLCmraE21Q8m72/1wHzL9tFsaP6ufcRe09y54iFwaY6Ionw+H4B2BHk27dt B2dmItxShZFpTD/3rtU/1ztbSvy0MTAen8SiUprfljCrA8DQIrHkeEoS8juNMNUnoRM6 CDFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d8si5358289pfq.337.2022.02.16.02.26.54; Wed, 16 Feb 2022 02:27:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbiBPK1C convert rfc822-to-8bit (ORCPT + 99 others); Wed, 16 Feb 2022 05:27:02 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbiBPK1B (ORCPT ); Wed, 16 Feb 2022 05:27:01 -0500 Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2EBEC1C00C0 for ; Wed, 16 Feb 2022 02:26:48 -0800 (PST) Received: from smtpclient.apple (p4fefcd07.dip0.t-ipconnect.de [79.239.205.7]) by mail.holtmann.org (Postfix) with ESMTPSA id 3AF5FCEE3A; Wed, 16 Feb 2022 11:26:43 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\)) Subject: Re: [PATCH] Bluetooth: Fix bt_skb_sendmmsg not allocating partial chunks From: Marcel Holtmann In-Reply-To: <20220215015938.1950978-1-luiz.dentz@gmail.com> Date: Wed, 16 Feb 2022 11:26:40 +0100 Cc: linux-bluetooth@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20220215015938.1950978-1-luiz.dentz@gmail.com> To: Luiz Augusto von Dentz X-Mailer: Apple Mail (2.3693.60.0.1.1) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Luiz, > Since bt_skb_sendmmsg can be used with the likes of SOCK_STREAM it > shall return the partial chunks it could allocate instead of freeing > everything as otherwise it can cause problems like bellow. > > Link: https://lore.kernel.org/linux-bluetooth/aa3ee7ac-6c52-3861-1798-3cc1a37f6ebf@molgen.mpg.de/T/#m1f9673e4ab0d55a7dccf87905337ab2e67d689f1 > Fixes: 81be03e026dc ("Bluetooth: RFCOMM: Replace use of memcpy_from_msg with bt_skb_sendmmsg") > Signed-off-by: Luiz Augusto von Dentz > --- > include/net/bluetooth/bluetooth.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel