Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c692d560-af17-7a6e-c53e-36aa0c9501dc@gmx.de>
Date:   Wed, 23 Feb 2022 23:12:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH BlueZ] Use audio-card-bluetooth icon
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org
References: <20211223175005.52976-1-nicolas.fella@gmx.de>
 <CABBYNZL4ftQ7PCMPywddoZvPcu_D9xkx21o=Bo=g9DtZ=vJStg@mail.gmail.com>
From:   Nicolas Fella <nicolas.fella@gmx.de>
In-Reply-To: <CABBYNZL4ftQ7PCMPywddoZvPcu_D9xkx21o=Bo=g9DtZ=vJStg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

On 1/5/22 20:07, Luiz Augusto von Dentz wrote:
> Hi Nicolas,
>
> On Fri, Dec 24, 2021 at 5:06 PM Nicolas Fella <nicolas.fella@gmx.de> wro=
te:
>> PulseAudio uses this icon for this kind of device
>>
>> Let's be consistent
>>
>> Users will gracefully fall back to audio-card if audio-card-bluetooth
>> is not found
>> ---
>>   src/dbus-common.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/dbus-common.c b/src/dbus-common.c
>> index 5e2c83d52..3611cb013 100644
>> --- a/src/dbus-common.c
>> +++ b/src/dbus-common.c
>> @@ -80,7 +80,7 @@ const char *class_to_icon(uint32_t class)
>>                  case 0x0d: /* Camcorder */
>>                          return "camera-video";
>>                  default:
>> -                       return "audio-card";    /* Other audio device *=
/
>> +                       return "audio-card-bluetooth";  /* Other audio =
device */
>>                  }
>>                  break;
>>          case 0x05:
>> --
>> 2.34.1
> It doesn't seem to be part of
> https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.h=
tml,
> does the icon themes really have such icon?

I can't name any theme that does. There is a request to add it to Breeze
in https://bugs.kde.org/show_bug.cgi?id=3D447431.

If a theme doesn't have audio-card-bluetooth a compliant implementation
will fall back to audio-card, so using it won't hurt.

We have a bit of a chicken-and-egg situation here. Without bluez using
the icon there is less incentive to add it to icon themes.

Cheers

Nicolas